)]}'
{"cinder/image/image_utils.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"9a702ea96e50e8488d1848348f101634d3deb784","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# NOTE(abhishekk): qemu-img convert command supports raw, qcow2, qed,"},{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance does\u0027t support qed and"},{"line_number":60,"context_line":"# vhd(vpc) disk-formats."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_fafda0b1","line":59,"range":{"start_line":59,"start_character":44,"end_line":59,"end_character":50},"updated":"2016-06-08 18:02:40.000000000","message":"nit: doesn\u0027t","commit_id":"593f74bd3244ae14bd77e191057445fcf5ad968d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d2395988f08df65348f8be820eaa8d2e2098e41f","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# NOTE(abhishekk): qemu-img convert command supports raw, qcow2, qed,"},{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance does\u0027t support qed and"},{"line_number":60,"context_line":"# vhd(vpc) disk-formats."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_e27b1cf3","line":59,"range":{"start_line":59,"start_character":44,"end_line":59,"end_character":50},"in_reply_to":"7aa08908_fafda0b1","updated":"2016-06-09 06:18:55.000000000","message":"Done","commit_id":"593f74bd3244ae14bd77e191057445fcf5ad968d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6a6f23ae19f3db177469971776cc59582c57137f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"CONF.register_opts(image_helper_opts)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# NOTE(abhishekk): qemu-img convert command supports raw, qcow2, qed,"},{"line_number":59,"context_line":"# vdi, vmdk and vhd disk-formats but glance doesn\u0027t support qed and"},{"line_number":60,"context_line":"# vhd(vpc) disk-formats."},{"line_number":61,"context_line":"# Ref: http://docs.openstack.org/image-guide/convert-images.html"},{"line_number":62,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_e07a5823","line":61,"range":{"start_line":58,"start_character":0,"end_line":61,"end_character":64},"updated":"2016-06-13 11:13:09.000000000","message":"So default disk_formats setting in glance-api.conf is:\n\n\u003e disk_formats \u003d ami,ari,aki,vhd,vmdk,raw,qcow2,vdi,iso\n\nAnd I see vhd in here, which you\u0027re listing as not supported. Why is there this inconsistency?","commit_id":"c5df00798acf0bc99ad8dc73d2707e3053e0cbca"}],"cinder/tests/unit/api/contrib/test_volume_actions.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"979c12063a407a16f3cba2c2eb2568bc9df12f2a","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                          body)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_copy_volume_to_image_invalid_disk_format(self):"},{"line_number":690,"context_line":"        id \u003d \u0027aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee\u0027"},{"line_number":691,"context_line":"        vol \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":692,"context_line":"               \"disk_format\": \u0027iso\u0027,"},{"line_number":693,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_1b543bfd","line":690,"updated":"2016-04-06 10:54:57.000000000","message":"Please use fake.image_id","commit_id":"db4f6f5193c28d1ca0064d450e3ed48d73469884"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0b19ac078e24cf5a4cc30ec4b580e493cc8e06ce","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                          body)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_copy_volume_to_image_invalid_disk_format(self):"},{"line_number":690,"context_line":"        id \u003d \u0027aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee\u0027"},{"line_number":691,"context_line":"        vol \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":692,"context_line":"               \"disk_format\": \u0027iso\u0027,"},{"line_number":693,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_b90d4dea","line":690,"in_reply_to":"9a061dce_1b543bfd","updated":"2016-04-06 13:53:01.000000000","message":"Done","commit_id":"db4f6f5193c28d1ca0064d450e3ed48d73469884"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"979c12063a407a16f3cba2c2eb2568bc9df12f2a","unresolved":false,"context_lines":[{"line_number":693,"context_line":"               \"image_name\": \u0027image_name\u0027,"},{"line_number":694,"context_line":"               \"force\": True}"},{"line_number":695,"context_line":"        body \u003d {\"os-volume_upload_image\": vol}"},{"line_number":696,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/tenant1/volumes/%s/action\u0027 % id)"},{"line_number":697,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":698,"context_line":"                          self.controller._volume_upload_image,"},{"line_number":699,"context_line":"                          req,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_5b3eb3da","line":696,"updated":"2016-04-06 10:54:57.000000000","message":"Please use fake.project_id instead of \u0027tenant1\u0027.","commit_id":"db4f6f5193c28d1ca0064d450e3ed48d73469884"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0b19ac078e24cf5a4cc30ec4b580e493cc8e06ce","unresolved":false,"context_lines":[{"line_number":693,"context_line":"               \"image_name\": \u0027image_name\u0027,"},{"line_number":694,"context_line":"               \"force\": True}"},{"line_number":695,"context_line":"        body \u003d {\"os-volume_upload_image\": vol}"},{"line_number":696,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/tenant1/volumes/%s/action\u0027 % id)"},{"line_number":697,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":698,"context_line":"                          self.controller._volume_upload_image,"},{"line_number":699,"context_line":"                          req,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_d9f801c6","line":696,"in_reply_to":"9a061dce_5b3eb3da","updated":"2016-04-06 13:53:01.000000000","message":"Done","commit_id":"db4f6f5193c28d1ca0064d450e3ed48d73469884"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c5f0356f25be645856966e175c47ce0f847ced82","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                          body)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_copy_volume_to_image_invalid_disk_format(self):"},{"line_number":690,"context_line":"        id \u003d fake.image_id"},{"line_number":691,"context_line":"        vol \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":692,"context_line":"               \"disk_format\": \u0027iso\u0027,"},{"line_number":693,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_b33bb637","line":690,"range":{"start_line":690,"start_character":18,"end_line":690,"end_character":26},"updated":"2016-05-09 19:50:31.000000000","message":"I think it should be fake.IMAGE_ID now.","commit_id":"e71a6639c5a6c61730d6477376b56c877a5659fe"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4211b368def1ffa122dad550f33ef0410e772ee4","unresolved":false,"context_lines":[{"line_number":687,"context_line":"                          body)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_copy_volume_to_image_invalid_disk_format(self):"},{"line_number":690,"context_line":"        id \u003d fake.image_id"},{"line_number":691,"context_line":"        vol \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":692,"context_line":"               \"disk_format\": \u0027iso\u0027,"},{"line_number":693,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_a4887cc6","line":690,"range":{"start_line":690,"start_character":18,"end_line":690,"end_character":26},"in_reply_to":"dab17558_b33bb637","updated":"2016-05-10 06:38:28.000000000","message":"Done","commit_id":"e71a6639c5a6c61730d6477376b56c877a5659fe"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"c5f0356f25be645856966e175c47ce0f847ced82","unresolved":false,"context_lines":[{"line_number":694,"context_line":"               \"force\": True}"},{"line_number":695,"context_line":"        body \u003d {\"os-volume_upload_image\": vol}"},{"line_number":696,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/%s/volumes/%s/action\u0027"},{"line_number":697,"context_line":"                                      % (fake.project_id, id))"},{"line_number":698,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":699,"context_line":"                          self.controller._volume_upload_image,"},{"line_number":700,"context_line":"                          req,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_d3275a10","line":697,"range":{"start_line":697,"start_character":46,"end_line":697,"end_character":56},"updated":"2016-05-09 19:50:31.000000000","message":"fake.PROJECT_ID","commit_id":"e71a6639c5a6c61730d6477376b56c877a5659fe"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4211b368def1ffa122dad550f33ef0410e772ee4","unresolved":false,"context_lines":[{"line_number":694,"context_line":"               \"force\": True}"},{"line_number":695,"context_line":"        body \u003d {\"os-volume_upload_image\": vol}"},{"line_number":696,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/%s/volumes/%s/action\u0027"},{"line_number":697,"context_line":"                                      % (fake.project_id, id))"},{"line_number":698,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":699,"context_line":"                          self.controller._volume_upload_image,"},{"line_number":700,"context_line":"                          req,"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_e48e04cf","line":697,"range":{"start_line":697,"start_character":46,"end_line":697,"end_character":56},"in_reply_to":"dab17558_d3275a10","updated":"2016-05-10 06:38:28.000000000","message":"Done","commit_id":"e71a6639c5a6c61730d6477376b56c877a5659fe"}],"cinder/utils.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"1e6fc509df67c4f8b466270ac6059516535f9d12","unresolved":false,"context_lines":[{"line_number":65,"context_line":"VALID_TRACE_FLAGS \u003d {\u0027method\u0027, \u0027api\u0027}"},{"line_number":66,"context_line":"TRACE_METHOD \u003d False"},{"line_number":67,"context_line":"TRACE_API \u003d False"},{"line_number":68,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027cinder-\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_0b1697f0","line":68,"updated":"2016-03-03 06:54:18.000000000","message":"Two points: \n\n1. Is it better to put it into cinder/image/image_utils.py?\n\n2. I think we should not think horizon as standard. Here is openstack doc:\nhttp://docs.openstack.org/image-guide/convert-images.html","commit_id":"4e0a46e4b13b3513fcb04a652ceb4bc773896344"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"64e9af43245885a07c956e214ce645ffdb1a1922","unresolved":false,"context_lines":[{"line_number":65,"context_line":"VALID_TRACE_FLAGS \u003d {\u0027method\u0027, \u0027api\u0027}"},{"line_number":66,"context_line":"TRACE_METHOD \u003d False"},{"line_number":67,"context_line":"TRACE_API \u003d False"},{"line_number":68,"context_line":"VALID_DISK_FORMATS \u003d (\u0027raw\u0027, \u0027vmdk\u0027, \u0027vdi\u0027, \u0027qcow2\u0027)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"synchronized \u003d lockutils.synchronized_with_prefix(\u0027cinder-\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_213b483a","line":68,"in_reply_to":"7af24918_0b1697f0","updated":"2016-03-04 17:35:32.000000000","message":"I agree it makes more sense to put this in image_utils.py","commit_id":"4e0a46e4b13b3513fcb04a652ceb4bc773896344"}]}