)]}'
{"cinder/cmd/manage.py":[{"author":{"_account_id":8202,"name":"chenzongliang","email":"chenzongliang@huawei.com","username":"zongliang"},"change_message_id":"421d34884081e640aae0afe95d812390a53308fd","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                              _(\u0027Status\u0027),"},{"line_number":429,"context_line":"                              _(\u0027State\u0027),"},{"line_number":430,"context_line":"                              _(\u0027Updated At\u0027),"},{"line_number":431,"context_line":"                              _(\u0027rpc_current_version\u0027),"},{"line_number":432,"context_line":"                              _(\u0027object_current_version\u0027)))"},{"line_number":433,"context_line":"        for svc in services:"},{"line_number":434,"context_line":"            alive \u003d utils.service_is_up(svc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_8efdfc70","line":431,"range":{"start_line":431,"start_character":33,"end_line":431,"end_character":52},"updated":"2016-03-07 03:18:20.000000000","message":"I agree with Gorka\u0027s suggestion, the named parameter seems much difference according to above, use a united name will be much better.","commit_id":"12a64a1a0293abd163fc0d3783b021c9c41b018a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d29df852eaffaba47bf569f40b18e06d74229362","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                              _(\u0027State\u0027),"},{"line_number":430,"context_line":"                              _(\u0027Updated At\u0027),"},{"line_number":431,"context_line":"                              _(\u0027rpc_current_version\u0027),"},{"line_number":432,"context_line":"                              _(\u0027object_current_version\u0027)))"},{"line_number":433,"context_line":"        for svc in services:"},{"line_number":434,"context_line":"            alive \u003d utils.service_is_up(svc)"},{"line_number":435,"context_line":"            art \u003d \":-)\" if alive else \"XXX\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_befdd5b2","line":432,"updated":"2016-03-04 09:22:58.000000000","message":"nit: Why not give it a more \"humane\" name?  It doesn\u0027t need to match the one in the DB.  \u0027RPC Version\u0027 and \u0027Objects Version\u0027 seem like good choices.","commit_id":"12a64a1a0293abd163fc0d3783b021c9c41b018a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"c0a12138e20a75dff91d62ef7bd64844518cfcdf","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                              _(\u0027State\u0027),"},{"line_number":430,"context_line":"                              _(\u0027Updated At\u0027),"},{"line_number":431,"context_line":"                              _(\u0027rpc_current_version\u0027),"},{"line_number":432,"context_line":"                              _(\u0027object_current_version\u0027)))"},{"line_number":433,"context_line":"        for svc in services:"},{"line_number":434,"context_line":"            alive \u003d utils.service_is_up(svc)"},{"line_number":435,"context_line":"            art \u003d \":-)\" if alive else \"XXX\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_33a605ae","line":432,"in_reply_to":"7af24918_befdd5b2","updated":"2016-03-04 16:11:42.000000000","message":"+1","commit_id":"12a64a1a0293abd163fc0d3783b021c9c41b018a"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"f3d95496460b7925168ec1a2e569def2a741e419","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                              _(\u0027State\u0027),"},{"line_number":430,"context_line":"                              _(\u0027Updated At\u0027),"},{"line_number":431,"context_line":"                              _(\u0027rpc_current_version\u0027),"},{"line_number":432,"context_line":"                              _(\u0027object_current_version\u0027)))"},{"line_number":433,"context_line":"        for svc in services:"},{"line_number":434,"context_line":"            alive \u003d utils.service_is_up(svc)"},{"line_number":435,"context_line":"            art \u003d \":-)\" if alive else \"XXX\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4db2134d","line":432,"in_reply_to":"7af24918_befdd5b2","updated":"2016-03-04 14:58:49.000000000","message":"+1","commit_id":"12a64a1a0293abd163fc0d3783b021c9c41b018a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fabd6da6a453b3f20884390952137b8b7b0a93df","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Show a list of all cinder services.\"\"\""},{"line_number":422,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":423,"context_line":"        services \u003d objects.ServiceList.get_all(ctxt)"},{"line_number":424,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-5s %-20s %-12s %-12s\""},{"line_number":425,"context_line":"        print(print_format % (_(\u0027Binary\u0027),"},{"line_number":426,"context_line":"                              _(\u0027Host\u0027),"},{"line_number":427,"context_line":"                              _(\u0027Zone\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_f2392e43","line":424,"updated":"2016-03-07 09:56:31.000000000","message":"-1: Shouldn\u0027t this be?:\n\n %-11s %-14s\"","commit_id":"cbcbe9ab30a824b3bdebf945bac72d4a1d9397eb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f20459b95e56962ba0681a8b384cb9dfa852cb0b","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Show a list of all cinder services.\"\"\""},{"line_number":422,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":423,"context_line":"        services \u003d objects.ServiceList.get_all(ctxt)"},{"line_number":424,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-5s %-20s %-12s %-12s\""},{"line_number":425,"context_line":"        print(print_format % (_(\u0027Binary\u0027),"},{"line_number":426,"context_line":"                              _(\u0027Host\u0027),"},{"line_number":427,"context_line":"                              _(\u0027Zone\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_881cb214","line":424,"in_reply_to":"5aef4532_7be2e8d6","updated":"2016-03-08 12:38:32.000000000","message":"Actually, you chose to make it bigger on one of them, but smaller on the other one, since the length of \"Object Version\" is 14 chars and not 12.  And that will create problems if another column gets added.","commit_id":"cbcbe9ab30a824b3bdebf945bac72d4a1d9397eb"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"90f370fe88874b2617630db975985d931e34fd36","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Show a list of all cinder services.\"\"\""},{"line_number":422,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":423,"context_line":"        services \u003d objects.ServiceList.get_all(ctxt)"},{"line_number":424,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-5s %-20s %-12s %-12s\""},{"line_number":425,"context_line":"        print(print_format % (_(\u0027Binary\u0027),"},{"line_number":426,"context_line":"                              _(\u0027Host\u0027),"},{"line_number":427,"context_line":"                              _(\u0027Zone\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_7be2e8d6","line":424,"in_reply_to":"5aef4532_f2392e43","updated":"2016-03-08 03:09:38.000000000","message":"We don\u0027t follow the rule to set the width as lenth of the string. I made it a little bigger to make it looks better.","commit_id":"cbcbe9ab30a824b3bdebf945bac72d4a1d9397eb"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"82d662d8f0b230f159229689ea384756c65de7c1","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                updated_at \u003d timeutils.normalize_time(updated_at)"},{"line_number":442,"context_line":"            print(print_format % (svc.binary, svc.host.partition(\u0027.\u0027)[0],"},{"line_number":443,"context_line":"                                  svc.availability_zone, status, art,"},{"line_number":444,"context_line":"                                  updated_at, svc.rpc_current_version,"},{"line_number":445,"context_line":"                                  svc.object_current_version))"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    @args(\u0027binary\u0027, type\u003dstr,"},{"line_number":448,"context_line":"          help\u003d\u0027Service to delete from the host.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_1a0e6334","line":445,"range":{"start_line":444,"start_character":46,"end_line":445,"end_character":60},"updated":"2016-03-07 13:57:38.000000000","message":"Liberty is having None in these fields:\n\n cinder-scheduler vagrant-ubuntu-trusty-64             nova             enabled    :-)   2016-03-07 13:52:10  1.11         1.3         \n cinder-backup    vagrant-ubuntu-trusty-64             nova             enabled    :-)   2016-03-07 13:52:11  1.3          1.3         \n cinder-volume    vagrant-ubuntu-trusty-64             nova             enabled    :-)   2016-03-07 13:52:10  1.40         1.3         \n cinder-volume    vagrant-ubuntu-trusty-64             nova             enabled    :-)   2016-03-07 13:52:10  1.40         1.3         \n cinder-scheduler vagrant-ubuntu-trusty-64-cn          nova             enabled    :-)   2016-03-07 13:52:10  None         None        \n cinder-backup    vagrant-ubuntu-trusty-64-cn          nova             enabled    :-)   2016-03-07 13:52:11  None         None        \n cinder-volume    vagrant-ubuntu-trusty-64-cn          nova             enabled    :-)   2016-03-07 13:52:05  None         None        \n cinder-volume    vagrant-ubuntu-trusty-64-cn          nova             enabled    :-)   2016-03-07 13:52:14  None         None    \n\nI think you should map None to correct version using cinder.rpc.LIBERTY_RPC_VERSIONS and show \u0027liberty\u0027 in case of Object Version (that\u0027s the mnemonic we use internally in cinder.objects.base, probably that wasn\u0027t the best idea for consistency…).","commit_id":"cbcbe9ab30a824b3bdebf945bac72d4a1d9397eb"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"90f370fe88874b2617630db975985d931e34fd36","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                updated_at \u003d timeutils.normalize_time(updated_at)"},{"line_number":442,"context_line":"            print(print_format % (svc.binary, svc.host.partition(\u0027.\u0027)[0],"},{"line_number":443,"context_line":"                                  svc.availability_zone, status, art,"},{"line_number":444,"context_line":"                                  updated_at, svc.rpc_current_version,"},{"line_number":445,"context_line":"                                  svc.object_current_version))"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    @args(\u0027binary\u0027, type\u003dstr,"},{"line_number":448,"context_line":"          help\u003d\u0027Service to delete from the host.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_db35fc46","line":445,"range":{"start_line":444,"start_character":46,"end_line":445,"end_character":60},"in_reply_to":"5aef4532_1a0e6334","updated":"2016-03-08 03:09:38.000000000","message":"Another option is to leave it as \u0027\u0027.  To make it clearer, I choose the solution Michal proposed.","commit_id":"cbcbe9ab30a824b3bdebf945bac72d4a1d9397eb"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"69d4c25949fe9d9aa9d0376539cfded5d4c6d4ff","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Show a list of all cinder services.\"\"\""},{"line_number":422,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":423,"context_line":"        services \u003d objects.ServiceList.get_all(ctxt)"},{"line_number":424,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-5s %-20s %-12s %-12s\""},{"line_number":425,"context_line":"        print(print_format % (_(\u0027Binary\u0027),"},{"line_number":426,"context_line":"                              _(\u0027Host\u0027),"},{"line_number":427,"context_line":"                              _(\u0027Zone\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_48862a14","line":424,"updated":"2016-03-08 12:42:38.000000000","message":"-1: I insist that the last %-12s is too small, it should be at least %-14s, it may be fine now, but it will be a problem if a new column gets added.","commit_id":"f73fe4070110535ac3882dfc502d38e7109e75b0"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"8702317369b35fe7c51716d1212aa00142bfe8fe","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        \"\"\"Show a list of all cinder services.\"\"\""},{"line_number":422,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":423,"context_line":"        services \u003d objects.ServiceList.get_all(ctxt)"},{"line_number":424,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-5s %-20s %-12s %-12s\""},{"line_number":425,"context_line":"        print(print_format % (_(\u0027Binary\u0027),"},{"line_number":426,"context_line":"                              _(\u0027Host\u0027),"},{"line_number":427,"context_line":"                              _(\u0027Zone\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_87b480d1","line":424,"in_reply_to":"5aef4532_48862a14","updated":"2016-03-09 01:01:32.000000000","message":"You are right. I thought it was last column and didn\u0027t care about this point. Updated in patch 4.","commit_id":"f73fe4070110535ac3882dfc502d38e7109e75b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"69d4c25949fe9d9aa9d0376539cfded5d4c6d4ff","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                           svc.rpc_current_version else"},{"line_number":444,"context_line":"                           rpc.LIBERTY_RPC_VERSIONS.get(svc.binary, \u0027\u0027))"},{"line_number":445,"context_line":"            object_version \u003d (svc.object_current_version if"},{"line_number":446,"context_line":"                              svc.object_current_version else \u0027liberty\u0027)"},{"line_number":447,"context_line":"            print(print_format % (svc.binary, svc.host.partition(\u0027.\u0027)[0],"},{"line_number":448,"context_line":"                                  svc.availability_zone, status, art,"},{"line_number":449,"context_line":"                                  updated_at, rpc_version,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_88c67247","line":446,"updated":"2016-03-08 12:42:38.000000000","message":"nit: These 2 could be simplified to:\n\n rpc_version \u003d (svc.rpc_current_version or\n                rpc.LIBERTY_RPC_VERSIONS.get(svc.binary, \u0027\u0027))\n object_version \u003d svc.object_current_version or \u0027liberty\u0027","commit_id":"f73fe4070110535ac3882dfc502d38e7109e75b0"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"8702317369b35fe7c51716d1212aa00142bfe8fe","unresolved":false,"context_lines":[{"line_number":443,"context_line":"                           svc.rpc_current_version else"},{"line_number":444,"context_line":"                           rpc.LIBERTY_RPC_VERSIONS.get(svc.binary, \u0027\u0027))"},{"line_number":445,"context_line":"            object_version \u003d (svc.object_current_version if"},{"line_number":446,"context_line":"                              svc.object_current_version else \u0027liberty\u0027)"},{"line_number":447,"context_line":"            print(print_format % (svc.binary, svc.host.partition(\u0027.\u0027)[0],"},{"line_number":448,"context_line":"                                  svc.availability_zone, status, art,"},{"line_number":449,"context_line":"                                  updated_at, rpc_version,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_47e1d8cf","line":446,"in_reply_to":"5aef4532_88c67247","updated":"2016-03-09 01:01:32.000000000","message":"Thank you! I am learning to make myself more pythonic.","commit_id":"f73fe4070110535ac3882dfc502d38e7109e75b0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d27e42156518c2d979148b4a62e3ef1d70b540d","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                updated_at \u003d timeutils.normalize_time(updated_at)"},{"line_number":442,"context_line":"            rpc_version \u003d (svc.rpc_current_version or"},{"line_number":443,"context_line":"                           rpc.LIBERTY_RPC_VERSIONS.get(svc.binary, \u0027\u0027))"},{"line_number":444,"context_line":"            object_version \u003d (svc.object_current_version or \u0027liberty\u0027)"},{"line_number":445,"context_line":"            print(print_format % (svc.binary, svc.host.partition(\u0027.\u0027)[0],"},{"line_number":446,"context_line":"                                  svc.availability_zone, status, art,"},{"line_number":447,"context_line":"                                  updated_at, rpc_version,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_ca1f9206","line":444,"updated":"2016-03-09 12:22:54.000000000","message":"nit: No need for parenthesis here","commit_id":"5620901ba3be32d2e96d75bee4765b6aa03a1d58"}]}