)]}'
{"cinder/constants.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b238fa6ae2b8460937bdd6aa2d67b9c254193de9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Cinder constants.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"SCHEDULER_BINARY \u003d \"cinder-scheduler\""},{"line_number":20,"context_line":"VOLUME_BINARY \u003d \"cinder-volume\""},{"line_number":21,"context_line":"BACKUP_BINARY \u003d \"cinder-backup\""},{"line_number":22,"context_line":"SCHEDULER_TOPIC \u003d SCHEDULER_BINARY"},{"line_number":23,"context_line":"VOLUME_TOPIC \u003d VOLUME_BINARY"},{"line_number":24,"context_line":"BACKUP_TOPIC \u003d BACKUP_BINARY"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_db2b8880","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":28},"updated":"2016-03-04 12:31:27.000000000","message":"Eric was opposed to that, I don\u0027t know if his judgement changed by the fact that we\u0027re removing config opts completely.","commit_id":"d985d47705a4807ddca6b4300ec1064fca2a83e0"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f0a9430e4d1cc234e70527e14e9ab7a9e4f2a27d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Cinder constants.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"SCHEDULER_BINARY \u003d \"cinder-scheduler\""},{"line_number":20,"context_line":"VOLUME_BINARY \u003d \"cinder-volume\""},{"line_number":21,"context_line":"BACKUP_BINARY \u003d \"cinder-backup\""},{"line_number":22,"context_line":"SCHEDULER_TOPIC \u003d SCHEDULER_BINARY"},{"line_number":23,"context_line":"VOLUME_TOPIC \u003d VOLUME_BINARY"},{"line_number":24,"context_line":"BACKUP_TOPIC \u003d BACKUP_BINARY"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_8b1f5d07","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":28},"updated":"2016-03-17 11:33:51.000000000","message":"You can add this to already existing cinder.common.constants module.","commit_id":"5e957ba6a2996eeda60bacb5a2c3ec1236f9ecde"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"d039a3f34c7a2424572569f336f11979d3ece5d4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"Cinder constants.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"SCHEDULER_BINARY \u003d \"cinder-scheduler\""},{"line_number":20,"context_line":"VOLUME_BINARY \u003d \"cinder-volume\""},{"line_number":21,"context_line":"BACKUP_BINARY \u003d \"cinder-backup\""},{"line_number":22,"context_line":"SCHEDULER_TOPIC \u003d SCHEDULER_BINARY"},{"line_number":23,"context_line":"VOLUME_TOPIC \u003d VOLUME_BINARY"},{"line_number":24,"context_line":"BACKUP_TOPIC \u003d BACKUP_BINARY"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_621be7ca","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":28},"in_reply_to":"1af94dfe_8b1f5d07","updated":"2016-03-18 04:21:44.000000000","message":"Done","commit_id":"5e957ba6a2996eeda60bacb5a2c3ec1236f9ecde"}],"cinder/scheduler/host_manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b238fa6ae2b8460937bdd6aa2d67b9c254193de9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_utils import timeutils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder.constants import VOLUME_TOPIC"},{"line_number":27,"context_line":"from cinder import context as cinder_context"},{"line_number":28,"context_line":"from cinder import exception"},{"line_number":29,"context_line":"from cinder import objects"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_bb615cd5","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":41},"updated":"2016-03-04 12:31:27.000000000","message":"According to our hacking rules [1] we\u0027re not supposed to import objects, but modules Same of course goes for other occurrences in the patch.\n\n[1] http://docs.openstack.org/developer/hacking/#imports","commit_id":"d985d47705a4807ddca6b4300ec1064fca2a83e0"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"6f6f023ff104212bbd7ffd58bb8e10e9916a7b81","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_utils import timeutils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from cinder.constants import VOLUME_TOPIC"},{"line_number":27,"context_line":"from cinder import context as cinder_context"},{"line_number":28,"context_line":"from cinder import exception"},{"line_number":29,"context_line":"from cinder import objects"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_c4871411","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":41},"in_reply_to":"7af24918_bb615cd5","updated":"2016-03-15 12:25:19.000000000","message":"Done. Will fix it in next patch.","commit_id":"d985d47705a4807ddca6b4300ec1064fca2a83e0"}],"cinder/volume/manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7b0b044b356f43c8ae111952de85b3c9f97c1e83","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from taskflow import exceptions as tfe"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"from cinder import compute"},{"line_number":56,"context_line":"from cinder.common import constants"},{"line_number":57,"context_line":"from cinder import context"},{"line_number":58,"context_line":"from cinder import exception"},{"line_number":59,"context_line":"from cinder import flow_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa0719c6_19ac799f","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":35},"updated":"2016-03-22 12:16:12.000000000","message":"This causes PEP8 error - should go before line 55.","commit_id":"d040a69a51b5c32104cf94c8fdb02450516d0ad1"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"35984b3cda60b47c97e69fc59dd6d4e3461fd209","unresolved":false,"context_lines":[{"line_number":53,"context_line":"from taskflow import exceptions as tfe"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"from cinder import compute"},{"line_number":56,"context_line":"from cinder.common import constants"},{"line_number":57,"context_line":"from cinder import context"},{"line_number":58,"context_line":"from cinder import exception"},{"line_number":59,"context_line":"from cinder import flow_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"da0c15f0_5c79fb2e","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":35},"in_reply_to":"fa0719c6_19ac799f","updated":"2016-03-25 03:55:41.000000000","message":"Done","commit_id":"d040a69a51b5c32104cf94c8fdb02450516d0ad1"}],"releasenotes/notes/removed-rpc-topic-config-options-21c2b3f0e64f884c.yaml":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7b0b044b356f43c8ae111952de85b3c9f97c1e83","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The config options \u0027scheduler_topic\u0027, \u0027volume_topic\u0027"},{"line_number":4,"context_line":"    and \u0027backup_topic\u0027 have been removed without a "},{"line_number":5,"context_line":"    deprecation period as these had never worked"},{"line_number":6,"context_line":"    correctly."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa0719c6_96e696b2","line":4,"range":{"start_line":4,"start_character":50,"end_line":4,"end_character":51},"updated":"2016-03-22 12:16:12.000000000","message":"Trailing whitespace.","commit_id":"d040a69a51b5c32104cf94c8fdb02450516d0ad1"},{"author":{"_account_id":11215,"name":"Vivek Dhayaal","email":"vivekdhayaal@gmail.com","username":"vivekdhayaal"},"change_message_id":"35984b3cda60b47c97e69fc59dd6d4e3461fd209","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The config options \u0027scheduler_topic\u0027, \u0027volume_topic\u0027"},{"line_number":4,"context_line":"    and \u0027backup_topic\u0027 have been removed without a "},{"line_number":5,"context_line":"    deprecation period as these had never worked"},{"line_number":6,"context_line":"    correctly."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da0c15f0_fc8e0f26","line":4,"range":{"start_line":4,"start_character":50,"end_line":4,"end_character":51},"in_reply_to":"fa0719c6_96e696b2","updated":"2016-03-25 03:55:41.000000000","message":"Done","commit_id":"d040a69a51b5c32104cf94c8fdb02450516d0ad1"}]}