)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"fafafac2ac492b6f91533fa50acddb2ff18a3fe6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Jura \u003cmjura@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-07 11:29:32 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"For rbd backend, we want to tune and increase number of retries"},{"line_number":8,"context_line":"and setup interval time for _try_remove_volume()."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Otherwise we can get following problem:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_4bab038a","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"updated":"2016-03-07 12:46:01.000000000","message":"The first line should be limited to 50 characters and should not end with a period.\nSee the link for commit messages:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"7a7c007eec7e2ec7bed1e99537b1c5fd7f2f0e58"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"92043f8df5ebd9aefef6c4a03becb6ff8ee287be","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1230715663ea00c3eb4241154e6f194dee0e23d4"},{"line_number":17,"context_line":"Co-Authored-By: Dirk Mueller \u003cdirk@dmllr.de\u003e"},{"line_number":18,"context_line":"Closes-Bug: #1464259"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_ee513d10","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":20},"updated":"2016-03-07 12:58:50.000000000","message":"I think there is a different error in the bug report. Shouldn\u0027t we create a new one?","commit_id":"b3844a18b7fc51db86f040db34481cf064b7df5e"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"2420a11e6e0fde81a96e8b9f055fdc935b758901","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Jura \u003cmjura@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-07 17:13:17 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make rados connection interval and retries"},{"line_number":8,"context_line":"configurable for _try_remove_volume()"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Otherwise on slow ceph clusters, we can get following problem:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_e3814b91","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":37},"updated":"2016-03-07 16:38:06.000000000","message":"First line should be limited to 50 characters and should not run on to a second line.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nSo maybe something like:\n\n\u0027Fix failure with rbd on slow ceph clusters\n\nMake rados connection interval and retries configurable ...\u0027","commit_id":"6b3947c6848f5edb6c3228f558b742e33505cb57"},{"author":{"_account_id":8151,"name":"Michal Jura","email":"mjura@suse.com","username":"mjura"},"change_message_id":"8b520e9506d8b96cc2dbe1ce57d0424abbfb1a8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal Jura \u003cmjura@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-07 17:13:17 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make rados connection interval and retries"},{"line_number":8,"context_line":"configurable for _try_remove_volume()"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Otherwise on slow ceph clusters, we can get following problem:"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_de1b1c1a","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":37},"in_reply_to":"5aef4532_e3814b91","updated":"2016-03-08 10:14:53.000000000","message":"Thank you, for suggestion. It was done","commit_id":"6b3947c6848f5edb6c3228f558b742e33505cb57"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"675eeb695ceed242e59f57cd91e74c33c6cd4ed6","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            @utils.retry(self.rbd.ImageBusy,"},{"line_number":706,"context_line":"                         CONF.rados_connection_interval,"},{"line_number":707,"context_line":"                         CONF.rados_connection_retries)"},{"line_number":708,"context_line":"            def _try_remove_volume(client, volume_name):"},{"line_number":709,"context_line":"                self.RBDProxy().remove(client.ioctx, volume_name)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_c0c88a77","line":707,"updated":"2016-03-07 14:45:36.000000000","message":"This has to use self.configuration to work correctly with multi-backend configurations.","commit_id":"6a81cfecd36c50601285f595e80f8c62cdb97f18"},{"author":{"_account_id":8151,"name":"Michal Jura","email":"mjura@suse.com","username":"mjura"},"change_message_id":"d44c8feccf1e90fac0056841c1230cb3be683b22","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            @utils.retry(self.rbd.ImageBusy,"},{"line_number":706,"context_line":"                         CONF.rados_connection_interval,"},{"line_number":707,"context_line":"                         CONF.rados_connection_retries)"},{"line_number":708,"context_line":"            def _try_remove_volume(client, volume_name):"},{"line_number":709,"context_line":"                self.RBDProxy().remove(client.ioctx, volume_name)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_14cc7734","line":707,"in_reply_to":"5aef4532_c0c88a77","updated":"2016-03-07 15:05:56.000000000","message":"Thank you, I will fix it.","commit_id":"6a81cfecd36c50601285f595e80f8c62cdb97f18"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c5c4c5085b7451adafbb15b6e7aa8500eaba66e9","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        return args"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    @utils.retry(exception.VolumeBackendAPIException,"},{"line_number":318,"context_line":"                 self.configuration.rados_connection_interval,"},{"line_number":319,"context_line":"                 self.configuration.rados_connection_retries)"},{"line_number":320,"context_line":"    def _connect_to_rados(self, pool\u003dNone):"},{"line_number":321,"context_line":"        LOG.debug(\"opening connection to ceph cluster (timeout\u003d%s).\","}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_f7f2ad99","line":318,"updated":"2016-03-07 15:18:42.000000000","message":"There is no \"self\" here...","commit_id":"ce70030a9d8296a23ddf0d12aa190271ed4c0362"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"dd7f68772a98c758125a84fa49e9ad9bf767be32","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            finally:"},{"line_number":703,"context_line":"                rbd_image.close()"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            rados_con_interval \u003d self.configuration.rados_connection_interval"},{"line_number":706,"context_line":"            rados_con_retries \u003d self.configuration.rados_connection_retries"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"            @utils.retry(self.rbd.ImageBusy,"},{"line_number":709,"context_line":"                         rados_con_interval,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_574a46ad","line":706,"range":{"start_line":705,"start_character":0,"end_line":706,"end_character":75},"updated":"2016-03-08 14:56:18.000000000","message":"Looks like self.configuration is mocked in tests - you need to add these options somewhere around [1].\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_rbd.py#L138-L146","commit_id":"bd57cd69ac7f8ca2f82602984cc4ed95f9a0f186"},{"author":{"_account_id":8151,"name":"Michal Jura","email":"mjura@suse.com","username":"mjura"},"change_message_id":"8315826bddf730ed94a94e7d52eab143a5de2fc0","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            finally:"},{"line_number":703,"context_line":"                rbd_image.close()"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            rados_con_interval \u003d self.configuration.rados_connection_interval"},{"line_number":706,"context_line":"            rados_con_retries \u003d self.configuration.rados_connection_retries"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"            @utils.retry(self.rbd.ImageBusy,"},{"line_number":709,"context_line":"                         rados_con_interval,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5aef4532_d2f664f8","line":706,"range":{"start_line":705,"start_character":0,"end_line":706,"end_character":75},"in_reply_to":"5aef4532_574a46ad","updated":"2016-03-08 15:04:30.000000000","message":"Thank you for pointing this, I think that I fixed it","commit_id":"bd57cd69ac7f8ca2f82602984cc4ed95f9a0f186"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4f8ec183b223e0fd045ec056278a5f8f39f6f00e","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            finally:"},{"line_number":703,"context_line":"                rbd_image.close()"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            rados_con_interval \u003d self.configuration.rados_connection_interval"},{"line_number":706,"context_line":"            rados_con_retries \u003d self.configuration.rados_connection_retries"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"            @utils.retry(self.rbd.ImageBusy,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_e80d5f91","line":705,"updated":"2016-03-08 20:00:46.000000000","message":"These variables don\u0027t need to be created since you\u0027re using self.configuration from within a method here -- just use them directly.","commit_id":"fabde5ff6a6517706e5541a2c1a2951e20c7da99"},{"author":{"_account_id":8151,"name":"Michal Jura","email":"mjura@suse.com","username":"mjura"},"change_message_id":"936e33ad4d1311db2e95c4f3b4f0ce3501b678d6","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            finally:"},{"line_number":703,"context_line":"                rbd_image.close()"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            rados_con_interval \u003d self.configuration.rados_connection_interval"},{"line_number":706,"context_line":"            rados_con_retries \u003d self.configuration.rados_connection_retries"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"            @utils.retry(self.rbd.ImageBusy,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5aef4532_a91ce613","line":705,"in_reply_to":"5aef4532_e80d5f91","updated":"2016-03-09 07:52:22.000000000","message":"Thank you Eric, I\u0027ve fixed it","commit_id":"fabde5ff6a6517706e5541a2c1a2951e20c7da99"}]}