)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"09093e3de83e126df3532c2eb2adc2cd51486940","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhengyao1 \u003czheng.yao1@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-07 23:19:36 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrate volume failure, the migration-status should be set \u0027error\u0027 status"},{"line_number":8,"context_line":"This function _clean_temporary_volume is mainly used to clean up the"},{"line_number":9,"context_line":"resources after the failure of the volume migration."},{"line_number":10,"context_line":"so the migration-status should be set error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_e00946df","line":7,"updated":"2016-03-07 14:42:53.000000000","message":"Please reformat the commit message to follow the guidelines here:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nThe summary line should be within 50 characters, so maybe do something like:\n\n\"Migration status should be set to error on failure\n\nWhen volume migration fails, the migration-status should be...\"","commit_id":"d3c54097299307e4e139a66d255c47bb9aa6cb2e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4c55f1d136425298999392eca1b66113a7e1c632","unresolved":false,"context_lines":[{"line_number":8,"context_line":"This function _clean_temporary_volume is mainly used to clean up the"},{"line_number":9,"context_line":"resources after the failure of the volume migration."},{"line_number":10,"context_line":"so the migration-status should be set error."},{"line_number":11,"context_line":"Closes-Bug: #1550649"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2fb544b797e8c64b13a2c61218e90434207fac51"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_1e600e35","line":11,"updated":"2016-03-07 16:36:16.000000000","message":"There should be a blank line before \u0027Closes-Bug\u0027","commit_id":"d3c54097299307e4e139a66d255c47bb9aa6cb2e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"8f42b24b6f13fcd087aca5aa1be53fb02b7cc9a9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhengyao1 \u003czheng.yao1@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-08 12:26:23 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrate volume failure the migration-status should be set \u0027error\u0027"},{"line_number":8,"context_line":"This function _clean_temporary_volume is mainly used to"},{"line_number":9,"context_line":"clean up the resources after the failure of the volume"},{"line_number":10,"context_line":"migration.so the migration-status should be set error."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_06137267","line":7,"updated":"2016-03-08 14:05:24.000000000","message":"Commit message should be less than 50 characters: http://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"08e96b7eee6c296855b82f19e1fbf7abcc689d8e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"8f42b24b6f13fcd087aca5aa1be53fb02b7cc9a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Migrate volume failure the migration-status should be set \u0027error\u0027"},{"line_number":8,"context_line":"This function _clean_temporary_volume is mainly used to"},{"line_number":9,"context_line":"clean up the resources after the failure of the volume"},{"line_number":10,"context_line":"migration.so the migration-status should be set error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1550649"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_8607821b","line":10,"updated":"2016-03-08 14:05:24.000000000","message":"s/s/S","commit_id":"08e96b7eee6c296855b82f19e1fbf7abcc689d8e"}],"cinder/volume/manager.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"900d69f25ab7c55d01bdfca0ba6b55a70583fd3a","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"            # source! But the migration_status in database should"},{"line_number":1813,"context_line":"            # be cleared to handle volume after migration failure"},{"line_number":1814,"context_line":"            try:"},{"line_number":1815,"context_line":"                new_volume.migration_status \u003d \u0027error\u0027"},{"line_number":1816,"context_line":"                new_volume.save()"},{"line_number":1817,"context_line":"            except exception.VolumeNotFound:"},{"line_number":1818,"context_line":"                LOG.info(_LI(\"Couldn\u0027t find destination volume \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_1de59436","line":1815,"updated":"2016-03-08 06:13:16.000000000","message":"I feel we don\u0027t need this update to \"error\", since cinder will update it again at here: https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L1978.\n\nSo I suggest just to remove this code.","commit_id":"08e96b7eee6c296855b82f19e1fbf7abcc689d8e"}]}