)]}'
{"cinder/tests/unit/fake_driver.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6026771fbe864c983ac7b0406a6a2ed0428b548c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                \u0027volume_backend_name\u0027),"},{"line_number":203,"context_line":"            \u0027vendor_name\u0027: \u0027LoggingVolumeDriver\u0027,"},{"line_number":204,"context_line":"            \u0027total_capacity_gb\u0027: \u0027infinite\u0027,"},{"line_number":205,"context_line":"            \u0027free_capacity_gb\u0027: \u0027infinite\u0027"},{"line_number":206,"context_line":"        }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_be4570b4","line":205,"range":{"start_line":205,"start_character":41,"end_line":205,"end_character":42},"updated":"2016-03-08 10:20:35.000000000","message":"According to our hacking guidelines [1] we\u0027re supposed to add comma in the last line too.\n\n[1] http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"cfdd12b7fea2be5efe8e9b1f62d886616fb2b382"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2fdc003fed1562e8307f56c8ea2b440a42613a19","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            \u0027volume_backend_name\u0027: self.configuration.safe_get("},{"line_number":202,"context_line":"                \u0027volume_backend_name\u0027),"},{"line_number":203,"context_line":"            \u0027vendor_name\u0027: \u0027LoggingVolumeDriver\u0027,"},{"line_number":204,"context_line":"            \u0027total_capacity_gb\u0027: \u0027infinite\u0027,"},{"line_number":205,"context_line":"            \u0027free_capacity_gb\u0027: \u0027infinite\u0027"},{"line_number":206,"context_line":"        }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_396356b3","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":42},"updated":"2016-03-07 21:06:22.000000000","message":"Concerned about using infinite here.  We had a different path through the scheduler in the case that infinite is specified because we want to punish vendors for just reporting infinite capacity.  So, I think actually setting a value might be safer in the long run.","commit_id":"cfdd12b7fea2be5efe8e9b1f62d886616fb2b382"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"3e5cb94c7859ee5880d35cba698eb981c40f0e24","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            \u0027volume_backend_name\u0027: self.configuration.safe_get("},{"line_number":202,"context_line":"                \u0027volume_backend_name\u0027),"},{"line_number":203,"context_line":"            \u0027vendor_name\u0027: \u0027LoggingVolumeDriver\u0027,"},{"line_number":204,"context_line":"            \u0027total_capacity_gb\u0027: \u0027infinite\u0027,"},{"line_number":205,"context_line":"            \u0027free_capacity_gb\u0027: \u0027infinite\u0027"},{"line_number":206,"context_line":"        }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_183daf2b","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":42},"in_reply_to":"5aef4532_396356b3","updated":"2016-03-07 23:35:29.000000000","message":"Is this what you\u0027re referring to - https://github.com/openstack/cinder/blob/master/cinder/scheduler/weights/capacity.py#L112? If so, I don\u0027t see it as a big concern since it seems reasonable to give this driver the lowest priority if it\u0027s being chosen from the multibackend.  TBH I\u0027d expect this driver to used explicitly (through default or volume type) since I don\u0027t see it making sense to use this with multibackend with other real drivers.  Lemme know if I\u0027m missing something.","commit_id":"cfdd12b7fea2be5efe8e9b1f62d886616fb2b382"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"63004d91bebc2e5dd9bb8faac8d152b2be5fafea","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                \u0027volume_backend_name\u0027),"},{"line_number":203,"context_line":"            \u0027vendor_name\u0027: \u0027LoggingVolumeDriver\u0027,"},{"line_number":204,"context_line":"            \u0027total_capacity_gb\u0027: \u0027infinite\u0027,"},{"line_number":205,"context_line":"            \u0027free_capacity_gb\u0027: \u0027infinite\u0027"},{"line_number":206,"context_line":"        }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_4c5ab451","line":205,"range":{"start_line":205,"start_character":41,"end_line":205,"end_character":42},"in_reply_to":"5aef4532_be4570b4","updated":"2016-03-08 16:01:37.000000000","message":"Done","commit_id":"cfdd12b7fea2be5efe8e9b1f62d886616fb2b382"}]}