)]}'
{"cinder/tests/unit/test_rbd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0448774c1131fc1eb51a8bd4be2651e5b9b238c7","unresolved":false,"context_lines":[{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        self.driver._clone(self.volume_a, src_pool, src_image, src_snap)"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        chunk_size \u003d self.cfg.rbd_store_chunk_size * units.Mi"},{"line_number":865,"context_line":"        order \u003d int(math.log(chunk_size, 2))"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        args \u003d [client_stack[0].ioctx, str(src_image), str(src_snap),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_5bf07667","line":864,"updated":"2016-03-09 13:13:48.000000000","message":"-1: I don\u0027t think this is a good test as we are just replicating the same code we have in the driver.\n\nWe should probably use ddt to test a bunch of know values and expected results overwriting rbd_store_chunk_size configuration.","commit_id":"69c58addb47a304219fa1090ff68ee82de68de25"},{"author":{"_account_id":9064,"name":"Danny Al-Gaaf","email":"danny.al-gaaf@bisect.de","username":"dalgaaf"},"change_message_id":"5467cff9ff4d8eb45789ffd34c3f2ef953831278","unresolved":false,"context_lines":[{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        self.driver._clone(self.volume_a, src_pool, src_image, src_snap)"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        chunk_size \u003d self.cfg.rbd_store_chunk_size * units.Mi"},{"line_number":865,"context_line":"        order \u003d int(math.log(chunk_size, 2))"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        args \u003d [client_stack[0].ioctx, str(src_image), str(src_snap),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_6aebd513","line":864,"in_reply_to":"5aef4532_5bf07667","updated":"2016-03-09 14:27:08.000000000","message":"This change to the test code is needed anyway, otherwise the test would fail.","commit_id":"69c58addb47a304219fa1090ff68ee82de68de25"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f1012f0206e0b22f303dcec0477c4494293f547d","unresolved":false,"context_lines":[{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        self.driver._clone(self.volume_a, src_pool, src_image, src_snap)"},{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        chunk_size \u003d self.cfg.rbd_store_chunk_size * units.Mi"},{"line_number":865,"context_line":"        order \u003d int(math.log(chunk_size, 2))"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"        args \u003d [client_stack[0].ioctx, str(src_image), str(src_snap),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_c70c9f3d","line":864,"in_reply_to":"5aef4532_6aebd513","updated":"2016-03-09 15:16:53.000000000","message":"If the intention is only to make the test pass then you could just replace the `order` variable in L870 with `mock.ANY` and that would also work.\n\nBut that would not mean that the logic is being properly tested.\n\nImagine for a second that you had written units.Ki instead of units.Mi, since you would have copied the code here in the test as it is, the test would still pass, yet the logic would be wrong.\n\nThat\u0027s why we need the test to use specific values.","commit_id":"69c58addb47a304219fa1090ff68ee82de68de25"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7fa77678ab9701294d5ab4517235bba0aea105a6","unresolved":false,"context_lines":[{"line_number":877,"context_line":"              {\u0027rbd_chunk_size\u0027: 32, \u0027order\u0027: 25})"},{"line_number":878,"context_line":"    @ddt.unpack"},{"line_number":879,"context_line":"    @common_mocks"},{"line_number":880,"context_line":"    def test_clone_different_rbd_store_chunk_size(self, rbd_chunk_size, order):"},{"line_number":881,"context_line":"        self.cfg.rbd_store_chunk_size \u003d rbd_chunk_size"},{"line_number":882,"context_line":"        src_pool \u003d u\u0027images\u0027"},{"line_number":883,"context_line":"        src_image \u003d u\u0027image-name\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_e8ab5173","line":880,"updated":"2016-03-09 21:27:51.000000000","message":"I really don\u0027t understand why you created a new test instead of replacing the old one, but thank you for adding this test.","commit_id":"ac9b82c89e787f0dc74b5712a1542ac77b641e69"}]}