)]}'
{"cinder/backup/api.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"440ff5d2d2e29635aef203e90140b821e556ebe4","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        if (not host or not CONF.backup_use_same_host):"},{"line_number":213,"context_line":"            backup_host \u003d self._get_any_available_backup_service(az)"},{"line_number":214,"context_line":"        elif self._is_backup_service_enabled(az, host):"},{"line_number":215,"context_line":"            backup_host \u003d host"},{"line_number":216,"context_line":"        if not backup_host:"},{"line_number":217,"context_line":"            raise exception.ServiceNotFound(service_id\u003d\u0027cinder-backup\u0027)"},{"line_number":218,"context_line":"        return backup_host"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_7613e40d","line":215,"range":{"start_line":215,"start_character":26,"end_line":215,"end_character":30},"updated":"2016-03-09 03:58:58.000000000","message":"If that backup service is not up, we might as well return an error here rather than silently failing the other side of the RPC with no user feedback... not that there\u0027s much they can do, but we might as well tell them","commit_id":"05c5e4c50c5dce0f93424fa82efd99fe32782abb"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"7b0bac5fc7cbb8ab5d8c3dd9171e77c8f732b721","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        if (not host or not CONF.backup_use_same_host):"},{"line_number":213,"context_line":"            backup_host \u003d self._get_any_available_backup_service(az)"},{"line_number":214,"context_line":"        elif self._is_backup_service_enabled(az, host):"},{"line_number":215,"context_line":"            backup_host \u003d host"},{"line_number":216,"context_line":"        if not backup_host:"},{"line_number":217,"context_line":"            raise exception.ServiceNotFound(service_id\u003d\u0027cinder-backup\u0027)"},{"line_number":218,"context_line":"        return backup_host"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_d0b11b91","line":215,"range":{"start_line":215,"start_character":26,"end_line":215,"end_character":30},"in_reply_to":"5aef4532_7613e40d","updated":"2016-03-09 06:39:09.000000000","message":"It raises ServiceNotFound exception in Line 217. And then it returns to user that no service found.","commit_id":"05c5e4c50c5dce0f93424fa82efd99fe32782abb"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8cf630b4f0e270335abea11635a2143265c17b00","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from cinder.volume import utils as volume_utils"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"backup_api_opts \u003d ["},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027backup_use_same_host\u0027,"},{"line_number":47,"context_line":"                default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d\u0027Backup services use same backend.\u0027)"},{"line_number":49,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_6b4264af","line":46,"updated":"2016-03-10 19:42:14.000000000","message":"Please, add deprecated_name\u003d\u0027backup_use_same_backend\u0027. We have to deprecate config param before renaming it because it affects existing deployments","commit_id":"fe7f6bcd6a72caaff1f80f8b6c9a80fd09253c69"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"787b74d3b22a4191fbcfd316866a7cfdf5e0cbf0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from cinder.volume import utils as volume_utils"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"backup_api_opts \u003d ["},{"line_number":46,"context_line":"    cfg.BoolOpt(\u0027backup_use_same_host\u0027,"},{"line_number":47,"context_line":"                default\u003dFalse,"},{"line_number":48,"context_line":"                help\u003d\u0027Backup services use same backend.\u0027)"},{"line_number":49,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_b74fae90","line":46,"in_reply_to":"5aef4532_6b4264af","updated":"2016-03-10 20:15:50.000000000","message":"I think this is a new option added in [1] 3 weeks ago. I don\u0027t really know where is the boundary here when we can expect someone already deployed Cinder with the old option?\n\nWell, maybe we should just assume nothing and follow standard deprecation procedure? Opinions anyone?\n\n[1] https://review.openstack.org/#/c/262395/","commit_id":"fe7f6bcd6a72caaff1f80f8b6c9a80fd09253c69"}]}