)]}'
{"cinder/api/v2/snapshots.py":[{"author":{"_account_id":16426,"name":"Cheney Dong","email":"cheneydc@gmail.com","username":"cheneydc"},"change_message_id":"c4dad48aa3e5a1ac61695341088ba59d705a31a3","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Filter out invalid options"},{"line_number":122,"context_line":"        allowed_search_options \u003d (\u0027status\u0027, \u0027volume_id\u0027, \u0027name\u0027,"},{"line_number":123,"context_line":"                                  \u0027display_name\u0027)"},{"line_number":124,"context_line":"        utils.remove_invalid_filter_options(context, search_opts,"},{"line_number":125,"context_line":"                                            allowed_search_options)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_c973327f","line":123,"range":{"start_line":123,"start_character":47,"end_line":123,"end_character":49},"updated":"2016-03-09 07:50:47.000000000","message":"It\u0027s not a good idea to add display_name here, if specify both \"name\" and \"display_name\", there will be two \"name\" in filters at last. The problem is cinderclient does not parse \"name\" correctly.","commit_id":"854f49b4cd0ecb276c7bb16f6b3aa50bc8ae7ebb"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"df0f63c1932cb362f9f19ee4a3ee92d24fd3d9d8","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Filter out invalid options"},{"line_number":122,"context_line":"        allowed_search_options \u003d (\u0027status\u0027, \u0027volume_id\u0027, \u0027name\u0027,"},{"line_number":123,"context_line":"                                  \u0027display_name\u0027)"},{"line_number":124,"context_line":"        utils.remove_invalid_filter_options(context, search_opts,"},{"line_number":125,"context_line":"                                            allowed_search_options)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_c97df21d","line":123,"range":{"start_line":123,"start_character":47,"end_line":123,"end_character":49},"in_reply_to":"5aef4532_c973327f","updated":"2016-03-09 07:56:12.000000000","message":"Hi, Cheney:\nThanks for your review.\nIf user passes both \"display_name\" and \"name\", the name option will be deleted in line 130.","commit_id":"854f49b4cd0ecb276c7bb16f6b3aa50bc8ae7ebb"},{"author":{"_account_id":16426,"name":"Cheney Dong","email":"cheneydc@gmail.com","username":"cheneydc"},"change_message_id":"f63ca21d059718ec629b4b7b4bc06d5c765053ac","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # Filter out invalid options"},{"line_number":122,"context_line":"        allowed_search_options \u003d (\u0027status\u0027, \u0027volume_id\u0027, \u0027name\u0027,"},{"line_number":123,"context_line":"                                  \u0027display_name\u0027)"},{"line_number":124,"context_line":"        utils.remove_invalid_filter_options(context, search_opts,"},{"line_number":125,"context_line":"                                            allowed_search_options)"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_843c71e3","line":123,"range":{"start_line":123,"start_character":47,"end_line":123,"end_character":49},"in_reply_to":"5aef4532_c97df21d","updated":"2016-03-09 08:28:41.000000000","message":"Yes, but the logic is strange, because code from line 128 to 130 just make a transition as the comment said, and parameters like \"name\" and \"display-name\" which specified in command line are already be considered in cinderclient.","commit_id":"854f49b4cd0ecb276c7bb16f6b3aa50bc8ae7ebb"}]}