)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"012aca184ac7d15cbaa612105f05554b24af6546","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mikhail Khodos \u003cmikhail.khodos@nexenta.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-18 16:03:00 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Small fix for NexentaEdge jsonrpc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed url when retrying the request."},{"line_number":10,"context_line":"LOG.info if the volume is already deleted on appliance instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa0719c6_21575ecf","line":7,"updated":"2016-03-22 22:17:23.000000000","message":"Please, provide more descriptive commit message","commit_id":"e23709bcdf2a6632cb1d99cfcf2a418eef2c9fe8"}],"cinder/volume/drivers/nexenta/iscsi.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"eb9863f0a5be580213c1b90b43f51bbb64b7d967","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        self.nms.zvol.create("},{"line_number":215,"context_line":"            self._get_zvol_name(volume[\u0027name\u0027]),"},{"line_number":216,"context_line":"            \u0027%sG\u0027 % (volume[\u0027size\u0027],),"},{"line_number":217,"context_line":"            str(self.configuration.nexenta_blocksize),"},{"line_number":218,"context_line":"            self.configuration.nexenta_sparse)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def extend_volume(self, volume, new_size):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_88733fb1","line":217,"range":{"start_line":217,"start_character":52,"end_line":217,"end_character":54},"updated":"2016-03-15 20:33:16.000000000","message":"Please use six.text_type instead of str.","commit_id":"4c011cf6f9a8c4da5e57047550faace8483e4169"}],"cinder/volume/drivers/nexenta/nexentaedge/iscsi.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"eb9863f0a5be580213c1b90b43f51bbb64b7d967","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            self.restapi.delete(\u0027service/\u0027 + self.iscsi_service +"},{"line_number":164,"context_line":"                                \u0027/iscsi\u0027, {\u0027objectPath\u0027: self.bucket_path +"},{"line_number":165,"context_line":"                                           \u0027/\u0027 + volume[\u0027name\u0027]})"},{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            pass"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def extend_volume(self, volume, new_size):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_48a017f5","line":166,"range":{"start_line":166,"start_character":50,"end_line":166,"end_character":51},"updated":"2016-03-15 20:33:16.000000000","message":"Better put a log message here instead of nothing.","commit_id":"4c011cf6f9a8c4da5e57047550faace8483e4169"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b37f0848d1f526a1d419c509748361b1f066d7a0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                \u0027/iscsi\u0027, {\u0027objectPath\u0027: self.bucket_path +"},{"line_number":165,"context_line":"                                           \u0027/\u0027 + volume[\u0027name\u0027]})"},{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_e8542c22","line":167,"updated":"2016-03-17 09:42:49.000000000","message":"I think this case needs a unit test.","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"53beffd3dcde36c4bb8a8106548b1b09f76939f2","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                \u0027/iscsi\u0027, {\u0027objectPath\u0027: self.bucket_path +"},{"line_number":165,"context_line":"                                           \u0027/\u0027 + volume[\u0027name\u0027]})"},{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_01dae04b","line":167,"in_reply_to":"1af94dfe_d861153b","updated":"2016-03-18 05:21:48.000000000","message":"Do we need to test the case where restapi.delete raises an exception, but delete volume succeeds? You were previusly re-raising the exception and that case was not tested either.","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@ddn.com","username":"Alexey"},"change_message_id":"e4630ccb2d0a4010da2a0275d75694568320e749","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                \u0027/iscsi\u0027, {\u0027objectPath\u0027: self.bucket_path +"},{"line_number":165,"context_line":"                                           \u0027/\u0027 + volume[\u0027name\u0027]})"},{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_0d1b0182","line":167,"in_reply_to":"1af94dfe_d861153b","updated":"2016-03-18 23:04:30.000000000","message":"Done","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@ddn.com","username":"Alexey"},"change_message_id":"cb971829d20c521c1e54a3f141dacca387b9e4fb","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                                \u0027/iscsi\u0027, {\u0027objectPath\u0027: self.bucket_path +"},{"line_number":165,"context_line":"                                           \u0027/\u0027 + volume[\u0027name\u0027]})"},{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_d861153b","line":167,"in_reply_to":"1af94dfe_e8542c22","updated":"2016-03-17 22:50:13.000000000","message":"what exactly do we need to test here? we only changed the behaviour to log instead of raise","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d865824af3e399072a9d2b0c48dbf9aa2ea22718","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":172,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_35c3e48a","line":169,"updated":"2016-03-17 20:42:37.000000000","message":"Is this volume name unique? Can we use volume ID here?","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@ddn.com","username":"Alexey"},"change_message_id":"e4630ccb2d0a4010da2a0275d75694568320e749","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":172,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_cd2e39a4","line":169,"in_reply_to":"1af94dfe_2f4d1f9a","updated":"2016-03-18 23:04:30.000000000","message":"Good point, fixed.","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@ddn.com","username":"Alexey"},"change_message_id":"cb971829d20c521c1e54a3f141dacca387b9e4fb","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":172,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_b8bc09bc","line":169,"in_reply_to":"1af94dfe_35c3e48a","updated":"2016-03-17 22:50:13.000000000","message":"This looked like the correct name, since we use volume[\u0027name\u0027] in create and other methods. Why change to id?","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"8f5fb3b2c8b1b2f002acd000d60218a795f02029","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027name\u0027])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":172,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_2f4d1f9a","line":169,"in_reply_to":"1af94dfe_b8bc09bc","updated":"2016-03-18 18:07:58.000000000","message":"Volume name is not unique. You can have 2 volumes with the same name. In such case, this log message will be unuseful","commit_id":"4063ebfbec05dabb290f244113e55ede9ad1acc3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"012aca184ac7d15cbaa612105f05554b24af6546","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":167,"context_line":"            LOG.info("},{"line_number":168,"context_line":"                _LI(\u0027Volume %s was already deleted from appliance, skipping\u0027),"},{"line_number":169,"context_line":"                volume[\u0027id\u0027])"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":172,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_21e91e15","line":169,"updated":"2016-03-22 22:17:23.000000000","message":"Please, replace it with \n\nLOG.info(\n        _LI(\u0027Volume was already deleted from appliance, skipping\u0027),\n        resource\u003dvolume)\n\n\nI\u0027m sorry that I didn\u0027t note it in a previous comment","commit_id":"e23709bcdf2a6632cb1d99cfcf2a418eef2c9fe8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f735d0460ad68fb7db90e6195ff0564e41c9e4fc","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        }"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def create_volume(self, volume):"},{"line_number":150,"context_line":"        LOG.warning(volume[\u0027name\u0027])"},{"line_number":151,"context_line":"        try:"},{"line_number":152,"context_line":"            self.restapi.post(\u0027service/\u0027 + self.iscsi_service + \u0027/iscsi\u0027, {"},{"line_number":153,"context_line":"                \u0027objectPath\u0027: self.bucket_path + \u0027/\u0027 + volume[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_433c6c93","line":150,"updated":"2016-03-29 09:26:54.000000000","message":"Is this left over debugging? If providing tracing, it should include more than just a name as the log text, and LOG.warning is too high.","commit_id":"80b4f23c77a46a4c4a5e94f8b1b734ede7f6b1b7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f735d0460ad68fb7db90e6195ff0564e41c9e4fc","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                                           \u0027/\u0027 + volume[\u0027name\u0027]})"},{"line_number":167,"context_line":"        except exception.VolumeBackendAPIException:"},{"line_number":168,"context_line":"            LOG.info("},{"line_number":169,"context_line":"                _LI(\u0027Volume was already deleted from appliance, skipping\u0027),"},{"line_number":170,"context_line":"                resource\u003dvolume)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def extend_volume(self, volume, new_size):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_e372e07b","line":169,"updated":"2016-03-29 09:26:54.000000000","message":"If doing another update, please end with a period.","commit_id":"80b4f23c77a46a4c4a5e94f8b1b734ede7f6b1b7"}],"cinder/volume/drivers/nexenta/options.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"2aea70dfc371766e1f3689bd0d7d50914313b556","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d\u0027NexentaEdge iSCSI Gateway client \u0027"},{"line_number":45,"context_line":"               \u0027address for non-VIP service\u0027),"},{"line_number":46,"context_line":"    cfg.IntOpt(\u0027nexenta_chunksize\u0027,"},{"line_number":47,"context_line":"               default\u003d32768,"},{"line_number":48,"context_line":"               help\u003d\u0027NexentaEdge iSCSI LUN object chunk size\u0027)"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_9b48a82f","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":29},"updated":"2016-03-29 10:16:57.000000000","message":"This change, and the reason for it, should be noted in the commit message","commit_id":"4d0debc364054cfd662b0d5f21d74f084f37a08c"}]}