)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8964dddaa02384e747f771fb70b5200ca79f886f","unresolved":false,"context_lines":[{"line_number":2214,"context_line":"        query \u003d _generate_paginate_query(context, session, marker, limit,"},{"line_number":2215,"context_line":"                                         sort_keys, sort_dirs, filters,"},{"line_number":2216,"context_line":"                                         offset, models.Snapshot)"},{"line_number":2217,"context_line":"        # No snapshots would match, return empty list"},{"line_number":2218,"context_line":"        if not query:"},{"line_number":2219,"context_line":"            return []"},{"line_number":2220,"context_line":"        return query.all()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_b4e6f112","line":2217,"updated":"2016-03-17 13:41:24.000000000","message":"Why is this changed?  I don\u0027t believe this is necessary.","commit_id":"ccb9e599d6046fc60b74c73ac3366f7c69be972a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"54abb75226ff04ca803412c9a92f2ceba9fa0715","unresolved":false,"context_lines":[{"line_number":2214,"context_line":"        query \u003d _generate_paginate_query(context, session, marker, limit,"},{"line_number":2215,"context_line":"                                         sort_keys, sort_dirs, filters,"},{"line_number":2216,"context_line":"                                         offset, models.Snapshot)"},{"line_number":2217,"context_line":"        # No snapshots would match, return empty list"},{"line_number":2218,"context_line":"        if not query:"},{"line_number":2219,"context_line":"            return []"},{"line_number":2220,"context_line":"        return query.all()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_2a29ac37","line":2217,"in_reply_to":"1af94dfe_aa6cca35","updated":"2016-03-18 09:48:09.000000000","message":"Making this change doesn\u0027t add any value beside looking the same as the other methods, which to me doesn\u0027t add much at all.\n\nThough an unnecessary change I guess I wouldn\u0027t downvote for it.\n\nBTW, if you ask me this whole method could be easily simplified:\n\n if filters and not is_valid_model_filters(models.Snapshot, filters):\n     return []\n\n query \u003d _generate_paginate_query(context, marker, limit,\n                                  sort_keys, sort_dirs, filters,\n                                  offset, models.Snapshot)\n\n return query.all() if query else []","commit_id":"ccb9e599d6046fc60b74c73ac3366f7c69be972a"},{"author":{"_account_id":8358,"name":"zhangguoqing","email":"zhang.guoqing@99cloud.net","username":"zhangguoqing"},"change_message_id":"f0c7bd65ab876a1ec5a15572ddf357bd110519e8","unresolved":false,"context_lines":[{"line_number":2214,"context_line":"        query \u003d _generate_paginate_query(context, session, marker, limit,"},{"line_number":2215,"context_line":"                                         sort_keys, sort_dirs, filters,"},{"line_number":2216,"context_line":"                                         offset, models.Snapshot)"},{"line_number":2217,"context_line":"        # No snapshots would match, return empty list"},{"line_number":2218,"context_line":"        if not query:"},{"line_number":2219,"context_line":"            return []"},{"line_number":2220,"context_line":"        return query.all()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_aa6cca35","line":2217,"in_reply_to":"1af94dfe_b4e6f112","updated":"2016-03-17 14:15:02.000000000","message":"Yes, it is necessary. \nI just want to unify with other functions.[eg: volume_get_all(), volume_get_all_*()]","commit_id":"ccb9e599d6046fc60b74c73ac3366f7c69be972a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"54abb75226ff04ca803412c9a92f2ceba9fa0715","unresolved":false,"context_lines":[{"line_number":2239,"context_line":"    # Holds the simple exact matches"},{"line_number":2240,"context_line":"    filter_dict \u003d {}"},{"line_number":2241,"context_line":""},{"line_number":2242,"context_line":"    # Iterate over all filters, special case the filter if necessary"},{"line_number":2243,"context_line":"    for key, value in filters.items():"},{"line_number":2244,"context_line":"        if isinstance(value, (list, tuple, set, frozenset)):"},{"line_number":2245,"context_line":"            # Looking for values in a list; apply to query directly"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_6a01f437","line":2242,"updated":"2016-03-18 09:48:09.000000000","message":"-1: You are missing a couple of things in this implementation, like:\n\n- Not allowing relationship properties\n- If snapshot_metadata field is used check that a dict is the filtered value\n- For snapshot_metadata join SnapshotMetadata model and filter accordingly","commit_id":"ccb9e599d6046fc60b74c73ac3366f7c69be972a"}]}