)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"3d45de58992bd051aa2ad7408cfba6ac1e91cc8f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* In case the new volume is larger than the cloned one,"},{"line_number":10,"context_line":"    resize the cloned volume."},{"line_number":11,"context_line":"* Added unit test for success and failed resize."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22"},{"line_number":14,"context_line":"Closes-Bug: #1554778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_1038d99f","line":12,"updated":"2016-06-22 18:58:02.000000000","message":"Depends-on: I829c0e6f99fff0ec0bd5366c9d2e79b1b073f0a3\n\nTempest currently does not cover the path touched by this fix. So, we should run this extend test as dependency so we can assure they work for all backends after CIs runs.","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"b12156e372b8b06eaab04b048deae59e2cef7308","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* In case the new volume is larger than the cloned one,"},{"line_number":10,"context_line":"    resize the cloned volume."},{"line_number":11,"context_line":"* Added unit test for success and failed resize."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22"},{"line_number":14,"context_line":"Closes-Bug: #1554778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_0cd641c5","line":12,"in_reply_to":"3aaa91ec_1038d99f","updated":"2016-07-03 14:37:15.000000000","message":"Done","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d4e74ec03b7647d1b73af4fdaf43a48b5e67c1c4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* Added unit test for success and failed resize."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22"},{"line_number":14,"context_line":"Depends-on: I829c0e6f99fff0ec0bd5366c9d2e79b1b073f0a3"},{"line_number":15,"context_line":"Closes-Bug: #1554778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_538858c5","line":14,"updated":"2016-07-06 13:52:00.000000000","message":"It is merged, we can remove this line.","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"f673a276f4cb617bd07ae67d1ef15a78dd92c43e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* Added unit test for success and failed resize."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2346049c2177a9497750c05c0eb9e7edf8c12c22"},{"line_number":14,"context_line":"Depends-on: I829c0e6f99fff0ec0bd5366c9d2e79b1b073f0a3"},{"line_number":15,"context_line":"Closes-Bug: #1554778"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_5ecffe7e","line":14,"in_reply_to":"1aa78d24_538858c5","updated":"2016-07-19 13:06:44.000000000","message":"Done","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"}],"cinder/tests/unit/test_emc_xtremio.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"19fc890971750fde2499cc0164fffaf8ee0b18fb","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                          self.driver.client.handle_errors,"},{"line_number":405,"context_line":"                          response, \u0027\u0027, \u0027\u0027)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test_clone_volume_and_resize(self, req):"},{"line_number":408,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":409,"context_line":"        self.driver.db \u003d mock.Mock()"},{"line_number":410,"context_line":"        (self.driver.db."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_48ddbd41","line":407,"updated":"2016-03-21 08:43:20.000000000","message":"The tests including two cases, better to split.","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"b12156e372b8b06eaab04b048deae59e2cef7308","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                          self.driver.client.handle_errors,"},{"line_number":405,"context_line":"                          response, \u0027\u0027, \u0027\u0027)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test_clone_volume_and_resize(self, req):"},{"line_number":408,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":409,"context_line":"        self.driver.db \u003d mock.Mock()"},{"line_number":410,"context_line":"        (self.driver.db."}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_6cdb85ee","line":407,"in_reply_to":"fa0719c6_45de1440","updated":"2016-07-03 14:37:15.000000000","message":"Done","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"74665aa95640e50c6725b4cedf8307cf1ca4cd43","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                          self.driver.client.handle_errors,"},{"line_number":405,"context_line":"                          response, \u0027\u0027, \u0027\u0027)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test_clone_volume_and_resize(self, req):"},{"line_number":408,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":409,"context_line":"        self.driver.db \u003d mock.Mock()"},{"line_number":410,"context_line":"        (self.driver.db."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_7ce7a312","line":407,"in_reply_to":"fa0719c6_48ddbd41","updated":"2016-03-21 09:58:16.000000000","message":"all the test in this file are grouped according to the subject, don\u0027t see why we should change it for this case.","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"37f9dfcd6b309214730595ea83e9467f32d222a4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                          self.driver.client.handle_errors,"},{"line_number":405,"context_line":"                          response, \u0027\u0027, \u0027\u0027)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test_clone_volume_and_resize(self, req):"},{"line_number":408,"context_line":"        req.side_effect \u003d xms_request"},{"line_number":409,"context_line":"        self.driver.db \u003d mock.Mock()"},{"line_number":410,"context_line":"        (self.driver.db."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_45de1440","line":407,"in_reply_to":"fa0719c6_7ce7a312","updated":"2016-03-22 02:53:24.000000000","message":"My understanding is to leave the old unchanged, but for new test it is better to split, as it makes it easier to find problems if the case fails.","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"19fc890971750fde2499cc0164fffaf8ee0b18fb","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        clone[\u0027size\u0027] \u003d 2"},{"line_number":417,"context_line":"        self.driver.create_cloned_volume(self.data.test_clone,"},{"line_number":418,"context_line":"                                         self.data.test_volume)"},{"line_number":419,"context_line":"        self.driver.delete_volume(clone)"},{"line_number":420,"context_line":"        self.delete \u003d False"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        def failed_extend(obj_type\u003d\u0027volumes\u0027, method\u003d\u0027GET\u0027, data\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_c86c2d9f","line":419,"updated":"2016-03-21 08:43:20.000000000","message":"Instead of manually cleaning up here, after volume create_volume you should register a cleanup to have it deleted like here:\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/api/contrib/test_volume_encryption_metadata.py#L185\nThat way if an unexpected exception happens in the test and this line doesn\u0027t get executed, it will still get cleaned up.","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"37f9dfcd6b309214730595ea83e9467f32d222a4","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        clone[\u0027size\u0027] \u003d 2"},{"line_number":417,"context_line":"        self.driver.create_cloned_volume(self.data.test_clone,"},{"line_number":418,"context_line":"                                         self.data.test_volume)"},{"line_number":419,"context_line":"        self.driver.delete_volume(clone)"},{"line_number":420,"context_line":"        self.delete \u003d False"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        def failed_extend(obj_type\u003d\u0027volumes\u0027, method\u003d\u0027GET\u0027, data\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_6578782c","line":419,"in_reply_to":"fa0719c6_9c00b7ac","updated":"2016-03-22 02:53:24.000000000","message":"You are right.","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"74665aa95640e50c6725b4cedf8307cf1ca4cd43","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        clone[\u0027size\u0027] \u003d 2"},{"line_number":417,"context_line":"        self.driver.create_cloned_volume(self.data.test_clone,"},{"line_number":418,"context_line":"                                         self.data.test_volume)"},{"line_number":419,"context_line":"        self.driver.delete_volume(clone)"},{"line_number":420,"context_line":"        self.delete \u003d False"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        def failed_extend(obj_type\u003d\u0027volumes\u0027, method\u003d\u0027GET\u0027, data\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_9c00b7ac","line":419,"in_reply_to":"fa0719c6_c86c2d9f","updated":"2016-03-21 09:58:16.000000000","message":"every test start with a clean environment, this is not for cleanup purposes","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d4e74ec03b7647d1b73af4fdaf43a48b5e67c1c4","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        vol[\u0027num-of-dest-snaps\u0027] \u003d 0"},{"line_number":506,"context_line":"        clone \u003d self.data.test_clone.copy()"},{"line_number":507,"context_line":"        clone[\u0027size\u0027] \u003d 2"},{"line_number":508,"context_line":"        self.driver.create_cloned_volume(self.data.test_clone,"},{"line_number":509,"context_line":"                                         self.data.test_volume)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def test_clone_volume_and_resize_fail(self, req):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_135d3079","line":508,"updated":"2016-07-06 13:52:00.000000000","message":"Please assert that extend_volume is called with proper arguments.","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"63d8d471ec6b6a641fcbb8a4c5a080f8264ef34a","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        vol[\u0027num-of-dest-snaps\u0027] \u003d 0"},{"line_number":506,"context_line":"        clone \u003d self.data.test_clone.copy()"},{"line_number":507,"context_line":"        clone[\u0027size\u0027] \u003d 2"},{"line_number":508,"context_line":"        self.driver.create_cloned_volume(self.data.test_clone,"},{"line_number":509,"context_line":"                                         self.data.test_volume)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def test_clone_volume_and_resize_fail(self, req):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_4b0d918f","line":508,"in_reply_to":"1aa78d24_135d3079","updated":"2016-07-19 07:37:22.000000000","message":"Done","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d4e74ec03b7647d1b73af4fdaf43a48b5e67c1c4","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                          self.driver.create_cloned_volume,"},{"line_number":539,"context_line":"                          clone,"},{"line_number":540,"context_line":"                          self.data.test_volume)"},{"line_number":541,"context_line":"        self.assertTrue(self.delete)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# ##### Connection #####"},{"line_number":544,"context_line":"    def test_no_portals_configured(self, req):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_33cf8c2a","line":541,"updated":"2016-07-06 13:52:00.000000000","message":"It is better to mock delete_volume() and assert that it is called.","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"63d8d471ec6b6a641fcbb8a4c5a080f8264ef34a","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                          self.driver.create_cloned_volume,"},{"line_number":539,"context_line":"                          clone,"},{"line_number":540,"context_line":"                          self.data.test_volume)"},{"line_number":541,"context_line":"        self.assertTrue(self.delete)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# ##### Connection #####"},{"line_number":544,"context_line":"    def test_no_portals_configured(self, req):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_7a6e6097","line":541,"in_reply_to":"1aa78d24_33cf8c2a","updated":"2016-07-19 07:37:22.000000000","message":"Done","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"}],"cinder/volume/drivers/emc/xtremio.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"3c3147a74ed0fccc7219e581f2ccf3d4fdc90d0f","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        if volume[\u0027size\u0027] \u003e src_vref[\u0027size\u0027]:"},{"line_number":448,"context_line":"            try:"},{"line_number":449,"context_line":"                self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":450,"context_line":"            except:"},{"line_number":451,"context_line":"                # remove the volume in case resize failed"},{"line_number":452,"context_line":"                self.delete_volume(volume)"},{"line_number":453,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_8c8cb336","line":450,"range":{"start_line":450,"start_character":11,"end_line":450,"end_character":19},"updated":"2016-03-14 16:06:17.000000000","message":"Really seems like there should be a warning or error message here in the case that if fails so that it is clear where the failure occurs.","commit_id":"8112d17da8b0bf24f3976c356091334f25a1083c"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"53cabbf7f1e170215f6c85dbc762f597a3a06398","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        if volume[\u0027size\u0027] \u003e src_vref[\u0027size\u0027]:"},{"line_number":448,"context_line":"            try:"},{"line_number":449,"context_line":"                self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":450,"context_line":"            except:"},{"line_number":451,"context_line":"                # remove the volume in case resize failed"},{"line_number":452,"context_line":"                self.delete_volume(volume)"},{"line_number":453,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_6355501c","line":450,"range":{"start_line":450,"start_character":11,"end_line":450,"end_character":19},"in_reply_to":"3afc51ec_8c8cb336","updated":"2016-03-20 13:30:18.000000000","message":"Done","commit_id":"8112d17da8b0bf24f3976c356091334f25a1083c"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"19fc890971750fde2499cc0164fffaf8ee0b18fb","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                LOG.error(_LE(\u0027failes to extend volume %s, \u0027"},{"line_number":452,"context_line":"                              \u0027reverting clone operation\u0027), volume[\u0027id\u0027])"},{"line_number":453,"context_line":"                # remove the volume in case resize failed"},{"line_number":454,"context_line":"                self.delete_volume(volume)"},{"line_number":455,"context_line":"                raise"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        if volume.get(\u0027consistencygroup_id\u0027) and self.client is XtremIOClient4:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_0888e521","line":454,"updated":"2016-03-21 08:43:20.000000000","message":"In some drivers, we just raise the exception. Which one is better? Should we make it consistent?","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"74665aa95640e50c6725b4cedf8307cf1ca4cd43","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                LOG.error(_LE(\u0027failes to extend volume %s, \u0027"},{"line_number":452,"context_line":"                              \u0027reverting clone operation\u0027), volume[\u0027id\u0027])"},{"line_number":453,"context_line":"                # remove the volume in case resize failed"},{"line_number":454,"context_line":"                self.delete_volume(volume)"},{"line_number":455,"context_line":"                raise"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        if volume.get(\u0027consistencygroup_id\u0027) and self.client is XtremIOClient4:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_3c57eb03","line":454,"in_reply_to":"fa0719c6_0888e521","updated":"2016-03-21 09:58:16.000000000","message":"not sure what other drivers are doing, from my experience cleaning up is a must in this case","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"37f9dfcd6b309214730595ea83e9467f32d222a4","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                LOG.error(_LE(\u0027failes to extend volume %s, \u0027"},{"line_number":452,"context_line":"                              \u0027reverting clone operation\u0027), volume[\u0027id\u0027])"},{"line_number":453,"context_line":"                # remove the volume in case resize failed"},{"line_number":454,"context_line":"                self.delete_volume(volume)"},{"line_number":455,"context_line":"                raise"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        if volume.get(\u0027consistencygroup_id\u0027) and self.client is XtremIOClient4:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_854cac43","line":454,"in_reply_to":"fa0719c6_3c57eb03","updated":"2016-03-22 02:53:24.000000000","message":"For example, some drivers which implements the function:\n\nLVM:\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L476\n\nRBD:\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/rbd.py#L524\n\nPure:\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/pure.py#L333\n\nThe aim is not to disagree the volume deletion, just think it is better to keep consistent. So that later it is good to deal with other things like quota. Duncan proposed a problem whether needs to consider error volume into quota usage, it is better to handle if we keep such things consistent.","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"b12156e372b8b06eaab04b048deae59e2cef7308","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                LOG.error(_LE(\u0027failes to extend volume %s, \u0027"},{"line_number":452,"context_line":"                              \u0027reverting clone operation\u0027), volume[\u0027id\u0027])"},{"line_number":453,"context_line":"                # remove the volume in case resize failed"},{"line_number":454,"context_line":"                self.delete_volume(volume)"},{"line_number":455,"context_line":"                raise"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        if volume.get(\u0027consistencygroup_id\u0027) and self.client is XtremIOClient4:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_0ceda18b","line":454,"in_reply_to":"fa0719c6_854cac43","updated":"2016-07-03 14:37:15.000000000","message":"not sure what is the right path here, my instinct say to leave the array in a healthy state without \"zomby\" volumes","commit_id":"4c181a6e31a1684358ff2f9e06834e759fced340"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"3cb10a0dd6a3bb3d1445956ed707595e4c803d36","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        else:"},{"line_number":425,"context_line":"            snapshot_id \u003d snapshot[\u0027id\u0027]"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        self.client.create_snapshot(snapshot_id, volume[\u0027id\u0027])"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        # add new volume to consistency group"},{"line_number":430,"context_line":"        if (volume.get(\u0027consistencygroup_id\u0027) and"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2ac2dc33","line":427,"updated":"2016-07-04 14:51:06.000000000","message":"We need to have the same fix here.","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"6d9af2f22a49b3acbf6f60f89c06d25708487efa","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        else:"},{"line_number":425,"context_line":"            snapshot_id \u003d snapshot[\u0027id\u0027]"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        self.client.create_snapshot(snapshot_id, volume[\u0027id\u0027])"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        # add new volume to consistency group"},{"line_number":430,"context_line":"        if (volume.get(\u0027consistencygroup_id\u0027) and"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_74184385","line":427,"in_reply_to":"1aa78d24_2ac2dc33","updated":"2016-07-04 17:23:58.000000000","message":"this is another bug https://bugs.launchpad.net/cinder/+bug/1560650\nwill be fixed in a separate commit","commit_id":"9b128eaceff8951e1d38fbebb5ad6db8fd8003de"}]}