)]}'
{"cinder/tests/unit/test_vmware_vmdk.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2c3141866bf5dcd3d90870a14b03d032107adcff","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"        mock_vops.get_backing.assert_called_once_with(\u0027src_snapshot_name\u0027)"},{"line_number":1984,"context_line":"        get_clone_type.assert_called_once_with(volume)"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.vmware.vmdk.\u0027"},{"line_number":1987,"context_line":"                \u0027_get_volume_type_extra_spec\u0027)"},{"line_number":1988,"context_line":"    def test_get_extra_spec_storage_profile(self, get_volume_type_extra_spec):"},{"line_number":1989,"context_line":"        vol_type_id \u003d mock.sentinel.vol_type_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_1590c742","line":1986,"range":{"start_line":1986,"start_character":17,"end_line":1986,"end_character":50},"updated":"2016-05-30 09:49:12.000000000","message":"?: Why isn\u0027t this using VMDK_DRIVER like the other mocks?","commit_id":"d5d7f6eb5f5f18bde580f2cf8b63bee144b74d0b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"9fcc9d5d7a5062d0e60b17e50617f5fbc0cff83d","unresolved":false,"context_lines":[{"line_number":1983,"context_line":"        mock_vops.get_backing.assert_called_once_with(\u0027src_snapshot_name\u0027)"},{"line_number":1984,"context_line":"        get_clone_type.assert_called_once_with(volume)"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.vmware.vmdk.\u0027"},{"line_number":1987,"context_line":"                \u0027_get_volume_type_extra_spec\u0027)"},{"line_number":1988,"context_line":"    def test_get_extra_spec_storage_profile(self, get_volume_type_extra_spec):"},{"line_number":1989,"context_line":"        vol_type_id \u003d mock.sentinel.vol_type_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_b9cd3f87","line":1986,"range":{"start_line":1986,"start_character":17,"end_line":1986,"end_character":50},"in_reply_to":"9abb7d3a_1590c742","updated":"2016-05-31 10:50:52.000000000","message":"_get_volume_type_extra_spec is not a member of the driver class. I\u0027m planning to refactor this in a follow up patch.","commit_id":"d5d7f6eb5f5f18bde580f2cf8b63bee144b74d0b"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"7a387024f5b67fbfcd04f246b64c9e62cd7f4aa4","unresolved":false,"context_lines":[{"line_number":2039,"context_line":"        get_storage_profile.assert_called_once_with(volume)"},{"line_number":2040,"context_line":"        self.assertFalse(get_profile_id_by_name.called)"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_storage_profile\u0027)"},{"line_number":2043,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":2044,"context_line":"    @mock.patch(\u0027oslo_vmware.pbm.get_profile_id_by_name\u0027)"},{"line_number":2045,"context_line":"    def test_get_storage_profile_id_with_missing_profile("},{"line_number":2046,"context_line":"            self, get_profile_id_by_name, session, get_storage_profile):"},{"line_number":2047,"context_line":"        get_storage_profile.return_value \u003d \u0027gold\u0027"},{"line_number":2048,"context_line":"        get_profile_id_by_name.return_value \u003d None"},{"line_number":2049,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_c45da616","line":2046,"range":{"start_line":2042,"start_character":4,"end_line":2046,"end_character":71},"updated":"2016-03-18 05:57:08.000000000","message":"Can we move this common code in a private method that can be called by above four unit test cases to eliminate the redundancy.","commit_id":"d5d7f6eb5f5f18bde580f2cf8b63bee144b74d0b"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"714c9a75622c5407b9a6024b3403549b72dfed5e","unresolved":false,"context_lines":[{"line_number":2039,"context_line":"        get_storage_profile.assert_called_once_with(volume)"},{"line_number":2040,"context_line":"        self.assertFalse(get_profile_id_by_name.called)"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_storage_profile\u0027)"},{"line_number":2043,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":2044,"context_line":"    @mock.patch(\u0027oslo_vmware.pbm.get_profile_id_by_name\u0027)"},{"line_number":2045,"context_line":"    def test_get_storage_profile_id_with_missing_profile("},{"line_number":2046,"context_line":"            self, get_profile_id_by_name, session, get_storage_profile):"},{"line_number":2047,"context_line":"        get_storage_profile.return_value \u003d \u0027gold\u0027"},{"line_number":2048,"context_line":"        get_profile_id_by_name.return_value \u003d None"},{"line_number":2049,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_aa5dbc16","line":2046,"range":{"start_line":2042,"start_character":4,"end_line":2046,"end_character":71},"in_reply_to":"1af94dfe_162e9c42","updated":"2016-03-18 09:29:08.000000000","message":"Thanks for the consideration, I understand that we can only eliminate the redundant mock calls by defining a private helper that doesn\u0027t help much.","commit_id":"d5d7f6eb5f5f18bde580f2cf8b63bee144b74d0b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f3886768b45db7ee6cd12ffc5cf7e52d87276d1e","unresolved":false,"context_lines":[{"line_number":2039,"context_line":"        get_storage_profile.assert_called_once_with(volume)"},{"line_number":2040,"context_line":"        self.assertFalse(get_profile_id_by_name.called)"},{"line_number":2041,"context_line":""},{"line_number":2042,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_storage_profile\u0027)"},{"line_number":2043,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":2044,"context_line":"    @mock.patch(\u0027oslo_vmware.pbm.get_profile_id_by_name\u0027)"},{"line_number":2045,"context_line":"    def test_get_storage_profile_id_with_missing_profile("},{"line_number":2046,"context_line":"            self, get_profile_id_by_name, session, get_storage_profile):"},{"line_number":2047,"context_line":"        get_storage_profile.return_value \u003d \u0027gold\u0027"},{"line_number":2048,"context_line":"        get_profile_id_by_name.return_value \u003d None"},{"line_number":2049,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_162e9c42","line":2046,"range":{"start_line":2042,"start_character":4,"end_line":2046,"end_character":71},"in_reply_to":"1af94dfe_c45da616","updated":"2016-03-18 09:11:58.000000000","message":"Good suggestion. I thought about that. The common code is  less and it will only introduce conditions and complexity in the private helper.\n\nget_storage_profile returns \u0027gold\u0027 in only 3 methods. get_profile_id_by_name mock is only in 2 methods and returns different values. Only the volume creation code is common in all 4.","commit_id":"d5d7f6eb5f5f18bde580f2cf8b63bee144b74d0b"}]}