)]}'
{"cinder/tests/functional/test_volumes.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bbfee3c7fcede909e773a9cfd1dad04a92d5f4c8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cinder.tests.unit import fake_driver"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"VOL_TYPE_NAME \u003d \u0027functional_test_type\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class VolumesTest(functional_helpers._FunctionalTestBase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_8056e159","line":23,"updated":"2016-03-18 10:26:44.000000000","message":"nit: This should be a class attribute, not a global one","commit_id":"ee53b15305d6bc3664d597e31eb4ba8131b97ab6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bbfee3c7fcede909e773a9cfd1dad04a92d5f4c8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class VolumesTest(functional_helpers._FunctionalTestBase):"},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(VolumesTest, self).setUp()"},{"line_number":29,"context_line":"        self.api.create_type(VOL_TYPE_NAME)"},{"line_number":30,"context_line":"        fake_driver.LoggingVolumeDriver.clear_logs()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _get_flags(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_a32fa786","line":29,"updated":"2016-03-18 10:26:44.000000000","message":"-1: You should store this value and then check that created volumes have this volume type.","commit_id":"ee53b15305d6bc3664d597e31eb4ba8131b97ab6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bbfee3c7fcede909e773a9cfd1dad04a92d5f4c8","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"            self.assertEqual(1, len(actions))"},{"line_number":108,"context_line":"            action \u003d actions[0]"},{"line_number":109,"context_line":"            self.assertEqual(action[\u0027id\u0027], created_volume_id)"},{"line_number":110,"context_line":"            self.assertEqual(\u0027nova\u0027, action[\u0027availability_zone\u0027])"},{"line_number":111,"context_line":"            if action_type \u003d\u003d \u0027create_volume\u0027:"},{"line_number":112,"context_line":"                self.assertEqual(1, action[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_605d9546","line":109,"updated":"2016-03-18 10:26:44.000000000","message":"-1: Wrong order in assert equal:\n\n self.assertEqual(created_volume_id, action[\u0027id\u0027])","commit_id":"ee53b15305d6bc3664d597e31eb4ba8131b97ab6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e7725ba76d7a7b78c808e67189c3d1390e42d483","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class VolumesTest(functional_helpers._FunctionalTestBase):"},{"line_number":24,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":25,"context_line":"        super(VolumesTest, self).__init__(*args, **kwargs)"},{"line_number":26,"context_line":"        self._vol_type_name \u003d \u0027functional_test_type\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(VolumesTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_056c91cc","line":26,"updated":"2016-03-18 14:58:30.000000000","message":"This is an instance attribute and not a class attribute, but it\u0027s ok.","commit_id":"19d4c410019e0848b2195a8ef5a0ae392b76152e"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"eed33b40e1e8c913a2675e8ea08fee9980ee4a12","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class VolumesTest(functional_helpers._FunctionalTestBase):"},{"line_number":24,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":25,"context_line":"        super(VolumesTest, self).__init__(*args, **kwargs)"},{"line_number":26,"context_line":"        self._vol_type_name \u003d \u0027functional_test_type\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(VolumesTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_658e352f","line":26,"in_reply_to":"1af94dfe_056c91cc","updated":"2016-03-18 15:01:40.000000000","message":"You\u0027re right, I did not read the comment closely enough.  If I get a chance today I\u0027ll make that update and work on my reading skills :)","commit_id":"19d4c410019e0848b2195a8ef5a0ae392b76152e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"269cdecb6dbf1c57ea22d6fc4ff5b1ddfd604e60","unresolved":false,"context_lines":[{"line_number":23,"context_line":"class VolumesTest(functional_helpers._FunctionalTestBase):"},{"line_number":24,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":25,"context_line":"        super(VolumesTest, self).__init__(*args, **kwargs)"},{"line_number":26,"context_line":"        self._vol_type_name \u003d \u0027functional_test_type\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(VolumesTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_c2e524a9","line":26,"in_reply_to":"1af94dfe_658e352f","updated":"2016-03-21 10:44:56.000000000","message":"You shouldn\u0027t have, though I appreciate it.","commit_id":"19d4c410019e0848b2195a8ef5a0ae392b76152e"}]}