)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"633adab6ac2a92a08ab0984e941d493f24620336","unresolved":false,"context_lines":[{"line_number":2435,"context_line":"    return result"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":""},{"line_number":2438,"context_line":"@handle_db_data_error"},{"line_number":2439,"context_line":"@require_context"},{"line_number":2440,"context_line":"@require_snapshot_exists"},{"line_number":2441,"context_line":"@_retry_on_deadlock"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_d2430e6b","line":2438,"updated":"2016-05-24 15:45:28.000000000","message":"This should be placed after @require_context and @require_snapshot_exists.\n\n(See https://review.openstack.org/#/c/314301/ for more info.)","commit_id":"5c2f2bd13d11ceab79b0e7463dbb475705fbddd2"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"633adab6ac2a92a08ab0984e941d493f24620336","unresolved":false,"context_lines":[{"line_number":3863,"context_line":"    return _translate_transfers(results)"},{"line_number":3864,"context_line":""},{"line_number":3865,"context_line":""},{"line_number":3866,"context_line":"@handle_db_data_error"},{"line_number":3867,"context_line":"@require_context"},{"line_number":3868,"context_line":"def transfer_create(context, values):"},{"line_number":3869,"context_line":"    if not values.get(\u0027id\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_32553a1d","line":3866,"updated":"2016-05-24 15:45:28.000000000","message":"Same as above, place after @require_context.","commit_id":"5c2f2bd13d11ceab79b0e7463dbb475705fbddd2"}],"cinder/tests/unit/db/test_transfers.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2b090a103af9b474a6ef2d7e44d8ab0bb7a24929","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                          db.transfer_create, self.ctxt,"},{"line_number":67,"context_line":"                          transfer)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        transfer_create_mock.assert_called_once_with(self.ctxt, transfer)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_transfer_create_not_available(self):"},{"line_number":72,"context_line":"        volume_id \u003d utils.create_volume(self.ctxt, size\u003d1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_9ff3110a","line":69,"updated":"2016-05-25 15:12:15.000000000","message":"Same comments as other test, suggest just dropping this.","commit_id":"b11f376d0dae85a39928d258a8770acd062e2372"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7bdd5f5f3e83c0ebcc256eb8befbc139038bc0ee","unresolved":false,"context_lines":[{"line_number":974,"context_line":""},{"line_number":975,"context_line":"        self.assertEqual(should_be, db_meta)"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    def test_volume_metadata_update_for_unicode_value(self):"},{"line_number":978,"context_line":"        if six.PY3:"},{"line_number":979,"context_line":"            self.skip(\"SQLite database supports unicode value for python3\")"},{"line_number":980,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_825bb686","line":977,"updated":"2016-05-09 22:08:17.000000000","message":"These aren\u0027t really valid/useful tests, since they make assumptions about what the SQLite backend will return by actually sending it updates.\n\nThe updates and return from SQLite should be mocked out.","commit_id":"e9f6a351de17d1813225ef97cdff9e9649acc653"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2b090a103af9b474a6ef2d7e44d8ab0bb7a24929","unresolved":false,"context_lines":[{"line_number":990,"context_line":"                          meta_type\u003dcommon.METADATA_TYPES.user)"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        volume_metadata_update_mock.assert_called_once_with("},{"line_number":993,"context_line":"            self.ctxt, 1, metadata2, False, common.METADATA_TYPES.user)"},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"    @mock.patch.object(db.sqlalchemy.api,"},{"line_number":996,"context_line":"                       \u0027volume_metadata_update\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_7fa8eddb","line":993,"updated":"2016-05-25 15:12:15.000000000","message":"I\u0027m not sure this test actually tests anything interesting.\n\nAll it really does is ensure that db.volume_create calls db.sqlalchemy.api.volume_create which is not related to what this patch does.\n\nIMO it\u0027s better to just drop these tests.","commit_id":"b11f376d0dae85a39928d258a8770acd062e2372"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2b090a103af9b474a6ef2d7e44d8ab0bb7a24929","unresolved":false,"context_lines":[{"line_number":995,"context_line":"    @mock.patch.object(db.sqlalchemy.api,"},{"line_number":996,"context_line":"                       \u0027volume_metadata_update\u0027,"},{"line_number":997,"context_line":"                       side_effect\u003dexception.Invalid)"},{"line_number":998,"context_line":"    def test_volume_glance_metadata_update_with_4byte_unicode_character("},{"line_number":999,"context_line":"            self, volume_metadata_update_mock):"},{"line_number":1000,"context_line":"        metadata1 \u003d {\u0027a\u0027: \u00271\u0027, \u0027c\u0027: \u00272\u0027}"},{"line_number":1001,"context_line":"        # Provide a 4byte unicode character as metadata value"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_df41193b","line":998,"updated":"2016-05-25 15:12:15.000000000","message":"This is the same as the above test.","commit_id":"b11f376d0dae85a39928d258a8770acd062e2372"}]}