)]}'
{"cinder/volume/drivers/datera.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"50eab73b72ec68e56180f74633f6cb36dfef691b","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            method\u003d\u0027post\u0027,"},{"line_number":356,"context_line":"            body\u003dapp_params)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if ((\u0027size\u0027 in volume) and (volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027])):"},{"line_number":359,"context_line":"            self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_0cbcb9b9","line":358,"updated":"2016-04-20 17:00:42.000000000","message":"I think this logic is backwards. If the snapshot size is greater, then do the extend. Also not need to check if size is in volume.","commit_id":"2d1d3d4f3fa3c51d80e5158e133f4cabf8e35b39"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1fef2623f9b23f0313c99686fe7221974c820b52","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            method\u003d\u0027post\u0027,"},{"line_number":356,"context_line":"            body\u003dapp_params)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if ((\u0027size\u0027 in volume) and (volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027])):"},{"line_number":359,"context_line":"            self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_9c525bdc","line":358,"in_reply_to":"1a122d0e_0cbcb9b9","updated":"2016-05-18 10:55:05.000000000","message":"-1: Size will always be present since both volume and snapshot are OVOs.  This should be changed to attribute notation:\n\n if volume.size \u003e snapshot.volume_size:","commit_id":"2d1d3d4f3fa3c51d80e5158e133f4cabf8e35b39"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"50eab73b72ec68e56180f74633f6cb36dfef691b","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            body\u003dapp_params)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if ((\u0027size\u0027 in volume) and (volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027])):"},{"line_number":359,"context_line":"            self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":362,"context_line":"        \"\"\"Get volume stats."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_ecc33d36","line":359,"updated":"2016-04-20 17:00:42.000000000","message":"Instead here, extend by the snapshot size.","commit_id":"2d1d3d4f3fa3c51d80e5158e133f4cabf8e35b39"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1fef2623f9b23f0313c99686fe7221974c820b52","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            body\u003dapp_params)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if ((\u0027size\u0027 in volume) and (volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027])):"},{"line_number":359,"context_line":"            self.extend_volume(volume, volume[\u0027size\u0027])"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":362,"context_line":"        \"\"\"Get volume stats."}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_9c009bac","line":359,"range":{"start_line":359,"start_character":39,"end_line":359,"end_character":53},"updated":"2016-05-18 10:55:05.000000000","message":"volume.size","commit_id":"2d1d3d4f3fa3c51d80e5158e133f4cabf8e35b39"}],"cinder/volume/drivers/datera/datera_api2.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f1750e2fecf097b1fef4693dcbdf307ea5a59e85","unresolved":false,"context_lines":[{"line_number":480,"context_line":"            body\u003dapp_params,"},{"line_number":481,"context_line":"            api_version\u003d\u00272\u0027)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        if (volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]):"},{"line_number":484,"context_line":"            self._extend_volume_2(volume, volume[\u0027size\u0027])"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_e572b0ac","line":483,"range":{"start_line":483,"start_character":11,"end_line":483,"end_character":12},"updated":"2017-03-16 14:55:43.000000000","message":"Nit: outer () not needed.","commit_id":"70ade98160035b35a627d3cc42615c1b91ddd858"}]}