)]}'
{"cinder/image/glance.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c105382409a41257b5faebe82bde9992ed9338c6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            if param in params:"},{"line_number":253,"context_line":"                _params[param] \u003d params.get(param)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if CONF.glance_api_version !\u003d 2:"},{"line_number":256,"context_line":"            # ensure filters is a dict"},{"line_number":257,"context_line":"            _params.setdefault(\u0027filters\u0027, {})"},{"line_number":258,"context_line":"            # NOTE(vish): don\u0027t filter out private images"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_ef272562","line":255,"updated":"2016-04-05 18:36:12.000000000","message":"I believe this should be \u003c\u003d 2 rather than !\u003d 2.  We should assume v3 won\u0027t revert to the v1 behavior.","commit_id":"6f46d0d2a4397bf81d74e066366add7bb6b84255"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"bd298c07410e96874652683bc95c911200176fd8","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            if param in params:"},{"line_number":253,"context_line":"                _params[param] \u003d params.get(param)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if CONF.glance_api_version !\u003d 2:"},{"line_number":256,"context_line":"            # ensure filters is a dict"},{"line_number":257,"context_line":"            _params.setdefault(\u0027filters\u0027, {})"},{"line_number":258,"context_line":"            # NOTE(vish): don\u0027t filter out private images"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_38810590","line":255,"in_reply_to":"9a061dce_0e225252","updated":"2016-04-07 09:53:18.000000000","message":"Done","commit_id":"6f46d0d2a4397bf81d74e066366add7bb6b84255"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"8993037223509072ef408cdf3f27b920b9b6d84b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            if param in params:"},{"line_number":253,"context_line":"                _params[param] \u003d params.get(param)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        if CONF.glance_api_version !\u003d 2:"},{"line_number":256,"context_line":"            # ensure filters is a dict"},{"line_number":257,"context_line":"            _params.setdefault(\u0027filters\u0027, {})"},{"line_number":258,"context_line":"            # NOTE(vish): don\u0027t filter out private images"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_0e225252","line":255,"in_reply_to":"9a061dce_ef272562","updated":"2016-04-05 22:35:55.000000000","message":"I agreed but some other place of cinder needs to be changed in that case.","commit_id":"6f46d0d2a4397bf81d74e066366add7bb6b84255"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"2316707be01656a4563ce1e7e865ec96619425f4","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            _params.setdefault(\u0027filters\u0027, {})"},{"line_number":258,"context_line":"            # NOTE(vish): don\u0027t filter out private images"},{"line_number":259,"context_line":"            _params[\u0027filters\u0027].setdefault(\u0027is_public\u0027, \u0027none\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return _params"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def show(self, context, image_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_e4fcad40","line":260,"updated":"2016-04-11 12:38:05.000000000","message":"Should default for glance_api_version \u003d\u003d 2 be set for visibility?","commit_id":"ac4d8418b490f32a7acf3ef228012722dafa86d6"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e33819c8a52fbf816bc229f22217ced0a084773c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            _params.setdefault(\u0027filters\u0027, {})"},{"line_number":258,"context_line":"            # NOTE(vish): don\u0027t filter out private images"},{"line_number":259,"context_line":"            _params[\u0027filters\u0027].setdefault(\u0027is_public\u0027, \u0027none\u0027)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return _params"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def show(self, context, image_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_9a72747b","line":260,"in_reply_to":"7a1b2928_e4fcad40","updated":"2016-04-11 13:02:55.000000000","message":"No.\n\nis_public\u003dNone means all images that the user can uses.\n\nvisibility unset means all images that the user can uses.","commit_id":"ac4d8418b490f32a7acf3ef228012722dafa86d6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"52693aef714e0c9b340de968460694510039ec73","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            # ensure filters is a dict"},{"line_number":259,"context_line":"            _params.setdefault(\u0027filters\u0027, {})"},{"line_number":260,"context_line":"            # NOTE(vish): don\u0027t filter out private images"},{"line_number":261,"context_line":"            _params[\u0027filters\u0027].setdefault(\u0027is_public\u0027, \u0027none\u0027)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        return _params"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_8433a213","line":261,"updated":"2016-05-10 12:16:20.000000000","message":"nit: Comment why v2 doesn\u0027t need the \"visible\" filter","commit_id":"27a67260abe2b8169639c02cc943f4d69188f0c2"}]}