)]}'
{"cinder/volume/rpcapi.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"4c2a48bf36745ebddefb09a7569ec853ceeb1627","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        msg_args \u003d {\u0027volume_id\u0027: volume.id, \u0027new_volume_id\u0027: new_volume.id,"},{"line_number":281,"context_line":"                    \u0027error\u0027: error, \u0027volume\u0027: volume}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if version \u003d\u003d \u00271.10\u0027:"},{"line_number":284,"context_line":"            del msg_args[\u0027volume\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        cctxt \u003d self._get_cctxt(volume.host, version)"},{"line_number":287,"context_line":"        return cctxt.call(ctxt, \u0027migrate_volume_completion\u0027, **msg_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_1c2b0332","line":284,"range":{"start_line":283,"start_character":8,"end_line":284,"end_character":34},"updated":"2016-03-25 03:56:38.000000000","message":"Is the original logic changed here?\nWhere is the \"new_volume\" argument?","commit_id":"dc12d50b140032faf83ec566a705754dfd23de99"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"a0845e60a38d697f3e21466c6217f0e1ee6abf14","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        msg_args \u003d {\u0027volume_id\u0027: volume.id, \u0027new_volume_id\u0027: new_volume.id,"},{"line_number":281,"context_line":"                    \u0027error\u0027: error, \u0027volume\u0027: volume}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        if version \u003d\u003d \u00271.10\u0027:"},{"line_number":284,"context_line":"            del msg_args[\u0027volume\u0027]"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        cctxt \u003d self._get_cctxt(volume.host, version)"},{"line_number":287,"context_line":"        return cctxt.call(ctxt, \u0027migrate_volume_completion\u0027, **msg_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_69bfc3fb","line":284,"range":{"start_line":283,"start_character":8,"end_line":284,"end_character":34},"in_reply_to":"da0c15f0_1c2b0332","updated":"2016-03-25 16:31:47.000000000","message":"I somehow missed new_volume.\nIt should be:\n\nmsg_args \u003d {\u0027volume_id\u0027: volume.id, \u0027new_volume_id\u0027: new_volume.id,\n            \u0027error\u0027: error, \u0027volume\u0027: volume, \u0027new_volume\u0027: new_volume}\n\nif version \u003d\u003d \u00271.10\u0027:\n    del msg_args[\u0027volume\u0027]\n    del msg_args[\u0027new_volume\u0027]","commit_id":"dc12d50b140032faf83ec566a705754dfd23de99"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"4c2a48bf36745ebddefb09a7569ec853ceeb1627","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        if version \u003d\u003d \u00271.12\u0027:"},{"line_number":301,"context_line":"            del msg_args[\u0027volume\u0027]"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if version in (\u00271.34\u0027, \u00271.12\u0027) and old_reservations is not None:"},{"line_number":304,"context_line":"            del msg_args[\u0027old_reservations\u0027]"},{"line_number":305,"context_line":"            QUOTAS.rollback(ctxt, old_reservations)"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_1c878310","line":303,"range":{"start_line":303,"start_character":32,"end_line":303,"end_character":36},"updated":"2016-03-25 03:56:38.000000000","message":"Originally, the 1.12 version doesn\u0027t receive a \"volume\" argument.","commit_id":"dc12d50b140032faf83ec566a705754dfd23de99"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"a0845e60a38d697f3e21466c6217f0e1ee6abf14","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        if version \u003d\u003d \u00271.12\u0027:"},{"line_number":301,"context_line":"            del msg_args[\u0027volume\u0027]"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if version in (\u00271.34\u0027, \u00271.12\u0027) and old_reservations is not None:"},{"line_number":304,"context_line":"            del msg_args[\u0027old_reservations\u0027]"},{"line_number":305,"context_line":"            QUOTAS.rollback(ctxt, old_reservations)"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_89d85755","line":303,"range":{"start_line":303,"start_character":32,"end_line":303,"end_character":36},"in_reply_to":"da0c15f0_1c878310","updated":"2016-03-25 16:31:47.000000000","message":"That\u0027s why it\u0027s removed in line 300 ;)","commit_id":"dc12d50b140032faf83ec566a705754dfd23de99"}]}