)]}'
{"cinder/tests/unit/fake_constants.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"afea60885513c59a7ba8cf5a522e0186488e7e6e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"PROJECT3_ID \u003d \u0027f6c912d7-bf30-4b12-af81-a9e0b2f85f85\u0027"},{"line_number":53,"context_line":"provider_id \u003d \u002760087173-e899-470a-9e3a-ba4cffa3e3e3\u0027"},{"line_number":54,"context_line":"PROVIDER_ID \u003d \u002760087173-e899-470a-9e3a-ba4cffa3e3e3\u0027"},{"line_number":55,"context_line":"provider2_id \u003d \u00271060eccd-64bb-4ed2-86ce-aeaf135a97b8\u0027"},{"line_number":56,"context_line":"PROVIDER2_ID \u003d \u00271060eccd-64bb-4ed2-86ce-aeaf135a97b8\u0027"},{"line_number":57,"context_line":"provider3_id \u003d \u002763736819-1c95-440e-a873-b9d685afede5\u0027"},{"line_number":58,"context_line":"PROVIDER3_ID \u003d \u002763736819-1c95-440e-a873-b9d685afede5\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_b4823ec6","line":55,"updated":"2016-04-20 12:36:22.000000000","message":"?: I also asked this in Eric\u0027s patch, but why do we add a lower and upper case version of the same thing?  I think we should just have the upper case version.","commit_id":"5e7dca62e294b186fce54d12825051cb4f20bcff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4833bc26a8bc834bac4985830b57460e9e5f8ca2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"PROJECT3_ID \u003d \u0027f6c912d7-bf30-4b12-af81-a9e0b2f85f85\u0027"},{"line_number":53,"context_line":"provider_id \u003d \u002760087173-e899-470a-9e3a-ba4cffa3e3e3\u0027"},{"line_number":54,"context_line":"PROVIDER_ID \u003d \u002760087173-e899-470a-9e3a-ba4cffa3e3e3\u0027"},{"line_number":55,"context_line":"provider2_id \u003d \u00271060eccd-64bb-4ed2-86ce-aeaf135a97b8\u0027"},{"line_number":56,"context_line":"PROVIDER2_ID \u003d \u00271060eccd-64bb-4ed2-86ce-aeaf135a97b8\u0027"},{"line_number":57,"context_line":"provider3_id \u003d \u002763736819-1c95-440e-a873-b9d685afede5\u0027"},{"line_number":58,"context_line":"PROVIDER3_ID \u003d \u002763736819-1c95-440e-a873-b9d685afede5\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_7071a00b","line":55,"in_reply_to":"1a122d0e_2c5a3ef2","updated":"2016-04-21 08:34:35.000000000","message":"Thanks for the explanation.  I understand leaving the ones that are already there, but I don\u0027t think consistency in a file such as this is worth adding more work for later.\n\nAnyway, not a big deal if they\u0027ll get removed in a later patch.","commit_id":"5e7dca62e294b186fce54d12825051cb4f20bcff"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e83ea9491391432deac1f82dea7bf1e2671ff0dc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"PROJECT3_ID \u003d \u0027f6c912d7-bf30-4b12-af81-a9e0b2f85f85\u0027"},{"line_number":53,"context_line":"provider_id \u003d \u002760087173-e899-470a-9e3a-ba4cffa3e3e3\u0027"},{"line_number":54,"context_line":"PROVIDER_ID \u003d \u002760087173-e899-470a-9e3a-ba4cffa3e3e3\u0027"},{"line_number":55,"context_line":"provider2_id \u003d \u00271060eccd-64bb-4ed2-86ce-aeaf135a97b8\u0027"},{"line_number":56,"context_line":"PROVIDER2_ID \u003d \u00271060eccd-64bb-4ed2-86ce-aeaf135a97b8\u0027"},{"line_number":57,"context_line":"provider3_id \u003d \u002763736819-1c95-440e-a873-b9d685afede5\u0027"},{"line_number":58,"context_line":"PROVIDER3_ID \u003d \u002763736819-1c95-440e-a873-b9d685afede5\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_2c5a3ef2","line":55,"in_reply_to":"1a122d0e_b4823ec6","updated":"2016-04-21 03:21:08.000000000","message":"The lower case versions are just a temporary accomodation for some earlier commits with lower case fake constants.  Some are in this file even if not really needed just to keep the file uniform and mechanically consistent.  Our plan is to do a cleanup commit that converts all uses of the lower case veersions of these to their upper-case counterparts and remove all lower-case versions of these constants from this file.  We\u0027ll do this after getting all the cleanup patches merged and then follow with that cleanup patch.","commit_id":"5e7dca62e294b186fce54d12825051cb4f20bcff"}]}
