)]}'
{"cinder/tests/unit/test_solidfire.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"c72e1a849af4c9892693699466155475a7fea5e2","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"        try:"},{"line_number":1753,"context_line":"            sfv.foo()"},{"line_number":1754,"context_line":"            self.fail(\"Should have thrown Error\")"},{"line_number":1755,"context_line":"        except Exception:"},{"line_number":1756,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_7b4004a6","line":1755,"updated":"2016-03-28 02:48:37.000000000","message":"Better to catch NotImplementedError instead of Exception?","commit_id":"128e6ef5d73247369d65684f6720b58642717b25"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"2926ce9d0f2038cf60155eab0585da9291e286af","unresolved":false,"context_lines":[{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"    def test_getattr_failure(self):"},{"line_number":1751,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1752,"context_line":"        try:"},{"line_number":1753,"context_line":"            sfv.foo()"},{"line_number":1754,"context_line":"            self.fail(\"Should have thrown Error\")"},{"line_number":1755,"context_line":"        except Exception:"},{"line_number":1756,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0554d5c7","line":1756,"range":{"start_line":1752,"start_character":8,"end_line":1756,"end_character":16},"updated":"2016-03-30 17:53:02.000000000","message":"self.assertRaises(...) might simplify this a tad, personal taste i suppose","commit_id":"128e6ef5d73247369d65684f6720b58642717b25"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9153a938ee3c075e6d34a59132151ee2f2c57c8c","unresolved":false,"context_lines":[{"line_number":1749,"context_line":""},{"line_number":1750,"context_line":"    def test_getattr_failure(self):"},{"line_number":1751,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1752,"context_line":"        try:"},{"line_number":1753,"context_line":"            sfv.foo()"},{"line_number":1754,"context_line":"            self.fail(\"Should have thrown Error\")"},{"line_number":1755,"context_line":"        except Exception:"},{"line_number":1756,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_4b9ecc63","line":1756,"range":{"start_line":1752,"start_character":8,"end_line":1756,"end_character":16},"in_reply_to":"ba0121b8_0554d5c7","updated":"2016-03-31 04:25:55.000000000","message":"Yes, I agree 100%, however I\u0027ve got something weird happening that I haven\u0027t tracked down with the exception object and the usual assertRaises xxxx wasn\u0027t working.  I haven\u0027t gotten back to it, and figured that it was better to get the fix in than me spin my wheels on it for too much longer.\n\nDefinitely something I intend to address and get to the bottom of.","commit_id":"128e6ef5d73247369d65684f6720b58642717b25"}]}