)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"aa56e47ca764a44a732d0625af93e50248d84579","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        snapshot_object \u003d self.create_snapshot_in_db(context, volume, name,"},{"line_number":1597,"context_line":"                                                     description, False,"},{"line_number":1598,"context_line":"                                                     metadata, None,"},{"line_number":1599,"context_line":"                                                     commit_quota\u003dFalse)"},{"line_number":1600,"context_line":"        self.volume_rpcapi.manage_existing_snapshot(context, snapshot_object,"},{"line_number":1601,"context_line":"                                                    ref, host)"},{"line_number":1602,"context_line":"        return snapshot_object"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_23e63144","line":1599,"updated":"2016-03-30 18:35:44.000000000","message":"Seems like we would want to remove/change https://github.com/openstack/cinder/blob/master/cinder/volume/api.py#L1592-L1594 and just do the quota commit here. If we aren\u0027t able to allocate the quota it should fail in the API layer here before we do the RPC call to c-vol.","commit_id":"54f29972dc949d592ccc9f257ccfbf1902340265"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"8e73340e3e320b4fef9cd08b768a2c7b9b3aa15f","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"        snapshot_object \u003d self.create_snapshot_in_db(context, volume, name,"},{"line_number":1597,"context_line":"                                                     description, False,"},{"line_number":1598,"context_line":"                                                     metadata, None,"},{"line_number":1599,"context_line":"                                                     commit_quota\u003dFalse)"},{"line_number":1600,"context_line":"        self.volume_rpcapi.manage_existing_snapshot(context, snapshot_object,"},{"line_number":1601,"context_line":"                                                    ref, host)"},{"line_number":1602,"context_line":"        return snapshot_object"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_c98b461d","line":1599,"in_reply_to":"ba0121b8_23e63144","updated":"2016-04-05 16:32:40.000000000","message":"I agree on Patrick.\nComment from John at bug#1508249, \"We should be able to always check the reservations in volume.api and then roll-back adjust in the case of failure in the volume.manager if need be.\"\n\nCurrent fix moves quota check from API to volume.manager, this doesn\u0027t fit above policy.","commit_id":"54f29972dc949d592ccc9f257ccfbf1902340265"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"0957f65cc22b40079606d54ab023ae47282fcda0","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                                          \u0027vol_status\u0027: volume[\u0027status\u0027]}"},{"line_number":740,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        if commit_quota:"},{"line_number":743,"context_line":"            try:"},{"line_number":744,"context_line":"                if CONF.no_snapshot_gb_quota:"},{"line_number":745,"context_line":"                    reserve_opts \u003d {\u0027snapshots\u0027: 1}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_795b232f","line":742,"updated":"2016-04-08 16:22:26.000000000","message":"Not a huge deal, but I think a better name for this would be \"reserve_quota\". IMO commit_quota makes it seem like we\u0027re still reserving the quota in c-api, we\u0027re just committing it c-vol","commit_id":"f74bc2947154b2f06ae3e1f3c696497f25989d70"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"55464d5e4b35c32ffd778fc1db24b065ddc08d3c","unresolved":false,"context_lines":[{"line_number":810,"context_line":"                    if snapshot.obj_attr_is_set(\u0027id\u0027):"},{"line_number":811,"context_line":"                        snapshot.destroy()"},{"line_number":812,"context_line":"                finally:"},{"line_number":813,"context_line":"                    QUOTAS.rollback(context, reservations)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        return snapshot"},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_b1c72344","line":813,"range":{"start_line":813,"start_character":20,"end_line":813,"end_character":35},"updated":"2016-05-05 03:54:09.000000000","message":"\"if commit_quota:\" here as well.","commit_id":"2c313350aac74adf9b0061c3760d03715162617a"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"eaebbbca4df15a6fe5b29ad4aa5e7e43dd3d649f","unresolved":false,"context_lines":[{"line_number":810,"context_line":"                    if snapshot.obj_attr_is_set(\u0027id\u0027):"},{"line_number":811,"context_line":"                        snapshot.destroy()"},{"line_number":812,"context_line":"                finally:"},{"line_number":813,"context_line":"                    QUOTAS.rollback(context, reservations)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        return snapshot"},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_b109e333","line":813,"range":{"start_line":813,"start_character":20,"end_line":813,"end_character":35},"in_reply_to":"1a122d0e_b1c72344","updated":"2016-05-05 04:08:22.000000000","message":"Nice suggestion。","commit_id":"2c313350aac74adf9b0061c3760d03715162617a"}]}