)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"0d2e7a2e91c5b0ae50318b2d29a6949d27afdc18","unresolved":false,"context_lines":[{"line_number":3297,"context_line":"                self.driver.failover_host("},{"line_number":3298,"context_line":"                    context,"},{"line_number":3299,"context_line":"                    volumes,"},{"line_number":3300,"context_line":"                    secondary_id\u003dsecondary_backend_id))"},{"line_number":3301,"context_line":"        except exception.UnableToFailOver:"},{"line_number":3302,"context_line":"            LOG.exception(_LE(\"Failed to perform replication failover\"))"},{"line_number":3303,"context_line":"            service.replication_status \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_24258608","line":3300,"range":{"start_line":3300,"start_character":20,"end_line":3300,"end_character":53},"updated":"2016-03-31 06:20:41.000000000","message":"I am not very sure, but will this break some other drivers?\nThese drivers need a positional argument in name \"secondary_backend_id\" not \"secondary_id\".\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_3par_iscsi.py#L932\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/emc/emc_cli_fc.py#L305","commit_id":"5019133c55d53815ca71a48db723fecf18a67fb5"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"cd19e59c8a46b29946a4dcd2f0b6f8cb7733c058","unresolved":false,"context_lines":[{"line_number":3297,"context_line":"                self.driver.failover_host("},{"line_number":3298,"context_line":"                    context,"},{"line_number":3299,"context_line":"                    volumes,"},{"line_number":3300,"context_line":"                    secondary_id\u003dsecondary_backend_id))"},{"line_number":3301,"context_line":"        except exception.UnableToFailOver:"},{"line_number":3302,"context_line":"            LOG.exception(_LE(\"Failed to perform replication failover\"))"},{"line_number":3303,"context_line":"            service.replication_status \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_e4bc1abd","line":3300,"range":{"start_line":3300,"start_character":20,"end_line":3300,"end_character":53},"in_reply_to":"ba0121b8_24258608","updated":"2016-04-07 04:25:51.000000000","message":"Hmm... yeah, good catch!!!","commit_id":"5019133c55d53815ca71a48db723fecf18a67fb5"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"20afca541026148a7489dc920bff0e7af719cce9","unresolved":false,"context_lines":[{"line_number":3297,"context_line":"                self.driver.failover_host("},{"line_number":3298,"context_line":"                    context,"},{"line_number":3299,"context_line":"                    volumes,"},{"line_number":3300,"context_line":"                    secondary_id\u003dsecondary_backend_id))"},{"line_number":3301,"context_line":"        except exception.UnableToFailOver:"},{"line_number":3302,"context_line":"            LOG.exception(_LE(\"Failed to perform replication failover\"))"},{"line_number":3303,"context_line":"            service.replication_status \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_564c2e76","line":3300,"updated":"2016-04-08 16:07:56.000000000","message":"Not worth holding up the patch for, but for consistency/clarity it\u0027s probably worth changing the few other places we use secondary_backend_id to be just secondary_id.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/rpcapi.py#L381-387\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L3269\n\nI can get this in a simple follow up if you want.","commit_id":"e01af62ecd5c21de1d3da71c953d2d71f32ce2d3"}]}