)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":16100,"name":"Chris Morrell","username":"chrismorrell","inactive":true},"change_message_id":"afdf1097070e0c927dd20f603bf1af2db78e602b","unresolved":false,"context_lines":[{"line_number":1198,"context_line":"            # command over and over coupled with the fact that the introduction"},{"line_number":1199,"context_line":"            # of objects now sets host to None on failures we\u0027ll end up with an"},{"line_number":1200,"context_line":"            # orphaned volume on the backend for every one of these segments"},{"line_number":1201,"context_line":"            # that fail, for n-retries.  Sad Sad Panda!!  We\u0027ll just do it"},{"line_number":1202,"context_line":"            # ourselves until we can get a general fix in Cinder further up the"},{"line_number":1203,"context_line":"            # line"},{"line_number":1204,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_3a5af44f","line":1201,"range":{"start_line":1201,"start_character":41,"end_line":1201,"end_character":56},"updated":"2016-04-05 21:02:26.000000000","message":"Wow, that\u0027d be super frustrating to experience. Sad panda indeed.","commit_id":"8f16183e6e98d68358cba85aa8c75b860426b630"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cabfaeac56d0e973ba8cb763daac9f4059d6188d","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"            # that fail, for n-retries.  Sad Sad Panda!!  We\u0027ll just do it"},{"line_number":1202,"context_line":"            # ourselves until we can get a general fix in Cinder further up the"},{"line_number":1203,"context_line":"            # line"},{"line_number":1204,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1205,"context_line":"                sf_volid \u003d int(model_update[\u0027provider_id\u0027].split()[0])"},{"line_number":1206,"context_line":"                self._issue_api_request(\u0027DeleteVolume\u0027, {\u0027volumeID\u0027: sf_volid})"},{"line_number":1207,"context_line":"        return model_update"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_7e4fbb33","line":1204,"updated":"2016-04-01 13:49:20.000000000","message":"I don\u0027t think you\u0027ve imported excutils, which leads me to think this change set depends on others ...","commit_id":"8f16183e6e98d68358cba85aa8c75b860426b630"},{"author":{"_account_id":16100,"name":"Chris Morrell","username":"chrismorrell","inactive":true},"change_message_id":"afdf1097070e0c927dd20f603bf1af2db78e602b","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"            # that fail, for n-retries.  Sad Sad Panda!!  We\u0027ll just do it"},{"line_number":1202,"context_line":"            # ourselves until we can get a general fix in Cinder further up the"},{"line_number":1203,"context_line":"            # line"},{"line_number":1204,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1205,"context_line":"                sf_volid \u003d int(model_update[\u0027provider_id\u0027].split()[0])"},{"line_number":1206,"context_line":"                self._issue_api_request(\u0027DeleteVolume\u0027, {\u0027volumeID\u0027: sf_volid})"},{"line_number":1207,"context_line":"        return model_update"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_5ac088e0","line":1204,"in_reply_to":"ba0121b8_7e4fbb33","updated":"2016-04-05 21:02:26.000000000","message":"Confirmed, executils is handled in -\u003e https://review.openstack.org/#/c/299746/2/cinder/volume/drivers/solidfire.py\n\nwhich is all part of the cheesecake series of patches. A dependency linking them would be useful.","commit_id":"8f16183e6e98d68358cba85aa8c75b860426b630"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cabfaeac56d0e973ba8cb763daac9f4059d6188d","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        return model_update"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"    def _retrieve_replication_settings(self, volume):"},{"line_number":1210,"context_line":"        raise exception.SolidFireAPIException()"},{"line_number":1211,"context_line":"        rep_data \u003d {}"},{"line_number":1212,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":1213,"context_line":"        type_id \u003d volume.get(\u0027volume_type_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_9ee60f42","line":1210,"updated":"2016-04-01 13:49:20.000000000","message":"?  Left over from testing?","commit_id":"8f16183e6e98d68358cba85aa8c75b860426b630"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b965d7a73a338fca1251a2154d5d40daca8ffa9","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"                    int(model_update[\u0027provider_id\u0027].split()[0]))"},{"line_number":1193,"context_line":"                self._replicate_volume(volume, params,"},{"line_number":1194,"context_line":"                                       sf_account, rep_settings)"},{"line_number":1195,"context_line":"        except Exception:"},{"line_number":1196,"context_line":"            # NOTE(jdg): Something went wrong after the source create, due to"},{"line_number":1197,"context_line":"            # the way TFLOW works and it\u0027s insistence on retrying the same"},{"line_number":1198,"context_line":"            # command over and over coupled with the fact that the introduction"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_f50f9834","line":1195,"updated":"2016-04-07 09:47:26.000000000","message":"I think you need to add a unit test that covers this exception path.","commit_id":"3b05402c6c58847e33e0afa6b098494f37961c03"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b965d7a73a338fca1251a2154d5d40daca8ffa9","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        return model_update"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"    def _retrieve_replication_settings(self, volume):"},{"line_number":1210,"context_line":"        raise exception.SolidFireAPIException()"},{"line_number":1211,"context_line":"        rep_data \u003d {}"},{"line_number":1212,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":1213,"context_line":"        type_id \u003d volume.get(\u0027volume_type_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_f2fb2e77","line":1210,"updated":"2016-04-07 09:47:26.000000000","message":"I don\u0027t think this line is intended.  Probably you had it in temporarily to see what would happen in the exception path at 1195?","commit_id":"3b05402c6c58847e33e0afa6b098494f37961c03"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0068db3f7e0b9458cea929722a428c6a41826e5f","unresolved":false,"context_lines":[{"line_number":1207,"context_line":"        return model_update"},{"line_number":1208,"context_line":""},{"line_number":1209,"context_line":"    def _retrieve_replication_settings(self, volume):"},{"line_number":1210,"context_line":"        raise exception.SolidFireAPIException()"},{"line_number":1211,"context_line":"        rep_data \u003d {}"},{"line_number":1212,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":1213,"context_line":"        type_id \u003d volume.get(\u0027volume_type_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_0afe276b","line":1210,"in_reply_to":"9a061dce_f2fb2e77","updated":"2016-04-12 02:37:22.000000000","message":"This line looks wrong.  It caused the unit test error too.","commit_id":"3b05402c6c58847e33e0afa6b098494f37961c03"}]}