)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"467c19ec62234600c6008fbb56dba4a4542bbd3b","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                return array"},{"line_number":317,"context_line":"            array.append(tail)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    # TODO(tswanson): Test against DC. If we don\u0027t need then remove."},{"line_number":320,"context_line":"    # @staticmethod"},{"line_number":321,"context_line":"    # def _lower_first(s):"},{"line_number":322,"context_line":"    #     return s[:1].lower() + s[1:] if s else \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_1ef5cdca","line":319,"range":{"start_line":319,"start_character":49,"end_line":319,"end_character":50},"updated":"2016-04-01 20:02:28.000000000","message":"Has this been tested? If so, can this be removed? If not, can this TODO be completed?","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d4fe05119641930813a1ce74703f4f5b250ba10d","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                return array"},{"line_number":317,"context_line":"            array.append(tail)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    # TODO(tswanson): Test against DC. If we don\u0027t need then remove."},{"line_number":320,"context_line":"    # @staticmethod"},{"line_number":321,"context_line":"    # def _lower_first(s):"},{"line_number":322,"context_line":"    #     return s[:1].lower() + s[1:] if s else \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_8c0257b3","line":319,"range":{"start_line":319,"start_character":49,"end_line":319,"end_character":50},"in_reply_to":"ba0121b8_1ef5cdca","updated":"2016-04-01 20:17:11.000000000","message":"It has.  Removed.","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"467c19ec62234600c6008fbb56dba4a4542bbd3b","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        :returns: JSON or None on error."},{"line_number":388,"context_line":"        \"\"\""},{"line_number":389,"context_line":"        try:"},{"line_number":390,"context_line":"            # TODO(tswanson): pick this or return self._lower_key(blob.json())"},{"line_number":391,"context_line":"            return blob.json()"},{"line_number":392,"context_line":"        except AttributeError:"},{"line_number":393,"context_line":"            LOG.error(_LE(\u0027Error invalid json: %s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_5eed85ee","line":390,"updated":"2016-04-01 20:02:28.000000000","message":"Same comment as above. Has it been determined what needs to be done here?","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d4fe05119641930813a1ce74703f4f5b250ba10d","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        :returns: JSON or None on error."},{"line_number":388,"context_line":"        \"\"\""},{"line_number":389,"context_line":"        try:"},{"line_number":390,"context_line":"            # TODO(tswanson): pick this or return self._lower_key(blob.json())"},{"line_number":391,"context_line":"            return blob.json()"},{"line_number":392,"context_line":"        except AttributeError:"},{"line_number":393,"context_line":"            LOG.error(_LE(\u0027Error invalid json: %s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_6cff03ab","line":390,"in_reply_to":"ba0121b8_5eed85ee","updated":"2016-04-01 20:17:11.000000000","message":"Yes.  Works without this band aide.","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"467c19ec62234600c6008fbb56dba4a4542bbd3b","unresolved":false,"context_lines":[{"line_number":932,"context_line":"    def find_volume(self, name, provider_id):"},{"line_number":933,"context_line":"        \"\"\"Find the volume by name or instanceId."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        We check if we can use provider_id before using it. But if do then"},{"line_number":936,"context_line":"        we expect to find it by provider_id."},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"        We also conclude our failover at this point. If we are failed over we"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_be2941f5","line":935,"range":{"start_line":935,"start_character":60,"end_line":935,"end_character":74},"updated":"2016-04-01 20:02:28.000000000","message":"Wording. But if do ???","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d4fe05119641930813a1ce74703f4f5b250ba10d","unresolved":false,"context_lines":[{"line_number":932,"context_line":"    def find_volume(self, name, provider_id):"},{"line_number":933,"context_line":"        \"\"\"Find the volume by name or instanceId."},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        We check if we can use provider_id before using it. But if do then"},{"line_number":936,"context_line":"        we expect to find it by provider_id."},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"        We also conclude our failover at this point. If we are failed over we"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_ac8bdb1d","line":935,"range":{"start_line":935,"start_character":60,"end_line":935,"end_character":74},"in_reply_to":"ba0121b8_be2941f5","updated":"2016-04-01 20:17:11.000000000","message":"\"Me fail english? That\u0027s unpossible!\" -- Ralph Wiggum","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"467c19ec62234600c6008fbb56dba4a4542bbd3b","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"        :returns: iSCSI property dictionary."},{"line_number":1465,"context_line":"        :raises: VolumeBackendAPIException"},{"line_number":1466,"context_line":"        \"\"\""},{"line_number":1467,"context_line":"        LOG.debug(\u0027find_iscsi_properties. scvolume: %s\u0027, scvolume)"},{"line_number":1468,"context_line":"        # Our mutable process object."},{"line_number":1469,"context_line":"        pdata \u003d {\u0027active\u0027: -1,"},{"line_number":1470,"context_line":"                 \u0027up\u0027: -1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_41c3e88a","line":1467,"range":{"start_line":1467,"start_character":41,"end_line":1467,"end_character":42},"updated":"2016-04-01 20:02:28.000000000","message":"Did you want this period \u0027.\u0027 to be a semicolon \u0027:\u0027 ?","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d4fe05119641930813a1ce74703f4f5b250ba10d","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"        :returns: iSCSI property dictionary."},{"line_number":1465,"context_line":"        :raises: VolumeBackendAPIException"},{"line_number":1466,"context_line":"        \"\"\""},{"line_number":1467,"context_line":"        LOG.debug(\u0027find_iscsi_properties. scvolume: %s\u0027, scvolume)"},{"line_number":1468,"context_line":"        # Our mutable process object."},{"line_number":1469,"context_line":"        pdata \u003d {\u0027active\u0027: -1,"},{"line_number":1470,"context_line":"                 \u0027up\u0027: -1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_2c786b2b","line":1467,"range":{"start_line":1467,"start_character":41,"end_line":1467,"end_character":42},"in_reply_to":"ba0121b8_41c3e88a","updated":"2016-04-01 20:17:11.000000000","message":"Yeah, probably.","commit_id":"444007e1d12222c662c8702728208915bf0fb7e6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cb5df8be0b6b7b0080043124e1bb88bdeaf1ee1f","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                if provider_id.split(\u0027.\u0027)[0] \u003d\u003d str(self.ssn):"},{"line_number":495,"context_line":"                    return True"},{"line_number":496,"context_line":"            except Exception:"},{"line_number":497,"context_line":"                LOG.error(_LE(\u0027_use_provider_id: provider_id is invalid!\u0027))"},{"line_number":498,"context_line":"        return False"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def find_sc(self, ssn\u003d-1):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_3617faa4","line":497,"updated":"2016-04-04 17:35:43.000000000","message":"Looks like if we get here there is something in provider_id but it isn\u0027t what we expect it to be. It might be nice to log the value of provider_id here so we can see why it doesn\u0027t match.\n\nOr if we don\u0027t really care, this could be change to info or even debug.","commit_id":"6fd569a3a7ff2ffc6c8d24922d7ba823de360e4c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"9328f312ca0890c93d2d1ef65e67d44176cc8527","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                if provider_id.split(\u0027.\u0027)[0] \u003d\u003d str(self.ssn):"},{"line_number":495,"context_line":"                    return True"},{"line_number":496,"context_line":"            except Exception:"},{"line_number":497,"context_line":"                LOG.error(_LE(\u0027_use_provider_id: provider_id is invalid!\u0027))"},{"line_number":498,"context_line":"        return False"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"    def find_sc(self, ssn\u003d-1):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_8da4f157","line":497,"in_reply_to":"9a061dce_3617faa4","updated":"2016-04-04 19:27:59.000000000","message":"Done","commit_id":"6fd569a3a7ff2ffc6c8d24922d7ba823de360e4c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cb5df8be0b6b7b0080043124e1bb88bdeaf1ee1f","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"            return self._get_json(r)"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        # If we can\u0027t find the volume then it is effectively gone."},{"line_number":1030,"context_line":"        LOG.warning(_LW(\u0027delete_volume: unable to find volume provider_id:%s\u0027),"},{"line_number":1031,"context_line":"                    provider_id)"},{"line_number":1032,"context_line":"        return True"},{"line_number":1033,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_169476e0","line":1030,"updated":"2016-04-04 17:35:43.000000000","message":"Can you put a space after the \u0027:\u0027?\n\nAssuming you were trying to make this fit \u003c 80. ;)","commit_id":"6fd569a3a7ff2ffc6c8d24922d7ba823de360e4c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"9328f312ca0890c93d2d1ef65e67d44176cc8527","unresolved":false,"context_lines":[{"line_number":1027,"context_line":"            return self._get_json(r)"},{"line_number":1028,"context_line":""},{"line_number":1029,"context_line":"        # If we can\u0027t find the volume then it is effectively gone."},{"line_number":1030,"context_line":"        LOG.warning(_LW(\u0027delete_volume: unable to find volume provider_id:%s\u0027),"},{"line_number":1031,"context_line":"                    provider_id)"},{"line_number":1032,"context_line":"        return True"},{"line_number":1033,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_0d7f41ab","line":1030,"in_reply_to":"9a061dce_169476e0","updated":"2016-04-04 19:27:59.000000000","message":"Done","commit_id":"6fd569a3a7ff2ffc6c8d24922d7ba823de360e4c"}]}