)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"4964d53bd02b99dedca7885c4bed492d976bc52b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cinder and glance are in the same ceph storage cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If cinder creates a volume from an image, it could create"},{"line_number":13,"context_line":"a clonevolume from that image, and the relationship is"},{"line_number":14,"context_line":"image--\u003eclone snapshot--\u003eclone image. If we want a higher performance"},{"line_number":15,"context_line":"rbd image than the clone image,we should flatten the clone image to"},{"line_number":16,"context_line":"meet the application requirements."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_0791e2f0","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":13},"updated":"2016-04-04 18:44:05.000000000","message":"clonevolume -\u003e clone volume?","commit_id":"91b30266469e64706b52cc55bbf2be103f10ac94"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0b43cb45e12f5b75a605d07331250bf992256b71","unresolved":false,"context_lines":[{"line_number":13,"context_line":"a clonevolume from that image, and the relationship is"},{"line_number":14,"context_line":"image--\u003eclone snapshot--\u003eclone image. If we want a higher performance"},{"line_number":15,"context_line":"rbd image than the clone image,we should flatten the clone image to"},{"line_number":16,"context_line":"meet the application requirements."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So it’s necessary to add a config option named rbd_flatten_volume_from_image"},{"line_number":19,"context_line":"to decide whether to flatten rbd clone image or not. If rbd clone image was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_0b3576f6","line":16,"updated":"2016-04-08 14:57:48.000000000","message":"Is there any evidence that this will provide higher performance?","commit_id":"91b30266469e64706b52cc55bbf2be103f10ac94"},{"author":{"_account_id":9064,"name":"Danny Al-Gaaf","email":"danny.al-gaaf@bisect.de","username":"dalgaaf"},"change_message_id":"192337101594c3500c368890bc0f4a399418da9b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"a clonevolume from that image, and the relationship is"},{"line_number":14,"context_line":"image--\u003eclone snapshot--\u003eclone image. If we want a higher performance"},{"line_number":15,"context_line":"rbd image than the clone image,we should flatten the clone image to"},{"line_number":16,"context_line":"meet the application requirements."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So it’s necessary to add a config option named rbd_flatten_volume_from_image"},{"line_number":19,"context_line":"to decide whether to flatten rbd clone image or not. If rbd clone image was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_8eafe1e2","line":16,"in_reply_to":"9a061dce_0b3576f6","updated":"2016-04-15 15:31:47.000000000","message":"No sure if it would increase the performance. Maybe slightly in later use but it would cost time and performance in the first place since the flatten rbd must be copied.","commit_id":"91b30266469e64706b52cc55bbf2be103f10ac94"},{"author":{"_account_id":20748,"name":"Maximiliano Osorio","email":"mosorio@linets.cl","username":"mosorio"},"change_message_id":"0fa0aa1074aeedb0ddbb996fc561137c3282ffc2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"a clonevolume from that image, and the relationship is"},{"line_number":14,"context_line":"image--\u003eclone snapshot--\u003eclone image. If we want a higher performance"},{"line_number":15,"context_line":"rbd image than the clone image,we should flatten the clone image to"},{"line_number":16,"context_line":"meet the application requirements."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So it’s necessary to add a config option named rbd_flatten_volume_from_image"},{"line_number":19,"context_line":"to decide whether to flatten rbd clone image or not. If rbd clone image was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_d36cd038","line":16,"in_reply_to":"9a061dce_0b3576f6","updated":"2016-04-27 01:17:01.000000000","message":"you avoid the download of the image, this is a improvement\n\n[1] http://paste.openstack.org/show/492690/ - image_utils.TemporaryImages.fetch","commit_id":"91b30266469e64706b52cc55bbf2be103f10ac94"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"4964d53bd02b99dedca7885c4bed492d976bc52b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"rbd image than the clone image,we should flatten the clone image to"},{"line_number":16,"context_line":"meet the application requirements."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"So it’s necessary to add a config option named rbd_flatten_volume_from_image"},{"line_number":19,"context_line":"to decide whether to flatten rbd clone image or not. If rbd clone image was"},{"line_number":20,"context_line":"flattened, cinder should also delete the clone_snap."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I153832066977fe827fa5b5284adb8ddbbd88ecf5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_c73c0a32","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":75},"updated":"2016-04-04 18:44:05.000000000","message":"Lines should be wrapped at 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"91b30266469e64706b52cc55bbf2be103f10ac94"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"4964d53bd02b99dedca7885c4bed492d976bc52b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"So it’s necessary to add a config option named rbd_flatten_volume_from_image"},{"line_number":19,"context_line":"to decide whether to flatten rbd clone image or not. If rbd clone image was"},{"line_number":20,"context_line":"flattened, cinder should also delete the clone_snap."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I153832066977fe827fa5b5284adb8ddbbd88ecf5"},{"line_number":23,"context_line":"Implements: blueprint rbd-flatten-clone-image"},{"line_number":24,"context_line":"Closes-Bug: 1374256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_e754ae55","line":21,"updated":"2016-04-04 18:44:05.000000000","message":"I think there should be a DocImpact tag here since a config option is being added.","commit_id":"91b30266469e64706b52cc55bbf2be103f10ac94"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"49b3b41903275760c0921c82d409c1a8defa2ef6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    cfg.BoolOpt(\u0027rbd_flatten_volume_from_image\u0027,"},{"line_number":64,"context_line":"                default\u003dFalse,"},{"line_number":65,"context_line":"                help\u003d\u0027Flatten volumes created from image to remove \u0027"},{"line_number":66,"context_line":"                    \u0027dependency from volume to image\u0027),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027rbd_secret_uuid\u0027,"},{"line_number":68,"context_line":"               help\u003d\u0027The libvirt uuid of the secret for the rbd_user \u0027"},{"line_number":69,"context_line":"                    \u0027volumes\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_4cf7b8d2","line":66,"updated":"2016-04-01 12:28:41.000000000","message":"You\u0027ve a pep8 failure here:\n./cinder/volume/drivers/rbd.py:66:21: E127 continuation line over-indented for visual indent","commit_id":"307bf328c42b132f22f28be9e58b85d006b9de1e"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"49b3b41903275760c0921c82d409c1a8defa2ef6","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                        self._parse_location(url_location)"},{"line_number":902,"context_line":"                    self._clone(volume, pool, image, snapshot)"},{"line_number":903,"context_line":"                    if self.configuration.rbd_flatten_volume_from_image:"},{"line_number":904,"context_line":"                        self._flatten(self.configuration.rbd_pool, volume[\u0027name\u0027])"},{"line_number":905,"context_line":"                    self._resize(volume)"},{"line_number":906,"context_line":"                    return {\u0027provider_location\u0027: None}, True"},{"line_number":907,"context_line":"        return ({}, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ec2e8c41","line":904,"updated":"2016-04-01 12:28:41.000000000","message":"pep8 fails here:\n./cinder/volume/drivers/rbd.py:904:80: E501 line too long (82 \u003e 79 characters)","commit_id":"307bf328c42b132f22f28be9e58b85d006b9de1e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e86d56bbe74a6f98689b6eef4f4e6ba1b7f83bd5","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                        self._parse_location(url_location)"},{"line_number":902,"context_line":"                    self._clone(volume, pool, image, snapshot)"},{"line_number":903,"context_line":"                    if self.configuration.rbd_flatten_volume_from_image:"},{"line_number":904,"context_line":"                        self._flatten(self.configuration.rbd_pool, \\"},{"line_number":905,"context_line":"                            volume[\u0027name\u0027])"},{"line_number":906,"context_line":"                    self._resize(volume)"},{"line_number":907,"context_line":"                    return {\u0027provider_location\u0027: None}, True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_f5774100","line":904,"range":{"start_line":904,"start_character":67,"end_line":904,"end_character":68},"updated":"2016-04-04 15:19:35.000000000","message":"\\ not needed as this is within a parenthesis.","commit_id":"91b30266469e64706b52cc55bbf2be103f10ac94"}]}