)]}'
{"cinder/objects/base.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b2d0c8c85daadfceb65db8d99995e45bcf4e8e2b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# this and remove some history while keeping the versions order."},{"line_number":95,"context_line":"OBJ_VERSIONS.add(\u00271.0\u0027, {\u0027Backup\u0027: \u00271.3\u0027, \u0027BackupImport\u0027: \u00271.3\u0027,"},{"line_number":96,"context_line":"                         \u0027CGSnapshot\u0027: \u00271.0\u0027, \u0027CGSnapshotList\u0027: \u00271.0\u0027,"},{"line_number":97,"context_line":"                         \u0027ConsistencyGroup\u0027: \u00271.3\u0027,"},{"line_number":98,"context_line":"                         \u0027ConsistencyGroupList\u0027: \u00271.1\u0027, \u0027Service\u0027: \u00271.1\u0027,"},{"line_number":99,"context_line":"                         \u0027Volume\u0027: \u00271.3\u0027, \u0027VolumeTypeList\u0027: \u00271.1\u0027})"},{"line_number":100,"context_line":"OBJ_VERSIONS.add(\u00271.1\u0027, {\u0027Service\u0027: \u00271.2\u0027, \u0027ServiceList\u0027: \u00271.1\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_d5695d8d","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":51},"updated":"2016-04-04 15:12:37.000000000","message":"You should actually add a new OBJ_VERSION like that:\n\n OBJ_VERSIONS.add(\u00271.4\u0027, {\u0027ConsistencyGroup\u0027: \u00271.4\u0027})\n\nBut as I\u0027ve commented on other file - I think it will be safe to switch the field type without bumping the version (you need just to update the hash in tests).","commit_id":"08621fe33d9e3d3861d5f2f38baf5c110ef7ea47"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b140613eda76b9ff78fb5bbfd9774f968a5bd5b3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# this and remove some history while keeping the versions order."},{"line_number":95,"context_line":"OBJ_VERSIONS.add(\u00271.0\u0027, {\u0027Backup\u0027: \u00271.3\u0027, \u0027BackupImport\u0027: \u00271.3\u0027,"},{"line_number":96,"context_line":"                         \u0027CGSnapshot\u0027: \u00271.0\u0027, \u0027CGSnapshotList\u0027: \u00271.0\u0027,"},{"line_number":97,"context_line":"                         \u0027ConsistencyGroup\u0027: \u00271.3\u0027,"},{"line_number":98,"context_line":"                         \u0027ConsistencyGroupList\u0027: \u00271.1\u0027, \u0027Service\u0027: \u00271.1\u0027,"},{"line_number":99,"context_line":"                         \u0027Volume\u0027: \u00271.3\u0027, \u0027VolumeTypeList\u0027: \u00271.1\u0027})"},{"line_number":100,"context_line":"OBJ_VERSIONS.add(\u00271.1\u0027, {\u0027Service\u0027: \u00271.2\u0027, \u0027ServiceList\u0027: \u00271.1\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_cb037e0e","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":51},"in_reply_to":"9a061dce_d5695d8d","updated":"2016-04-04 15:53:32.000000000","message":"Yeah, I see those lines below now.  Got it for next time :-)","commit_id":"08621fe33d9e3d3861d5f2f38baf5c110ef7ea47"}],"cinder/objects/consistencygroup.py":[{"author":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"change_message_id":"b24d4991c127f808d957d973a20a6b4a8ea6648b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # Version 1.0: Initial version"},{"line_number":30,"context_line":"    # Version 1.1: Added cgsnapshots and volumes relationships"},{"line_number":31,"context_line":"    # Version 1.2: Changed \u0027status\u0027 field to use ConsistencyGroupStatusField"},{"line_number":32,"context_line":"    # Version 1.2: Changed \u0027volume_type_id\u0027 field to StringField"},{"line_number":33,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_f4e3bc31","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":17},"updated":"2016-04-03 23:20:09.000000000","message":"1.3?","commit_id":"08621fe33d9e3d3861d5f2f38baf5c110ef7ea47"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b140613eda76b9ff78fb5bbfd9774f968a5bd5b3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # Version 1.0: Initial version"},{"line_number":30,"context_line":"    # Version 1.1: Added cgsnapshots and volumes relationships"},{"line_number":31,"context_line":"    # Version 1.2: Changed \u0027status\u0027 field to use ConsistencyGroupStatusField"},{"line_number":32,"context_line":"    # Version 1.2: Changed \u0027volume_type_id\u0027 field to StringField"},{"line_number":33,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_c648955e","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":17},"in_reply_to":"ba0121b8_f4e3bc31","updated":"2016-04-04 15:53:32.000000000","message":"Thanks for the catch, Sharath!\n\nGiven Michal\u0027s comment below, I\u0027ll just remove this line though.","commit_id":"08621fe33d9e3d3861d5f2f38baf5c110ef7ea47"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b2d0c8c85daadfceb65db8d99995e45bcf4e8e2b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":43,"context_line":"        \u0027volume_type_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":44,"context_line":"        \u0027status\u0027: c_fields.ConsistencyGroupStatusField(nullable\u003dTrue),"},{"line_number":45,"context_line":"        \u0027cgsnapshot_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":46,"context_line":"        \u0027source_cgid\u0027: fields.UUIDField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_d55f9d0c","line":43,"range":{"start_line":43,"start_character":33,"end_line":43,"end_character":44},"updated":"2016-04-04 15:12:37.000000000","message":"So UUIDField is mostly same thing as StringField for now (except it fires a warning). I think this is then safe to do without introducing a new object version (when flying over RPC it will be just a string without a type).","commit_id":"08621fe33d9e3d3861d5f2f38baf5c110ef7ea47"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b140613eda76b9ff78fb5bbfd9774f968a5bd5b3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        \u0027availability_zone\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":41,"context_line":"        \u0027name\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":42,"context_line":"        \u0027description\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":43,"context_line":"        \u0027volume_type_id\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":44,"context_line":"        \u0027status\u0027: c_fields.ConsistencyGroupStatusField(nullable\u003dTrue),"},{"line_number":45,"context_line":"        \u0027cgsnapshot_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":46,"context_line":"        \u0027source_cgid\u0027: fields.UUIDField(nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_a641213c","line":43,"range":{"start_line":43,"start_character":33,"end_line":43,"end_character":44},"in_reply_to":"9a061dce_d55f9d0c","updated":"2016-04-04 15:53:32.000000000","message":"OK, sounds good.","commit_id":"08621fe33d9e3d3861d5f2f38baf5c110ef7ea47"}]}
