)]}'
{"cinder/hacking/checks.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"26a11e9498c5d307d812a2548b38c821a80d0c75","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"def check_no_print_statements(logical_line, filename, noqa):"},{"line_number":417,"context_line":"    # The files in cinder/cmd do need to use \u0027print()\u0027 so"},{"line_number":418,"context_line":"    # we don\u0027t need to check those files.  Other exemptions"},{"line_number":419,"context_line":"    # should use \u0027# noqa\u0027 to avoid failing here."},{"line_number":420,"context_line":"    if \"tools/\" in filename:"},{"line_number":421,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_95a07392","line":418,"updated":"2016-04-04 21:08:52.000000000","message":"\"files in cinder/cmd and /tools....\"","commit_id":"684eb47795b9f36d4fe695ee0fc3db1c3c125324"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"366522f89485eb1959d85350d76fcaec0e960743","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"def check_no_print_statements(logical_line, filename, noqa):"},{"line_number":417,"context_line":"    # The files in cinder/cmd do need to use \u0027print()\u0027 so"},{"line_number":418,"context_line":"    # we don\u0027t need to check those files.  Other exemptions"},{"line_number":419,"context_line":"    # should use \u0027# noqa\u0027 to avoid failing here."},{"line_number":420,"context_line":"    if \"tools/\" in filename:"},{"line_number":421,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_70468d24","line":418,"in_reply_to":"9a061dce_95a07392","updated":"2016-04-04 21:31:06.000000000","message":"This is why I don\u0027t like comments that just restate the code...","commit_id":"684eb47795b9f36d4fe695ee0fc3db1c3c125324"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"629597a2198b385966d62931ca82ad6334b362e3","unresolved":false,"context_lines":[{"line_number":416,"context_line":"def check_no_print_statements(logical_line, filename, noqa):"},{"line_number":417,"context_line":"    # The files in cinder/cmd do need to use \u0027print()\u0027 so"},{"line_number":418,"context_line":"    # we don\u0027t need to check those files.  Other exemptions"},{"line_number":419,"context_line":"    # should use \u0027# noqa\u0027 to avoid failing here."},{"line_number":420,"context_line":"    if \"tools/\" in filename:"},{"line_number":421,"context_line":"        return"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_d0a3199d","line":419,"updated":"2016-04-04 21:33:30.000000000","message":"And this should already be known because it\u0027s the same as every other check that takes a \"noqa\" argument.","commit_id":"684eb47795b9f36d4fe695ee0fc3db1c3c125324"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"26a11e9498c5d307d812a2548b38c821a80d0c75","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    # The files in cinder/cmd do need to use \u0027print()\u0027 so"},{"line_number":418,"context_line":"    # we don\u0027t need to check those files.  Other exemptions"},{"line_number":419,"context_line":"    # should use \u0027# noqa\u0027 to avoid failing here."},{"line_number":420,"context_line":"    if \"tools/\" in filename:"},{"line_number":421,"context_line":"        return"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    if \"cinder/cmd\" not in filename and not noqa:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_d5aaeb6f","line":420,"updated":"2016-04-04 21:08:52.000000000","message":"It\u0027s be nice to be consistent. Something like: \nif (\"tools/\", \"cinder/cmd\") in filename:\nreturn\n\nthen remove \u0027cinder/cmd\u0027 from L#423\nor something like that.","commit_id":"684eb47795b9f36d4fe695ee0fc3db1c3c125324"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"366522f89485eb1959d85350d76fcaec0e960743","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    # The files in cinder/cmd do need to use \u0027print()\u0027 so"},{"line_number":418,"context_line":"    # we don\u0027t need to check those files.  Other exemptions"},{"line_number":419,"context_line":"    # should use \u0027# noqa\u0027 to avoid failing here."},{"line_number":420,"context_line":"    if \"tools/\" in filename:"},{"line_number":421,"context_line":"        return"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    if \"cinder/cmd\" not in filename and not noqa:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_b048252f","line":420,"in_reply_to":"9a061dce_d5aaeb6f","updated":"2016-04-04 21:31:06.000000000","message":"Sounds good.","commit_id":"684eb47795b9f36d4fe695ee0fc3db1c3c125324"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"01b185473492bfe4474b86d9b658d73d14ca2622","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    if noqa:"},{"line_number":420,"context_line":"        return"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    if \"cinder/cmd\" in filename or \"tools/\" in filename:"},{"line_number":423,"context_line":"        return"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    if re.match(no_print_statements, logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_c88cf681","line":422,"updated":"2016-04-05 11:45:04.000000000","message":"Should we be doing filename.startswith(\"./cinder/cmd\") or somesuch to guard against occurrences of these in the middle?","commit_id":"437f5be7c89060f535ec090935a74979cc50e102"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a430b3eb2104248e7788c91319dc10cca2d6af73","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    if noqa:"},{"line_number":420,"context_line":"        return"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    if \"cinder/cmd\" in filename or \"tools/\" in filename:"},{"line_number":423,"context_line":"        return"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    if re.match(no_print_statements, logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_a24ee46c","line":422,"in_reply_to":"9a061dce_c88cf681","updated":"2016-04-18 18:32:53.000000000","message":"Maybe, but the problem there is I don\u0027t know if we really have any guarantees about what these filenames are relative to, if they may sometimes be absolute paths, etc.\n\nSo I was intending to stick to the current scheme for now.","commit_id":"437f5be7c89060f535ec090935a74979cc50e102"}]}