)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4ea6f7ae81d24fe5fd4ca9847f27e93dcb3ba515","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yuriy Nesenenko \u003cynesenenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-06 17:09:53 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cinder-all is deprecated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add warning that \u0027cinder-all\u0027 is deprecated as now cinder services"},{"line_number":10,"context_line":"run apart."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a061dce_ad9d070c","line":7,"updated":"2016-04-06 14:39:25.000000000","message":"Please, change it to \u0027Make cinder-all binary deprecated\u0027 or \u0027Deprecate cinder-all binary\u0027 if you\u0027ll make one more patch","commit_id":"f811d56e9494d23924899cb9b433a2e4ca4f9be6"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"9e9a8d0a74b82788ac23f33a9393a26a0c0d8fce","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This command is not tested. Add warning that \u0027cinder-all\u0027 is"},{"line_number":10,"context_line":"deprecated as now cinder services run apart."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related blueprint: cinder-all-is-deprecated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia86a42d297d81fc8272f580e25a3219b90073a77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_d86bd2ef","line":12,"updated":"2016-04-06 15:47:02.000000000","message":"Why it is related? Should be \u0027Implements: blueprint cinder-all-is-deprecated\u0027","commit_id":"8d7e444f5fd1b9e2c915cbe46b607493178aa7fb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6a8236463e6b6475f1b1e5317160a6e133e3a5b2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This command is not tested. Add warning that \u0027cinder-all\u0027 is"},{"line_number":10,"context_line":"deprecated as now cinder services run apart."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related blueprint: cinder-all-is-deprecated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia86a42d297d81fc8272f580e25a3219b90073a77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a061dce_278c6b7e","line":12,"in_reply_to":"9a061dce_d86bd2ef","updated":"2016-04-06 16:59:55.000000000","message":"Agreed, \"Related\" is confusing since this is the whole thing.","commit_id":"8d7e444f5fd1b9e2c915cbe46b607493178aa7fb"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"de7b827dda308a6efbdc5fe86867a69d97f00dee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This command is not tested. Add warning that \u0027cinder-all\u0027 is"},{"line_number":10,"context_line":"deprecated as now cinder services run apart."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related blueprint: cinder-all-is-depricated"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia86a42d297d81fc8272f580e25a3219b90073a77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a061dce_cf93e559","line":12,"updated":"2016-04-07 09:03:28.000000000","message":"You lost the fixes for this line: s/depricated/deprecated and s/Related/Implements.","commit_id":"01ac5adf1c11b594568be6f5279f619a588e4f62"}],"cinder/cmd/all.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cf2b858f96d437521e3b660e2415c62f0bb08686","unresolved":false,"context_lines":[{"line_number":58,"context_line":"def main():"},{"line_number":59,"context_line":"    LOG \u003d logging.getLogger(\u0027cinder.all\u0027)"},{"line_number":60,"context_line":"    versionutils.report_deprecated_feature(LOG, _("},{"line_number":61,"context_line":"        \u0027cinder-all is deprecated and will be removed in the next release.\u0027))"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    objects.register_all()"},{"line_number":64,"context_line":"    gmr_opts.set_defaults(CONF)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a061dce_e256b304","line":61,"updated":"2016-04-07 12:30:16.000000000","message":"Should we say explicitly that it is deprecated in Newton and will be remove in Ocata?\n\n(I made a similar blueprint and patch for Manila and received the review comment that \"next release\" is not a good choice of wording.)","commit_id":"057f60da8383526535fb3f2a4c960cac7b12f4e1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"78105163b41c82bc7d2c538ca1811f6eca57cbe0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027cinder\u0027,"},{"line_number":66,"context_line":"         version\u003dversion.version_string())"},{"line_number":67,"context_line":"    config.set_middleware_defaults()"},{"line_number":68,"context_line":"    logging.setup(CONF, \"cinder\")"},{"line_number":69,"context_line":"    LOG \u003d logging.getLogger(\u0027cinder.all\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    utils.monkey_patch()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a061dce_a034a949","line":68,"updated":"2016-04-07 15:17:27.000000000","message":"Don\u0027t you need to do this logging.setup call before using the LOG above?\n\nAnd remove these two lines?","commit_id":"8c6f53e7a48e08570391b536b311271770ae6f9c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8317069d0043bb4d3cbfb176645b07b7c9a81d25","unresolved":false,"context_lines":[{"line_number":66,"context_line":"         version\u003dversion.version_string())"},{"line_number":67,"context_line":"    config.set_middleware_defaults()"},{"line_number":68,"context_line":"    logging.setup(CONF, \"cinder\")"},{"line_number":69,"context_line":"    LOG \u003d logging.getLogger(\u0027cinder.all\u0027)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    utils.monkey_patch()"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9a061dce_40502d32","line":69,"updated":"2016-04-07 15:19:53.000000000","message":"And this line should now be removed.","commit_id":"8c6f53e7a48e08570391b536b311271770ae6f9c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8ece2c21f948d3f6120cd32356551f93881b1d6d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    gmr_opts.set_defaults(CONF)"},{"line_number":65,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027cinder\u0027,"},{"line_number":66,"context_line":"         version\u003dversion.version_string())"},{"line_number":67,"context_line":"    config.set_middleware_defaults()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    utils.monkey_patch()"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_3f9b8b67","line":67,"updated":"2016-04-07 17:12:13.000000000","message":"Wouldn\u0027t it be simpler and less invasive of the current code base just to do:\n\ndef main()\n    objects.register_all()\n    gmr_opts.set_defaults(CONF)\n    CONF(sys.argv[1:], project\u003d\u0027cinder\u0027,\n         version\u003dversion.version_string())\n    config.set_middleware_defaults()\n    logging.setup(CONF, \"cinder\")\n    LOG \u003d logging.getLogger(\u0027cinder.all\u0027)\n\n    versionutils.report_deprecated_feature(LOG, ...) # the  only new code besides the import of _, lines 61-62 above.\n\n    utils.moneky_path()\n    ...","commit_id":"a7cf29ed70298324be7dceeec969c33f1d00a645"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"b71bf37a83f2ed233d045257076c726aa4bd195b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    gmr_opts.set_defaults(CONF)"},{"line_number":65,"context_line":"    CONF(sys.argv[1:], project\u003d\u0027cinder\u0027,"},{"line_number":66,"context_line":"         version\u003dversion.version_string())"},{"line_number":67,"context_line":"    config.set_middleware_defaults()"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    utils.monkey_patch()"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a061dce_8ddf0cd5","line":67,"in_reply_to":"9a061dce_3f9b8b67","updated":"2016-04-07 19:28:38.000000000","message":"ok","commit_id":"a7cf29ed70298324be7dceeec969c33f1d00a645"}]}