)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a446aa59a6cabd9f5b2053cd41257d83c8110f96","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate nas_ip and change this to nas_host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes a usability/discoverability problem since"},{"line_number":10,"context_line":"the option is named \"ip\" but isn\u0027t just for IPs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3383e586219b7f831194805d2d4230ee620c7c14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a122d0e_07642147","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":24},"updated":"2016-04-18 11:20:42.000000000","message":"nit: \"nas_ip\"","commit_id":"b0fce4f6e209b89b2e3f147438b347fb1d42ce59"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"ce1f29168c70891eca967a3282f704cc185772e0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate nas_ip and change this to nas_host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes a usability/discoverability problem since"},{"line_number":10,"context_line":"the option is named \"ip\" but isn\u0027t just for IPs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3383e586219b7f831194805d2d4230ee620c7c14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a122d0e_1ac8f421","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":24},"in_reply_to":"1a122d0e_07642147","updated":"2016-04-18 11:39:42.000000000","message":"Done","commit_id":"b0fce4f6e209b89b2e3f147438b347fb1d42ce59"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b526cf0629e117b3146eaea634e9444d09b5f735","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027nas_host\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027IP address or Hostname of NAS system.\u0027,"},{"line_number":46,"context_line":"               deprecated_opts\u003d[deprecated_nas_opt]),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027nas_login\u0027,"},{"line_number":48,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027User name to connect to NAS system.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_803d182d","line":46,"updated":"2016-04-07 18:04:42.000000000","message":"Why isn\u0027t this just using \"deprecated_name\"?","commit_id":"af8c3b63fd5bae6ac493a4e874ee935bfa8d84c9"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"af5c66477dd40016c4471f854e89321e3505354a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027nas_host\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027IP address or Hostname of NAS system.\u0027,"},{"line_number":46,"context_line":"               deprecated_opts\u003d[deprecated_nas_ip]),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027nas_login\u0027,"},{"line_number":48,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027User name to connect to NAS system.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_e69cd05f","line":46,"range":{"start_line":46,"start_character":15,"end_line":46,"end_character":30},"updated":"2016-04-08 08:55:45.000000000","message":"I agree with Eric here - can you explain why you\u0027re not using deprecated_name?","commit_id":"19d601fd0c10fb2623bd96ff1121dc602e1b19ab"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a619a5182e9935413466b38530c6e44ae02145bd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027nas_host\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027IP address or Hostname of NAS system.\u0027,"},{"line_number":46,"context_line":"               deprecated_opts\u003d[deprecated_nas_ip]),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027nas_login\u0027,"},{"line_number":48,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027User name to connect to NAS system.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_400f5f2e","line":46,"range":{"start_line":46,"start_character":15,"end_line":46,"end_character":30},"updated":"2016-04-08 09:36:48.000000000","message":"I don\u0027t think that\u0027s done. Can you please either use deprecated_name or explain why it isn\u0027t possible?","commit_id":"19d601fd0c10fb2623bd96ff1121dc602e1b19ab"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7c913d051384edfebc9ad04af06384efec77429f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    cfg.StrOpt(\u0027nas_host\u0027,"},{"line_number":44,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":45,"context_line":"               help\u003d\u0027IP address or Hostname of NAS system.\u0027,"},{"line_number":46,"context_line":"               deprecated_opts\u003d[deprecated_nas_ip]),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027nas_login\u0027,"},{"line_number":48,"context_line":"               default\u003d\u0027admin\u0027,"},{"line_number":49,"context_line":"               help\u003d\u0027User name to connect to NAS system.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f15ac829","line":46,"range":{"start_line":46,"start_character":15,"end_line":46,"end_character":30},"in_reply_to":"9a061dce_e69cd05f","updated":"2016-04-08 09:05:28.000000000","message":"Done","commit_id":"19d601fd0c10fb2623bd96ff1121dc602e1b19ab"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"af5c66477dd40016c4471f854e89321e3505354a","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if all((self.configuration.nas_host,"},{"line_number":441,"context_line":"                self.configuration.nas_share_path)):"},{"line_number":442,"context_line":"            LOG.debug(\u0027Using nas_ip and nas_share_path configuration.\u0027)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            nas_ip \u003d self.configuration.nas_host"},{"line_number":445,"context_line":"            nas_share_path \u003d self.configuration.nas_share_path"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_c6b42cd6","line":442,"range":{"start_line":442,"start_character":29,"end_line":442,"end_character":35},"updated":"2016-04-08 08:55:45.000000000","message":"nas_host?","commit_id":"19d601fd0c10fb2623bd96ff1121dc602e1b19ab"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7c913d051384edfebc9ad04af06384efec77429f","unresolved":false,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if all((self.configuration.nas_host,"},{"line_number":441,"context_line":"                self.configuration.nas_share_path)):"},{"line_number":442,"context_line":"            LOG.debug(\u0027Using nas_ip and nas_share_path configuration.\u0027)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            nas_ip \u003d self.configuration.nas_host"},{"line_number":445,"context_line":"            nas_share_path \u003d self.configuration.nas_share_path"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_d14b445e","line":442,"range":{"start_line":442,"start_character":29,"end_line":442,"end_character":35},"in_reply_to":"9a061dce_c6b42cd6","updated":"2016-04-08 09:05:28.000000000","message":"Done","commit_id":"19d601fd0c10fb2623bd96ff1121dc602e1b19ab"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"af5c66477dd40016c4471f854e89321e3505354a","unresolved":false,"context_lines":[{"line_number":449,"context_line":"            if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":450,"context_line":"                msg \u003d (_(\"Share %s ignored due to invalid format. Must \""},{"line_number":451,"context_line":"                         \"be of form address:/export. Please check the \""},{"line_number":452,"context_line":"                         \"nas_ip and nas_share_path settings.\"),"},{"line_number":453,"context_line":"                       share_address)"},{"line_number":454,"context_line":"                raise exception.InvalidConfigurationValue(msg)"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_c6db8c20","line":452,"range":{"start_line":452,"start_character":26,"end_line":452,"end_character":32},"updated":"2016-04-08 08:55:45.000000000","message":"nas_host?","commit_id":"19d601fd0c10fb2623bd96ff1121dc602e1b19ab"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7c913d051384edfebc9ad04af06384efec77429f","unresolved":false,"context_lines":[{"line_number":449,"context_line":"            if not re.match(self.SHARE_FORMAT_REGEX, share_address):"},{"line_number":450,"context_line":"                msg \u003d (_(\"Share %s ignored due to invalid format. Must \""},{"line_number":451,"context_line":"                         \"be of form address:/export. Please check the \""},{"line_number":452,"context_line":"                         \"nas_ip and nas_share_path settings.\"),"},{"line_number":453,"context_line":"                       share_address)"},{"line_number":454,"context_line":"                raise exception.InvalidConfigurationValue(msg)"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_11565c06","line":452,"range":{"start_line":452,"start_character":26,"end_line":452,"end_character":32},"in_reply_to":"9a061dce_c6db8c20","updated":"2016-04-08 09:05:28.000000000","message":"Done","commit_id":"19d601fd0c10fb2623bd96ff1121dc602e1b19ab"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a446aa59a6cabd9f5b2053cd41257d83c8110f96","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                self.configuration.nas_share_path)):"},{"line_number":441,"context_line":"            LOG.debug(\u0027Using nas_host and nas_share_path configuration.\u0027)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"            nas_ip \u003d self.configuration.nas_host"},{"line_number":444,"context_line":"            nas_share_path \u003d self.configuration.nas_share_path"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"            share_address \u003d \u0027%s:%s\u0027 % (nas_ip, nas_share_path)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_87d791be","line":443,"range":{"start_line":443,"start_character":12,"end_line":443,"end_character":18},"updated":"2016-04-18 11:20:42.000000000","message":"-1: Variable name should also be changed to `nas_host`","commit_id":"b0fce4f6e209b89b2e3f147438b347fb1d42ce59"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"ce1f29168c70891eca967a3282f704cc185772e0","unresolved":false,"context_lines":[{"line_number":440,"context_line":"                self.configuration.nas_share_path)):"},{"line_number":441,"context_line":"            LOG.debug(\u0027Using nas_host and nas_share_path configuration.\u0027)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"            nas_ip \u003d self.configuration.nas_host"},{"line_number":444,"context_line":"            nas_share_path \u003d self.configuration.nas_share_path"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"            share_address \u003d \u0027%s:%s\u0027 % (nas_ip, nas_share_path)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_7a50085f","line":443,"range":{"start_line":443,"start_character":12,"end_line":443,"end_character":18},"in_reply_to":"1a122d0e_87d791be","updated":"2016-04-18 11:39:42.000000000","message":"Done","commit_id":"b0fce4f6e209b89b2e3f147438b347fb1d42ce59"}],"releasenotes/notes/deprecated-nas-ip-fd86a734c92f6fae.yaml":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d7baf37103d2da79b4f758a932cd801631c21d2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"    - Deprecate nas_ip"},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - Change nas_ip to nas_host"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_5548ad87","line":3,"updated":"2016-04-08 14:25:23.000000000","message":"Please, add more details what and why is deprecated","commit_id":"2eedd3b341b66b846ea5ab74b0b4093119b0157b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d7baf37103d2da79b4f758a932cd801631c21d2f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"    - Deprecate nas_ip"},{"line_number":4,"context_line":"other:"},{"line_number":5,"context_line":"    - Change nas_ip to nas_host"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_35309907","line":5,"updated":"2016-04-08 14:25:23.000000000","message":"It should be in \"deprecations\" section","commit_id":"2eedd3b341b66b846ea5ab74b0b4093119b0157b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"cd9d262615032e21b4a9bdc895d110b360b3aaa8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"    - Deprecate nas_ip and change nas_ip to nas_host."},{"line_number":4,"context_line":"      It will be much clear to use nas_host as IP"},{"line_number":5,"context_line":"      address or Hostname of NAS system."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a061dce_cb689e8a","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":40},"updated":"2016-04-08 14:48:03.000000000","message":"Maybe it\u0027s bikeshedding, but this doesn\u0027t give an info that nas_ip is an configuration option.","commit_id":"fe0c151d2e7adad119f27009bd486bbb7a2fd02a"},{"author":{"_account_id":20993,"name":"Cody Eilrich","email":"cody.eilrich@ericsson.com","username":"ceilrich"},"change_message_id":"813e2c552ff7dd3ae83ac5b07360e0c7bb7195df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"    - Deprecate the nas_ip configuration option"},{"line_number":4,"context_line":"      and change it with the nas_host. It will be"},{"line_number":5,"context_line":"      much clear to use the nas_host configuration"},{"line_number":6,"context_line":"      option instead of the nas_ip as IP address"},{"line_number":7,"context_line":"      or Hostname of NAS system."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a061dce_9725250c","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":28},"updated":"2016-04-08 15:49:07.000000000","message":"s/with the/to/","commit_id":"ecf9e0fb96e8dcacb85610d33f8248b266f96955"},{"author":{"_account_id":20993,"name":"Cody Eilrich","email":"cody.eilrich@ericsson.com","username":"ceilrich"},"change_message_id":"813e2c552ff7dd3ae83ac5b07360e0c7bb7195df","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"    - Deprecate the nas_ip configuration option"},{"line_number":4,"context_line":"      and change it with the nas_host. It will be"},{"line_number":5,"context_line":"      much clear to use the nas_host configuration"},{"line_number":6,"context_line":"      option instead of the nas_ip as IP address"},{"line_number":7,"context_line":"      or Hostname of NAS system."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a061dce_37025970","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":23},"updated":"2016-04-08 15:49:07.000000000","message":"s/much clear to use/clearer using/","commit_id":"ecf9e0fb96e8dcacb85610d33f8248b266f96955"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"33445746fd0e8f97a4754e2a63cf07b9ba296474","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"    - Deprecate the nas_ip configuration option"},{"line_number":4,"context_line":"      and change it with the nas_host. It will be"},{"line_number":5,"context_line":"      much clear to use the nas_host configuration"},{"line_number":6,"context_line":"      option instead of the nas_ip as IP address"},{"line_number":7,"context_line":"      or Hostname of NAS system."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a122d0e_fdec122b","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":28},"updated":"2016-04-18 11:53:30.000000000","message":"nit: I think \"to\" was better.","commit_id":"76a28f53cae3c165eebae3c1c13925f681f70394"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"33445746fd0e8f97a4754e2a63cf07b9ba296474","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"    - Deprecate the nas_ip configuration option"},{"line_number":4,"context_line":"      and change it with the nas_host. It will be"},{"line_number":5,"context_line":"      much clear to use the nas_host configuration"},{"line_number":6,"context_line":"      option instead of the nas_ip as IP address"},{"line_number":7,"context_line":"      or Hostname of NAS system."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a122d0e_9ddebe6b","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":16},"updated":"2016-04-18 11:53:30.000000000","message":"nit: \"clearer\" or \"more clear\"","commit_id":"76a28f53cae3c165eebae3c1c13925f681f70394"}]}