)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"658434bb2432c78f5749b636dd3b9926d2e6a436","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating cgsnapshot, Cinder will copy"},{"line_number":10,"context_line":"bootable volume\u0027s image metadata to snapshot,"},{"line_number":11,"context_line":"but if the volume don\u0027t have image metadata,"},{"line_number":12,"context_line":"Cinder should catach GlanceMetadataNotFound"},{"line_number":13,"context_line":"and let it pass, but now Cinder only catch"},{"line_number":14,"context_line":"CinderException and raise it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a1b2928_af128560","line":11,"updated":"2016-04-11 16:07:15.000000000","message":"s/don\u0027t/doesn\u0027t","commit_id":"81301b4c3ab610ab6ee6382bdc550b7d4de8c433"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"0c725bc54549b45bff8988482d2600449be9fcd1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating cgsnapshot, Cinder will copy"},{"line_number":10,"context_line":"bootable volume\u0027s image metadata to snapshot,"},{"line_number":11,"context_line":"but if the volume don\u0027t have image metadata,"},{"line_number":12,"context_line":"Cinder should catach GlanceMetadataNotFound"},{"line_number":13,"context_line":"and let it pass, but now Cinder only catch"},{"line_number":14,"context_line":"CinderException and raise it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_86c4d840","line":11,"in_reply_to":"7a1b2928_af128560","updated":"2016-05-06 00:36:21.000000000","message":"Done","commit_id":"81301b4c3ab610ab6ee6382bdc550b7d4de8c433"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"658434bb2432c78f5749b636dd3b9926d2e6a436","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When creating cgsnapshot, Cinder will copy"},{"line_number":10,"context_line":"bootable volume\u0027s image metadata to snapshot,"},{"line_number":11,"context_line":"but if the volume don\u0027t have image metadata,"},{"line_number":12,"context_line":"Cinder should catach GlanceMetadataNotFound"},{"line_number":13,"context_line":"and let it pass, but now Cinder only catch"},{"line_number":14,"context_line":"CinderException and raise it."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a1b2928_0f2d79a7","line":12,"updated":"2016-04-11 16:07:15.000000000","message":"s/catach/catch/","commit_id":"81301b4c3ab610ab6ee6382bdc550b7d4de8c433"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"0c725bc54549b45bff8988482d2600449be9fcd1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When creating cgsnapshot, Cinder will copy"},{"line_number":10,"context_line":"bootable volume\u0027s image metadata to snapshot,"},{"line_number":11,"context_line":"but if the volume don\u0027t have image metadata,"},{"line_number":12,"context_line":"Cinder should catach GlanceMetadataNotFound"},{"line_number":13,"context_line":"and let it pass, but now Cinder only catch"},{"line_number":14,"context_line":"CinderException and raise it."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_c6dc201b","line":12,"in_reply_to":"7a1b2928_0f2d79a7","updated":"2016-05-06 00:36:21.000000000","message":"Done","commit_id":"81301b4c3ab610ab6ee6382bdc550b7d4de8c433"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"08e953a6ae459a0f7a5e93de6e319b64aec2a13e","unresolved":false,"context_lines":[{"line_number":5493,"context_line":"        cgsnap.status \u003d \"creating\""},{"line_number":5494,"context_line":"        cgsnap.create()"},{"line_number":5495,"context_line":""},{"line_number":5496,"context_line":"        # Create snapshots object"},{"line_number":5497,"context_line":"        snaps\u003d[]"},{"line_number":5498,"context_line":"        for volume_id in volume_ids:"},{"line_number":5499,"context_line":"            snap \u003d objects.Snapshot(context.get_admin_context())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_6f143a4c","line":5496,"updated":"2016-04-07 16:31:14.000000000","message":"you are creating a list of snapshot objects, not a snapshots object.","commit_id":"1a69d18ecc1ddde5aa38aa35ef6a98dee518b0d7"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"df2f14e01dac950c47e8ded9fc7d1b8a4b0b79dd","unresolved":false,"context_lines":[{"line_number":5493,"context_line":"        cgsnap.status \u003d \"creating\""},{"line_number":5494,"context_line":"        cgsnap.create()"},{"line_number":5495,"context_line":""},{"line_number":5496,"context_line":"        # Create snapshots object"},{"line_number":5497,"context_line":"        snaps\u003d[]"},{"line_number":5498,"context_line":"        for volume_id in volume_ids:"},{"line_number":5499,"context_line":"            snap \u003d objects.Snapshot(context.get_admin_context())"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_20ca23a2","line":5496,"in_reply_to":"9a061dce_6f143a4c","updated":"2016-04-11 06:57:06.000000000","message":"yes, you\u0027re right.","commit_id":"1a69d18ecc1ddde5aa38aa35ef6a98dee518b0d7"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"08e953a6ae459a0f7a5e93de6e319b64aec2a13e","unresolved":false,"context_lines":[{"line_number":5520,"context_line":"    @mock.patch(\u0027cinder.volume.driver.VolumeDriver.delete_cgsnapshot\u0027,"},{"line_number":5521,"context_line":"                autospec\u003dTrue,"},{"line_number":5522,"context_line":"                return_value\u003d({\u0027status\u0027: \u0027deleted\u0027}, []))"},{"line_number":5523,"context_line":"    def test_create_delete_cgsnapshot(self,"},{"line_number":5524,"context_line":"                                      mock_del_cgsnap, mock_create_cgsnap,"},{"line_number":5525,"context_line":"                                      mock_del_cg, _mock_create_cg):"},{"line_number":5526,"context_line":"        \"\"\"Test cgsnapshot can be created and deleted.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_6baeed2e","line":5523,"updated":"2016-04-07 16:31:14.000000000","message":"IMO this test is already too complicated and overloaded - doing too many things for one unit test - and now you are putting more stuff in it!\n\nI\u0027d much prefer that you check your change in a separate, leaner test case.","commit_id":"1a69d18ecc1ddde5aa38aa35ef6a98dee518b0d7"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"df2f14e01dac950c47e8ded9fc7d1b8a4b0b79dd","unresolved":false,"context_lines":[{"line_number":5520,"context_line":"    @mock.patch(\u0027cinder.volume.driver.VolumeDriver.delete_cgsnapshot\u0027,"},{"line_number":5521,"context_line":"                autospec\u003dTrue,"},{"line_number":5522,"context_line":"                return_value\u003d({\u0027status\u0027: \u0027deleted\u0027}, []))"},{"line_number":5523,"context_line":"    def test_create_delete_cgsnapshot(self,"},{"line_number":5524,"context_line":"                                      mock_del_cgsnap, mock_create_cgsnap,"},{"line_number":5525,"context_line":"                                      mock_del_cg, _mock_create_cg):"},{"line_number":5526,"context_line":"        \"\"\"Test cgsnapshot can be created and deleted.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_805217dc","line":5523,"in_reply_to":"9a061dce_6baeed2e","updated":"2016-04-11 06:57:06.000000000","message":"Sure, no problem.","commit_id":"1a69d18ecc1ddde5aa38aa35ef6a98dee518b0d7"}]}