)]}'
{"cinder/db/api.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"cbe9f900ca9be80677bfea360d767937195f88cc","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":":backend:  string to lookup in the list of LazyPluggable backends."},{"line_number":36,"context_line":"           `sqlalchemy` is the only supported backend right now."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":":connection:  string specifying the sqlalchemy connection to use, like:"},{"line_number":39,"context_line":"              `sqlite:///var/lib/cinder/cinder.sqlite`."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FnQU%3D","line":37,"updated":"2013-05-29 10:58:30.000000000","message":"Is renaming these flags going to cause existing config files to be invalid? If so we need a migration strategy...","commit_id":"7055b7826527c1af9792a748ace55686c34a3915"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2d259dec780b245f4c80a793027ed9e22d39c389","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":":backend:  string to lookup in the list of LazyPluggable backends."},{"line_number":36,"context_line":"           `sqlalchemy` is the only supported backend right now."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":":connection:  string specifying the sqlalchemy connection to use, like:"},{"line_number":39,"context_line":"              `sqlite:///var/lib/cinder/cinder.sqlite`."},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FnIE%3D","line":37,"in_reply_to":"AAAAPH%2F%2FnQU%3D","updated":"2013-05-29 12:59:43.000000000","message":"Duncan, oslo.config allows us to define new config options that are backward compatible with old ones (you can specify \u0027deprecated_name\u0027 and \u0027deprecated_group\u0027 arguments when creating a new option). Thus, we only have to ensure the new options names are used in our code, but at the same time config files may still contain the old ones. When we try to retrieve the option value, the current option name and all deprecated aliases are checked. Please correct me, if I\u0027m wrong.\n\nDB-specific options are defined in common Oslo DB code and should be removed from here (they provide deprecated aliases to ensure existing config files remain valid).","commit_id":"7055b7826527c1af9792a748ace55686c34a3915"}],"cinder/db/sqlalchemy/models.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"3030dc7a54e50fcfe264b4246fc0f9cc64a7cc18","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    updated_at \u003d Column(DateTime, onupdate\u003dtimeutils.utcnow)"},{"line_number":47,"context_line":"    deleted_at \u003d Column(DateTime)"},{"line_number":48,"context_line":"    deleted \u003d Column(Boolean, default\u003dFalse)"},{"line_number":49,"context_line":"    metadata \u003d None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def save(self, session\u003dNone):"},{"line_number":52,"context_line":"        \"\"\"Save this object.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FpU8%3D","side":"PARENT","line":49,"updated":"2013-05-28 17:35:45.000000000","message":"Absence of this line is the cause of the errors","commit_id":"b782597725fcccd0a6a949057941380538898555"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ceddfadb881566d018b8a94a1856b18662af059d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    updated_at \u003d Column(DateTime, onupdate\u003dtimeutils.utcnow)"},{"line_number":47,"context_line":"    deleted_at \u003d Column(DateTime)"},{"line_number":48,"context_line":"    deleted \u003d Column(Boolean, default\u003dFalse)"},{"line_number":49,"context_line":"    metadata \u003d None"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def save(self, session\u003dNone):"},{"line_number":52,"context_line":"        \"\"\"Save this object.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FniU%3D","side":"PARENT","line":49,"in_reply_to":"AAAAPH%2F%2FpU8%3D","updated":"2013-05-29 08:57:44.000000000","message":"Done","commit_id":"b782597725fcccd0a6a949057941380538898555"}],"cinder/flags.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d56a8b551a8fef9a42a5338e84b24757833e671d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    except socket.error:"},{"line_number":73,"context_line":"        return \"127.0.0.1\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"core_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection_type\u0027,"},{"line_number":78,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FqnI%3D","line":75,"updated":"2013-05-28 08:15:24.000000000","message":"If oslo db session is used, then why are these options still remaining? get_engine looks up CONF.database.connection now and its deprecated_name is sql_connection in DEFAULT so conf files will be bw compatible. AFAIK these options don\u0027t look useful anymore. see https://review.openstack.org/#/c/27265/18/quantum/db/api.py","commit_id":"bc250a0e3d42da0b4ff9ded6f4f94066d02b032c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"5f342a0417799d77618dbb627a580198cd40854e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    except socket.error:"},{"line_number":73,"context_line":"        return \"127.0.0.1\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"core_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection_type\u0027,"},{"line_number":78,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FqGc%3D","line":75,"in_reply_to":"AAAAPH%2F%2Fqkw%3D","updated":"2013-05-28 13:46:06.000000000","message":"Thanks for pointing this out, guys! Done.","commit_id":"bc250a0e3d42da0b4ff9ded6f4f94066d02b032c"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"76af58da4494d74faf336f3af7e2695d2473831f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    except socket.error:"},{"line_number":73,"context_line":"        return \"127.0.0.1\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"core_opts \u003d ["},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027connection_type\u0027,"},{"line_number":78,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fqkw%3D","line":75,"in_reply_to":"AAAAPH%2F%2FqnI%3D","updated":"2013-05-28 08:27:10.000000000","message":"I agree with Zhongyue.  These config options seems to be deprecated by Oslo DB module.","commit_id":"bc250a0e3d42da0b4ff9ded6f4f94066d02b032c"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"cbe9f900ca9be80677bfea360d767937195f88cc","unresolved":false,"context_lines":[{"line_number":176,"context_line":"               default\u003d3600,"},{"line_number":177,"context_line":"               help\u003d\u0027timeout before idle sql connections are reaped\u0027),"},{"line_number":178,"context_line":"    cfg.IntOpt(\u0027sql_max_retries\u0027,"},{"line_number":179,"context_line":"               default\u003d10,"},{"line_number":180,"context_line":"               help\u003d\u0027maximum db connection retries during startup. \u0027"},{"line_number":181,"context_line":"                    \u0027(setting -1 implies an infinite retry count)\u0027),"},{"line_number":182,"context_line":"    cfg.IntOpt(\u0027sql_retry_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FnP8%3D","side":"PARENT","line":179,"updated":"2013-05-29 10:58:30.000000000","message":"Does removing this cause existing configs to change behaviour? Looks to me like it does.","commit_id":"77a77456af6944a3bf6eb4e3b75b7094d8b54391"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2d259dec780b245f4c80a793027ed9e22d39c389","unresolved":false,"context_lines":[{"line_number":176,"context_line":"               default\u003d3600,"},{"line_number":177,"context_line":"               help\u003d\u0027timeout before idle sql connections are reaped\u0027),"},{"line_number":178,"context_line":"    cfg.IntOpt(\u0027sql_max_retries\u0027,"},{"line_number":179,"context_line":"               default\u003d10,"},{"line_number":180,"context_line":"               help\u003d\u0027maximum db connection retries during startup. \u0027"},{"line_number":181,"context_line":"                    \u0027(setting -1 implies an infinite retry count)\u0027),"},{"line_number":182,"context_line":"    cfg.IntOpt(\u0027sql_retry_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FnBM%3D","side":"PARENT","line":179,"in_reply_to":"AAAAPH%2F%2FnP8%3D","updated":"2013-05-29 12:59:43.000000000","message":"ditto","commit_id":"77a77456af6944a3bf6eb4e3b75b7094d8b54391"}]}