)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cb913dc88ebcf4c5825c79369a63b1c582ee895a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix up the test framework"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When trying to test an bug the cinder test framework was"},{"line_number":10,"context_line":"running all the tests when I just wanted one to run."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Instead of fixing this problem in nose I tried to move cinder to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPH%2F%2FrvI%3D","line":9,"updated":"2013-05-27 09:13:21.000000000","message":"test a* bug","commit_id":"2bb3ca14c92f153969114f9a590837618bcf8265"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cb913dc88ebcf4c5825c79369a63b1c582ee895a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"./run_tests.sh - works"},{"line_number":23,"context_line":"./run_tests.sh -d - works"},{"line_number":24,"context_line":"./run_tests.sh -d test.module.some.test - works"},{"line_number":25,"context_line":"./run_tests.sh test.module.some.test - does not work you get:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Fixes: bug 1183434"},{"line_number":28,"context_line":"Fixes: bug 1177924"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPH%2F%2FrvE%3D","line":25,"updated":"2013-05-27 09:13:21.000000000","message":"I think you missed pasting the error here","commit_id":"2bb3ca14c92f153969114f9a590837618bcf8265"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cb913dc88ebcf4c5825c79369a63b1c582ee895a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"./run_tests.sh -d test.module.some.test - works"},{"line_number":25,"context_line":"./run_tests.sh test.module.some.test - does not work you get:"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Fixes: bug 1183434"},{"line_number":28,"context_line":"Fixes: bug 1177924"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I5e10b55c5b236eb81a6a3e0e9ea56af8ca4ef8e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAPH%2F%2Fru8%3D","line":27,"updated":"2013-05-27 09:13:21.000000000","message":"add this bug 1181996 too to enable better tracking. (1183434 is a duplicate of this bug)","commit_id":"2bb3ca14c92f153969114f9a590837618bcf8265"}],"cinder/api/openstack/__init__.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"76dc5fed9e0c3d2d49c6ac9d75273a08cf98d65a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                   \u0027use cinder.api.middleware.fault:FaultWrapper instead.\u0027))"},{"line_number":130,"context_line":"        # Avoid circular imports from here. Can I just remove this?"},{"line_number":131,"context_line":"        from cinder.api.middleware import fault"},{"line_number":132,"context_line":"        super(FaultWrapper, self).__init__(fault.FaultWrapper(application))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPX%2F%2F1qE%3D","line":132,"updated":"2013-06-07 20:46:30.000000000","message":"Why are we doing this?   What was wrong with the original import and using fault.FaultWrapper as the parent?","commit_id":"d3a8a8dde9f2df3b0fd59524aafab580b7be78c6"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"d022c062ce0662a1e65eac2516583935cfb8b5c3","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                   \u0027use cinder.api.middleware.fault:FaultWrapper instead.\u0027))"},{"line_number":130,"context_line":"        # Avoid circular imports from here. Can I just remove this?"},{"line_number":131,"context_line":"        from cinder.api.middleware import fault"},{"line_number":132,"context_line":"        super(FaultWrapper, self).__init__(fault.FaultWrapper(application))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPX%2F%2Fziw%3D","line":132,"in_reply_to":"AAAAPX%2F%2F1qE%3D","updated":"2013-06-10 08:22:17.000000000","message":"I definitely did have this file import cinder.api.middleware.fault -\u003e imports cinder.api.openstack.wsgi -\u003e import cinder.api.openstack (this file) but I can\u0027t reproduce it at the moment.\n\nThere have been a lot of issues coming up because of the test framework been in the state it is, and this most have been one, that then gets fix somehow. I will revert the changes to this file.","commit_id":"d3a8a8dde9f2df3b0fd59524aafab580b7be78c6"}],"cinder/test.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cb913dc88ebcf4c5825c79369a63b1c582ee895a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import functools"},{"line_number":30,"context_line":"import os"},{"line_number":31,"context_line":"import shutil"},{"line_number":32,"context_line":"import unittest"},{"line_number":33,"context_line":"import uuid"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"import fixtures"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2Fru4%3D","line":32,"updated":"2013-05-27 09:13:21.000000000","message":"unittest not used","commit_id":"2bb3ca14c92f153969114f9a590837618bcf8265"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"b77c6564059d486b6119cd286d7cc25e76cbc25a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        if self.sql_connection \u003d\u003d \"sqlite://\":"},{"line_number":97,"context_line":"            conn \u003d self.engine.connect()"},{"line_number":98,"context_line":"            conn.connection.executescript(self._DB)"},{"line_number":99,"context_line":"            self.addCleanup(self.engine.dispose)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            shutil.copyfile("},{"line_number":102,"context_line":"                os.path.join(FLAGS.state_path, self.sqlite_clean_db),"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPX%2F%2Fmsg%3D","line":99,"updated":"2013-06-14 15:03:44.000000000","message":"Is the PEP8 error (no such method) valid or not? (See none-voting jenkin PEP8 failure","commit_id":"930f5891b0815e1b49b9b2cc840e0c24b2796e84"},{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"ce323c88be457541579b01ca5fe0422e713aa32a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        if self.sql_connection \u003d\u003d \"sqlite://\":"},{"line_number":97,"context_line":"            conn \u003d self.engine.connect()"},{"line_number":98,"context_line":"            conn.connection.executescript(self._DB)"},{"line_number":99,"context_line":"            self.addCleanup(self.engine.dispose)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            shutil.copyfile("},{"line_number":102,"context_line":"                os.path.join(FLAGS.state_path, self.sqlite_clean_db),"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPX%2F%2FmNk%3D","line":99,"in_reply_to":"AAAAPX%2F%2FmZ4%3D","updated":"2013-06-14 17:27:24.000000000","message":"This appears to be a pylint false positive. Just leave as it is and it won\u0027t complain again once it\u0027s merged.","commit_id":"930f5891b0815e1b49b9b2cc840e0c24b2796e84"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"99ecbe66f7cc06532e02f61e5e419832342b1ee3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        if self.sql_connection \u003d\u003d \"sqlite://\":"},{"line_number":97,"context_line":"            conn \u003d self.engine.connect()"},{"line_number":98,"context_line":"            conn.connection.executescript(self._DB)"},{"line_number":99,"context_line":"            self.addCleanup(self.engine.dispose)"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            shutil.copyfile("},{"line_number":102,"context_line":"                os.path.join(FLAGS.state_path, self.sqlite_clean_db),"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPX%2F%2FmZ4%3D","line":99,"in_reply_to":"AAAAPX%2F%2Fmsg%3D","updated":"2013-06-14 16:17:59.000000000","message":"It\u0027s not valid. The method does exist.\n\nWhat should I do about this?","commit_id":"930f5891b0815e1b49b9b2cc840e0c24b2796e84"}],"cinder/tests/integrated/test_volumes.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"cb913dc88ebcf4c5825c79369a63b1c582ee895a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                break"},{"line_number":82,"context_line":"        return found_volume"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @testtools.skip(\u0027This test is failing: bug 1173266\u0027)"},{"line_number":85,"context_line":"    def test_create_and_delete_volume(self):"},{"line_number":86,"context_line":"        \"\"\"Creates and deletes a volume.\"\"\""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2Fruw%3D","line":84,"updated":"2013-05-27 09:13:21.000000000","message":"Is moving to testr exposing this bug, which was passing silently previously? If yes, maybe it needs a mention in the commit message.","commit_id":"2bb3ca14c92f153969114f9a590837618bcf8265"}],"cinder/tests/test_backup.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"3898751f2be73ada7fd73e989e8a63065aa8ead0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import tempfile"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import context"},{"line_number":25,"context_line":"from cinder import db"},{"line_number":26,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fgzw%3D","line":23,"updated":"2013-05-31 14:20:30.000000000","message":"Can you amend the commit message to explain why re-ordering the imports is necessary, please?","commit_id":"1effd35e6f599ee5cdc0a0e794637cf8ab6bbcbc"},{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"cfdc21a921015e5ffee1df9b3248bef49d20cc29","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import tempfile"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from cinder import context"},{"line_number":25,"context_line":"from cinder import db"},{"line_number":26,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fgv0%3D","line":23,"in_reply_to":"AAAAPH%2F%2Fgzw%3D","updated":"2013-05-31 14:36:02.000000000","message":"I was getting errors importing certain modules because \u0027_\u0027 symbol used for localization wasn\u0027t defined. I put a dummy _ in cinder.test and made this change where necessary.\n\nI must of gotten this error early in my development of this, and kept it around assuming that it still did something. I have reverted this part of the change and everything still works. I will upload a new patch.","commit_id":"1effd35e6f599ee5cdc0a0e794637cf8ab6bbcbc"}]}