)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b899ef128221c483924da13ffece06a6d8571c92","unresolved":false,"context_lines":[{"line_number":11,"context_line":"(cinder.volume.nfs.NfsDriver) and the NetApp NFS driver"},{"line_number":12,"context_line":"(cinder.volume.drivers.netapp.nfs.NetAppDirectCmodeNfsDriver). I believe"},{"line_number":13,"context_line":"that drivers based on distributed filesystem such as GlusterFS, nexenta"},{"line_number":14,"context_line":"and scality are also impacted however I didn\u0027t test it those backends."},{"line_number":15,"context_line":"However since most of them already inherit from the RemoteFsDriver"},{"line_number":16,"context_line":"class, this should be fine."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPH%2F%2FwgU%3D","line":14,"updated":"2013-05-23 18:39:54.000000000","message":"Suggest:  \"...I didn\u0027t test it on those backends.\"","commit_id":"729c37ce6452f78a3d45fa19c5bea26eac9b8bdd"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b899ef128221c483924da13ffece06a6d8571c92","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                                 self.local_path(volume))"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        # NOTE (leseb): Set the virtual size of the image"},{"line_number":127,"context_line":"        # the raw convertion overwrote the destination file"},{"line_number":128,"context_line":"        # (which had the correct size)"},{"line_number":129,"context_line":"        # with the fetched glance image size,"},{"line_number":130,"context_line":"        # thus the initial \u0027size\u0027 parameter is not honored"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fwf4%3D","line":127,"updated":"2013-05-23 18:39:54.000000000","message":"typo:  conversion instead of convertion","commit_id":"729c37ce6452f78a3d45fa19c5bea26eac9b8bdd"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b899ef128221c483924da13ffece06a6d8571c92","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        if virt_size !\u003d volume[\u0027size\u0027]:"},{"line_number":142,"context_line":"            raise exception.ImageUnacceptable("},{"line_number":143,"context_line":"                image_id\u003dimage_id,"},{"line_number":144,"context_line":"                reason\u003d_(\"Resize attempted, but size is now %s\") %"},{"line_number":145,"context_line":"                virt_size)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def copy_volume_to_image(self, context, volume, image_service, image_meta):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fwe0%3D","line":144,"updated":"2013-05-23 18:39:54.000000000","message":"This error message isn\u0027t really clear.  Might be helpful to have the expected size as compared to the result.","commit_id":"729c37ce6452f78a3d45fa19c5bea26eac9b8bdd"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"9beabee32966057e2af3f09d47450dfe713e25e9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from cinder import exception"},{"line_number":25,"context_line":"from cinder.image import image_utils"},{"line_number":26,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":27,"context_line":"from cinder import utils"},{"line_number":28,"context_line":"from cinder.volume import driver"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fryg%3D","line":27,"updated":"2013-05-27 08:40:43.000000000","message":"Import not used","commit_id":"0848618002c4f528ea58aada776d0207f0eed48d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3cf902f0d33bd3d448cf894af214d1748a209444","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        (in a hex format).\"\"\""},{"line_number":112,"context_line":"        return hashlib.md5(base_str).hexdigest()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def resize_image(self, source, size):"},{"line_number":115,"context_line":"        \"\"\"Changes the virtual size of the image\"\"\""},{"line_number":116,"context_line":"        cmd \u003d (\u0027qemu-img\u0027, \u0027resize\u0027, source, \u0027%sG\u0027 % size)"},{"line_number":117,"context_line":"        self._execute(*cmd, run_as_root\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FuTA%3D","line":114,"updated":"2013-05-24 13:21:21.000000000","message":"I think this function should be prefixed with a _","commit_id":"0848618002c4f528ea58aada776d0207f0eed48d"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"9beabee32966057e2af3f09d47450dfe713e25e9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        return hashlib.md5(base_str).hexdigest()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def resize_image(self, source, size):"},{"line_number":115,"context_line":"        \"\"\"Changes the virtual size of the image\"\"\""},{"line_number":116,"context_line":"        cmd \u003d (\u0027qemu-img\u0027, \u0027resize\u0027, source, \u0027%sG\u0027 % size)"},{"line_number":117,"context_line":"        self._execute(*cmd, run_as_root\u003dFalse)"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fryw%3D","line":115,"updated":"2013-05-27 08:40:43.000000000","message":"Period at end of docstring","commit_id":"0848618002c4f528ea58aada776d0207f0eed48d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3cf902f0d33bd3d448cf894af214d1748a209444","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        GB \u003d MB * 1024"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d image_utils.qemu_img_info(self.local_path(volume))"},{"line_number":140,"context_line":"        virt_size \u003d data.virtual_size / GB"},{"line_number":141,"context_line":"        if virt_size !\u003d volume[\u0027size\u0027]:"},{"line_number":142,"context_line":"            raise exception.ImageUnacceptable("},{"line_number":143,"context_line":"                image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FuUE%3D","line":140,"updated":"2013-05-24 13:21:21.000000000","message":"GB could be replaced by 1024 ** 3 to reduce code size :)\nOther cinder code already use this shorcut.","commit_id":"0848618002c4f528ea58aada776d0207f0eed48d"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"9beabee32966057e2af3f09d47450dfe713e25e9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        GB \u003d MB * 1024"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d image_utils.qemu_img_info(self.local_path(volume))"},{"line_number":140,"context_line":"        virt_size \u003d data.virtual_size / GB"},{"line_number":141,"context_line":"        if virt_size !\u003d volume[\u0027size\u0027]:"},{"line_number":142,"context_line":"            raise exception.ImageUnacceptable("},{"line_number":143,"context_line":"                image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fry4%3D","line":140,"in_reply_to":"AAAAPH%2F%2FuQs%3D","updated":"2013-05-27 08:40:43.000000000","message":"Better: use the constants from newly added cinder/units.py file","commit_id":"0848618002c4f528ea58aada776d0207f0eed48d"},{"author":{"_account_id":6984,"name":"Sébastien Han","email":"seb@redhat.com","username":"leseb"},"change_message_id":"14c11d99b81a35cfdce86058dbf090816c7cde10","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        GB \u003d MB * 1024"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d image_utils.qemu_img_info(self.local_path(volume))"},{"line_number":140,"context_line":"        virt_size \u003d data.virtual_size / GB"},{"line_number":141,"context_line":"        if virt_size !\u003d volume[\u0027size\u0027]:"},{"line_number":142,"context_line":"            raise exception.ImageUnacceptable("},{"line_number":143,"context_line":"                image_id\u003dimage_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FuQs%3D","line":140,"in_reply_to":"AAAAPH%2F%2FuUE%3D","updated":"2013-05-24 14:37:57.000000000","message":"Ok thanks for the input, I simply re-use from the _create method. But it makes sense to make this change.","commit_id":"0848618002c4f528ea58aada776d0207f0eed48d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"59b43d88ade20361216175203a3f28d3b4d369af","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        \"\"\"Changes the virtual size of the image.\"\"\""},{"line_number":120,"context_line":"        cmd \u003d (\u0027qemu-img\u0027, \u0027resize\u0027, source, \u0027%sG\u0027 % size)"},{"line_number":121,"context_line":"        self._execute(*cmd, run_as_root\u003dFalse)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def copy_image_to_volume(self, context, volume, image_service, image_id):"},{"line_number":124,"context_line":"        \"\"\"Fetch the image from image_service and write it to the volume.\"\"\""},{"line_number":125,"context_line":"        image_utils.fetch_to_raw(context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fejs%3D","line":122,"updated":"2013-06-02 15:31:17.000000000","message":"why not implement a resize method in image-utils rather than call qemu direct here?","commit_id":"ae2d0594079d4251b95742acbb5f80549947769a"}]}