)]}'
{"cinder/scheduler/filters/capabilities_filter.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"001b305fb389c19800f43be8449f65feb0ce7f3c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        if not extra_specs:"},{"line_number":35,"context_line":"            return True"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        for key, req in iter(extra_specs.items()):"},{"line_number":38,"context_line":"            # Either not scope format, or in capabilities scope"},{"line_number":39,"context_line":"            scope \u003d key.split(\u0027:\u0027)"},{"line_number":40,"context_line":"            if len(scope) \u003e 1 and scope[0] !\u003d \"capabilities\":"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_b2152a41","line":37,"range":{"start_line":37,"start_character":24,"end_line":37,"end_character":48},"updated":"2016-06-24 09:43:54.000000000","message":"-1: This is not the same thing, since in Python2 you are creating a list and then wrapping it with iter.  If you are going to use .items() -as it was agreed some time ago in the ML- then you don\u0027t need to add the iter, since in Python 2 and 3 returned value is already an iterable.","commit_id":"665f5b87137b6709e09e0b5dcd8d5bf732de1cc6"}],"cinder/tests/unit/scheduler/fake_hosts.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"001b305fb389c19800f43be8449f65feb0ce7f3c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"class FakeHostState(object):"},{"line_number":48,"context_line":"    def __init__(self, host, attribute_dict):"},{"line_number":49,"context_line":"        self.host \u003d host"},{"line_number":50,"context_line":"        for (key, val) in iter(attribute_dict.items()):"},{"line_number":51,"context_line":"            setattr(self, key, val)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_72074218","line":50,"range":{"start_line":50,"start_character":26,"end_line":50,"end_character":53},"updated":"2016-06-24 09:43:54.000000000","message":"-1: This is not the same thing, since in Python2 you are creating a list and then wrapping it with iter.  If you are going to use .items() -as it was agreed some time ago in the ML- then you don\u0027t need to add the iter, since in Python 2 and 3 returned value is already an iterable.","commit_id":"665f5b87137b6709e09e0b5dcd8d5bf732de1cc6"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"001b305fb389c19800f43be8449f65feb0ce7f3c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        if isinstance(obj, dict):"},{"line_number":73,"context_line":"            items \u003d obj.items()"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            items \u003d iter(obj.items())"},{"line_number":76,"context_line":"        return {k: v for k, v in items"},{"line_number":77,"context_line":"                if k not in ignored_keys}"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_0c422868","line":75,"range":{"start_line":75,"start_character":20,"end_line":75,"end_character":37},"updated":"2016-06-24 09:43:54.000000000","message":"-1: This is wrong, it should be obj.iteritems() as it was, since it\u0027s not referring to a dict\u0027s iteritems method as that\u0027s covered by L73.","commit_id":"665f5b87137b6709e09e0b5dcd8d5bf732de1cc6"}],"cinder/volume/drivers/vmware/volumeops.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"001b305fb389c19800f43be8449f65feb0ce7f3c","unresolved":false,"context_lines":[{"line_number":735,"context_line":"        cf \u003d self._session.vim.client.factory"},{"line_number":736,"context_line":"        option_values \u003d []"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":"        for key, value in iter(extra_config.items()):"},{"line_number":739,"context_line":"            opt \u003d cf.create(\u0027ns0:OptionValue\u0027)"},{"line_number":740,"context_line":"            opt.key \u003d key"},{"line_number":741,"context_line":"            opt.value \u003d value"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_cc9660ef","line":738,"range":{"start_line":738,"start_character":26,"end_line":738,"end_character":52},"updated":"2016-06-24 09:43:54.000000000","message":"-1: This is not the same thing, since in Python2 you are creating a list and then wrapping it with iter.  If you are going to use .items() -as it was agreed some time ago in the ML- then you don\u0027t need to add the iter, since in Python 2 and 3 returned value is already an iterable.","commit_id":"665f5b87137b6709e09e0b5dcd8d5bf732de1cc6"}]}
