)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"f810b7fac8a1263d8c7420e75a4bb87cd9d246d5","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset will add details in output of type-access-add"},{"line_number":14,"context_line":"operation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I34dadff808622fe4a65b8e7c0ceda6212f0b7ac8"},{"line_number":17,"context_line":"Closes-Bug:#1567376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_7f93f14f","line":15,"updated":"2016-04-09 07:51:39.000000000","message":"Do we need a \"APIImpact\" here？","commit_id":"e859fdd53220b648ca1b45870892836727ddc755"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd302beba20ed3ca090a17e22d3c2020e888c91e","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patchset will add details in output of type-access-add"},{"line_number":14,"context_line":"operation."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I34dadff808622fe4a65b8e7c0ceda6212f0b7ac8"},{"line_number":17,"context_line":"Closes-Bug:#1567376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_1a53786c","line":15,"in_reply_to":"9a061dce_7f93f14f","updated":"2016-05-31 20:27:09.000000000","message":"Yes this should have an API Impact I believe.","commit_id":"e859fdd53220b648ca1b45870892836727ddc755"}],"cinder/api/contrib/volume_type_access.py":[{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"f810b7fac8a1263d8c7420e75a4bb87cd9d246d5","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        except exception.VolumeTypeNotFound as err:"},{"line_number":177,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dsix.text_type(err))"},{"line_number":178,"context_line":"        return {"},{"line_number":179,"context_line":"            \u0027volume_type_id\u0027: volume_type[\u0027id\u0027],"},{"line_number":180,"context_line":"            \u0027project_id\u0027: project"},{"line_number":181,"context_line":"        }"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_1fd115fc","line":179,"range":{"start_line":179,"start_character":30,"end_line":179,"end_character":47},"updated":"2016-04-09 07:51:39.000000000","message":"Looks like there is is a trend[1] to use \"volume_type.id\" rather than this.\nCan we use volume_type.id here?\n\n[1]: https://review.openstack.org/#/c/300708/","commit_id":"e859fdd53220b648ca1b45870892836727ddc755"}],"cinder/tests/unit/api/contrib/test_volume_type_access.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fd302beba20ed3ca090a17e22d3c2020e888c91e","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types/2/action\u0027,"},{"line_number":268,"context_line":"                                      use_admin_context\u003dTrue)"},{"line_number":269,"context_line":"        result \u003d self.type_action_controller._addProjectAccess(req, \u00273\u0027, body)"},{"line_number":270,"context_line":"        self.assertTrue(result)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_add_project_access_with_no_admin_user(self):"},{"line_number":273,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types/2/action\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_9a9be817","line":270,"updated":"2016-05-31 20:27:09.000000000","message":"Do you also want to to check the values being returned? Assert they are equal to what you\u0027d expect are being returned?","commit_id":"e859fdd53220b648ca1b45870892836727ddc755"}]}