)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"e40f6a24c6a59ffa379c03717fe5ce45d90a0bb9","unresolved":false,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if qos:"},{"line_number":321,"context_line":"            for k, v in qos.items():"},{"line_number":322,"context_line":"                            attributes[k] \u003d str(v)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        params \u003d {\u0027volumeID\u0027: int(sf_vol[\u0027volumeID\u0027]),"},{"line_number":325,"context_line":"                  \u0027name\u0027: \u0027UUID-%s\u0027 % v_ref[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fu90%3D","line":322,"updated":"2013-05-24 06:32:59.000000000","message":"Here you fill \u0027attributes\u0027...","commit_id":"02e2c463554a81eed1755cd50c385cef77df2a9d"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"e40f6a24c6a59ffa379c03717fe5ce45d90a0bb9","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        # NOTE(jdg): all attributes are copied via clone, need to do an update"},{"line_number":335,"context_line":"        # to set any that were provided"},{"line_number":336,"context_line":"        attributes \u003d {\u0027uuid\u0027: v_ref[\u0027id\u0027],"},{"line_number":337,"context_line":"                      \u0027is_clone\u0027: \u0027True\u0027,"},{"line_number":338,"context_line":"                      \u0027src_uuid\u0027: src_uuid}"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fu9w%3D","line":336,"updated":"2013-05-24 06:32:59.000000000","message":"...and here you overwrite.  On purpose?","commit_id":"02e2c463554a81eed1755cd50c385cef77df2a9d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"86a8f92c49887a41f43156df4de2ae21afd97fd9","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        # NOTE(jdg): all attributes are copied via clone, need to do an update"},{"line_number":335,"context_line":"        # to set any that were provided"},{"line_number":336,"context_line":"        attributes \u003d {\u0027uuid\u0027: v_ref[\u0027id\u0027],"},{"line_number":337,"context_line":"                      \u0027is_clone\u0027: \u0027True\u0027,"},{"line_number":338,"context_line":"                      \u0027src_uuid\u0027: src_uuid}"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FuFE%3D","line":336,"in_reply_to":"AAAAPH%2F%2Fu9w%3D","updated":"2013-05-24 15:05:49.000000000","message":"Yep, that\u0027s completely intentional, except to be honest there\u0027s no reason/need to even populate them any longer up above.  I used to use them on the CloneVolume call, but they\u0027re ignored on clone operations and need to be set after the fact (as I\u0027m doing below).  I also decided that I wasn\u0027t sure of the value in setting the qos in the extra attributes meta.\n\nI\u0027ll remove the section above.","commit_id":"02e2c463554a81eed1755cd50c385cef77df2a9d"}]}