)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"1e41a9230eb05820d4c89ae957eb7bf3b416e50e","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        # to set any that were provided"},{"line_number":339,"context_line":"        if qos:"},{"line_number":340,"context_line":"            params[\u0027qos\u0027] \u003d qos"},{"line_number":341,"context_line":"        elif \u0027qos\u0027 in sf_vol:"},{"line_number":342,"context_line":"            qos \u003d sf_vol[\u0027qos\u0027]"},{"line_number":343,"context_line":"        if qos:"},{"line_number":344,"context_line":"            for k, v in qos.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FsPE%3D","line":341,"updated":"2013-05-26 17:41:05.000000000","message":"How is this different than the check on line 334?","commit_id":"ebadd4bdbe28d4c726cb89aaabf40f1fdf71d871"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"352c66792f6a2eb4162ecb7585387c836c7e3bdc","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        # to set any that were provided"},{"line_number":339,"context_line":"        if qos:"},{"line_number":340,"context_line":"            params[\u0027qos\u0027] \u003d qos"},{"line_number":341,"context_line":"        elif \u0027qos\u0027 in sf_vol:"},{"line_number":342,"context_line":"            qos \u003d sf_vol[\u0027qos\u0027]"},{"line_number":343,"context_line":"        if qos:"},{"line_number":344,"context_line":"            for k, v in qos.items():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Frzc%3D","line":341,"in_reply_to":"AAAAPH%2F%2FsPE%3D","updated":"2013-05-27 08:53:30.000000000","message":"The logic seems to be \u0027if _set_qos_by_volume_type() returned None, then take \u0027qos\u0027 from sf_vol. Whereas 334 says if \u0027type_id\u0027 is None then take \u0027qos\u0027 from sf_vol. \nBut I don\u0027t understand why  params is not set in all cases.","commit_id":"ebadd4bdbe28d4c726cb89aaabf40f1fdf71d871"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"352c66792f6a2eb4162ecb7585387c836c7e3bdc","unresolved":false,"context_lines":[{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        attributes \u003d {\u0027uuid\u0027: v_ref[\u0027id\u0027],"},{"line_number":348,"context_line":"                      \u0027is_clone\u0027: \u0027True\u0027,"},{"line_number":349,"context_line":"                      \u0027src_uuid\u0027: src_uuid}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        params \u003d {\u0027volumeID\u0027: sf_volume_id,"},{"line_number":352,"context_line":"                  \u0027attributes\u0027: attributes}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fry0%3D","line":349,"updated":"2013-05-27 08:53:30.000000000","message":"Won\u0027t this assigment overwrite the assigment to attributes at line 345?","commit_id":"ebadd4bdbe28d4c726cb89aaabf40f1fdf71d871"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"352c66792f6a2eb4162ecb7585387c836c7e3bdc","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                      \u0027src_uuid\u0027: src_uuid}"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        params \u003d {\u0027volumeID\u0027: sf_volume_id,"},{"line_number":352,"context_line":"                  \u0027attributes\u0027: attributes}"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        data \u003d self._issue_api_request(\u0027ModifyVolume\u0027, params)"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FrzU%3D","line":352,"updated":"2013-05-27 08:53:30.000000000","message":"Won\u0027t this assignment to params will overwrite the \u0027qos\u0027 element of params assigned at line 340?","commit_id":"ebadd4bdbe28d4c726cb89aaabf40f1fdf71d871"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"080cc9ee24ba829be352a0abb38d83225fd9f68e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 Justin Santa Barbara"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fq%2B8%3D","line":2,"updated":"2013-05-28 02:45:18.000000000","message":"Just a thought, maybe you want to change this?","commit_id":"37fa1ef51ef389ed7ac0affb1dd59ba680ca52df"}]}