)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f16a3bc5cece3824ba72251da54c72290f6fe48e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xu Ao \u003cxuao@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-18 16:49:03 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repalce funcs List.get then del with just List.pop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change these:"},{"line_number":10,"context_line":"        if \u0027name\u0027 in volume:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_61ca2a70","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2016-04-18 09:27:34.000000000","message":"s/Repalce/Replace","commit_id":"6040320d07f953693277044d3492562749889e1d"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"8dd428a53c57603d41ab8f5c63f960377f1509e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xu Ao \u003cxuao@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-18 16:49:03 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repalce funcs List.get then del with just List.pop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change these:"},{"line_number":10,"context_line":"        if \u0027name\u0027 in volume:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_c456acd1","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":22},"updated":"2016-04-18 09:39:49.000000000","message":"volume is a dictionary and not a list here.","commit_id":"6040320d07f953693277044d3492562749889e1d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f16a3bc5cece3824ba72251da54c72290f6fe48e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xu Ao \u003cxuao@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-18 16:49:03 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repalce funcs List.get then del with just List.pop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change these:"},{"line_number":10,"context_line":"        if \u0027name\u0027 in volume:"},{"line_number":11,"context_line":"            volume[\u0027display_name\u0027] \u003d volume.pop(\u0027name\u0027)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        # NOTE(thingee): v2 API allows description instead of"},{"line_number":14,"context_line":"        # display_description"},{"line_number":15,"context_line":"        if \u0027description\u0027 in volume:"},{"line_number":16,"context_line":"            volume[\u0027display_description\u0027] \u003d volume.pop(\u0027description\u0027)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        if \u0027image_id\u0027 in volume:"},{"line_number":19,"context_line":"            volume[\u0027imageRef\u0027] \u003d volume.get(\u0027image_id\u0027)"},{"line_number":20,"context_line":"            del volume[\u0027image_id\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"into:"},{"line_number":23,"context_line":"        if \u0027name\u0027 in volume:"},{"line_number":24,"context_line":"            volume[\u0027display_name\u0027] \u003d volume.pop(\u0027name\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # NOTE(thingee): v2 API allows description instead of"},{"line_number":27,"context_line":"        # display_description"},{"line_number":28,"context_line":"        if \u0027description\u0027 in volume:"},{"line_number":29,"context_line":"            volume[\u0027display_description\u0027] \u003d volume.pop(\u0027description\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        if \u0027image_id\u0027 in volume:"},{"line_number":32,"context_line":"            volume[\u0027imageRef\u0027] \u003d volume.pop(\u0027image_id\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: Ic889dac330eac24d15bd73186fc504402cddd861"},{"line_number":35,"context_line":"Closes-Bug:#1571548"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_a1a9e27d","line":32,"range":{"start_line":7,"start_character":0,"end_line":32,"end_character":55},"updated":"2016-04-18 09:27:34.000000000","message":"Please don\u0027t include diffs in the commit message, it isn\u0027t a good practice. You can describe why you want to do such change instead.","commit_id":"6040320d07f953693277044d3492562749889e1d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f16a3bc5cece3824ba72251da54c72290f6fe48e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            volume[\u0027imageRef\u0027] \u003d volume.pop(\u0027image_id\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: Ic889dac330eac24d15bd73186fc504402cddd861"},{"line_number":35,"context_line":"Closes-Bug:#1571548"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_c11b3e1a","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":19},"updated":"2016-04-18 09:27:34.000000000","message":"It\u0027s not a valid bug, please remove this line.","commit_id":"6040320d07f953693277044d3492562749889e1d"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"8dd428a53c57603d41ab8f5c63f960377f1509e4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            volume[\u0027imageRef\u0027] \u003d volume.pop(\u0027image_id\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: Ic889dac330eac24d15bd73186fc504402cddd861"},{"line_number":35,"context_line":"Closes-Bug:#1571548"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_84faf4bb","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":19},"in_reply_to":"1a122d0e_c11b3e1a","updated":"2016-04-18 09:39:49.000000000","message":"Agreed, can add a TrivialFix tag instead","commit_id":"6040320d07f953693277044d3492562749889e1d"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c229206fe163249ecbb3783b5d09ef36e6bee8ea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xu Ao \u003cxuao@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-14 11:45:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repalce funcs List.get then del with just List.pop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change these:"},{"line_number":10,"context_line":"        if \u0027name\u0027 in volume:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_5fa209fd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2016-05-16 19:29:04.000000000","message":"Repalce-\u003e Replace\n\nSuggest: \u0027Replace list.get functions with list.pop\u0027","commit_id":"b4b209afacd18ac8200df3f9010cffc61970aff2"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"c229206fe163249ecbb3783b5d09ef36e6bee8ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repalce funcs List.get then del with just List.pop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change these:"},{"line_number":10,"context_line":"        if \u0027name\u0027 in volume:"},{"line_number":11,"context_line":"            volume[\u0027display_name\u0027] \u003d volume.pop(\u0027name\u0027)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"        # NOTE(thingee): v2 API allows description instead of"},{"line_number":14,"context_line":"        # display_description"},{"line_number":15,"context_line":"        if \u0027description\u0027 in volume:"},{"line_number":16,"context_line":"            volume[\u0027display_description\u0027] \u003d volume.pop(\u0027description\u0027)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        if \u0027image_id\u0027 in volume:"},{"line_number":19,"context_line":"            volume[\u0027imageRef\u0027] \u003d volume.get(\u0027image_id\u0027)"},{"line_number":20,"context_line":"            del volume[\u0027image_id\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"into:"},{"line_number":23,"context_line":"        if \u0027name\u0027 in volume:"},{"line_number":24,"context_line":"            volume[\u0027display_name\u0027] \u003d volume.pop(\u0027name\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"        # NOTE(thingee): v2 API allows description instead of"},{"line_number":27,"context_line":"        # display_description"},{"line_number":28,"context_line":"        if \u0027description\u0027 in volume:"},{"line_number":29,"context_line":"            volume[\u0027display_description\u0027] \u003d volume.pop(\u0027description\u0027)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        if \u0027image_id\u0027 in volume:"},{"line_number":32,"context_line":"            volume[\u0027imageRef\u0027] \u003d volume.pop(\u0027image_id\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: Ic889dac330eac24d15bd73186fc504402cddd861"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_1f836157","line":31,"range":{"start_line":9,"start_character":0,"end_line":31,"end_character":32},"updated":"2016-05-16 19:29:04.000000000","message":"You don\u0027t need to put the code changes here as well. The body is just meant to give a description of the problem and how you will fix it.","commit_id":"b4b209afacd18ac8200df3f9010cffc61970aff2"},{"author":{"_account_id":20140,"name":"Karthik Prabhu Vinod","email":"karthik.prabhu.vinod@intel.com","username":"kprabhuv"},"change_message_id":"fc3620057eb183d4c7885e302294640cfd8c2dc0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xu Ao \u003cxuao@awcloud.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-25 14:59:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Repalce funcs Dict.get and del with just Dict.pop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to giving the codes a format that carries through."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_417d56b0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2016-07-25 15:42:50.000000000","message":"type: Replace","commit_id":"91aafc736b40b216fe2b44c278299bde9e608719"}],"cinder/api/v2/snapshots.py":[{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"46c3e848bee99447df563d308f2e3d39f042c501","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                            allowed_search_options)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        # NOTE(thingee): v2 API allows name instead of display_name"},{"line_number":96,"context_line":"        if \u0027name\u0027 in search_opts:"},{"line_number":97,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        snapshots \u003d self.volume_api.get_all_snapshots(context,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_b3ff4366","line":96,"updated":"2016-07-29 07:22:28.000000000","message":"You could have optimized it by removing if statement.\nsearch_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027, None)\nThis will return None if \u0027name\u0027 not found in dict.\n\nCorrect me if I am wrong!","commit_id":"dced19aec3cdae8629097677271c61e0f4fb9a6a"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"90d486cc61acbc204e6cb2f06ca511336b5bb094","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if \u0027name\u0027 in sort_keys:"},{"line_number":109,"context_line":"            sort_keys[sort_keys.index(\u0027name\u0027)] \u003d \u0027display_name\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if \u0027name\u0027 in filters:"},{"line_number":112,"context_line":"            filters[\u0027display_name\u0027] \u003d filters[\u0027name\u0027]"},{"line_number":113,"context_line":"            del filters[\u0027name\u0027]"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        self.volume_api.check_volume_filters(filters)"},{"line_number":116,"context_line":"        volumes \u003d self.volume_api.get_all(context, marker, limit,"}],"source_content_type":"text/x-python","patch_set":8,"id":"dada55a8_394b1f89","line":113,"range":{"start_line":111,"start_character":0,"end_line":113,"end_character":31},"updated":"2016-07-26 02:22:58.000000000","message":"Could you please fix it as well?","commit_id":"95d32eb39a396ab129b0fb7bb3dfbce61bc3a315"}]}