)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b305f56f4665f625164f01e5e21d5731871efbb8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Link VOs with their list counterparts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Out Vesioned Objects are not in sync with their ObjectList counterparts,"},{"line_number":10,"context_line":"which means that whenever we send a list of Versioned Objects over RPC"},{"line_number":11,"context_line":"we are performing unnecessary backports of those objects, potentially"},{"line_number":12,"context_line":"removing necessary fields and generating extra DB queries or running RPC"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_08aab385","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":12},"updated":"2016-04-21 15:11:06.000000000","message":"Versioned","commit_id":"2154f52121a00baf911cdc77b819c7a031a13ab5"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"68a9ef57e7812ba288cc92cbe78d80e7438cf2f8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Link VOs with their list counterparts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Out Versioned Objects are not in sync with their ObjectList"},{"line_number":10,"context_line":"counterparts, which means that whenever we send a list of Versioned"},{"line_number":11,"context_line":"Objects over RPC we are performing unnecessary backports of those"},{"line_number":12,"context_line":"objects, potentially removing necessary fields and generating extra DB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bab6814e_1e4ed83a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"updated":"2016-05-20 13:57:12.000000000","message":"s/Out/Our\n\nI think? ;)","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b95687953df779e5dbd84129960b0cf2dbca10d0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Link VOs with their list counterparts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Out Versioned Objects are not in sync with their ObjectList"},{"line_number":10,"context_line":"counterparts, which means that whenever we send a list of Versioned"},{"line_number":11,"context_line":"Objects over RPC we are performing unnecessary backports of those"},{"line_number":12,"context_line":"objects, potentially removing necessary fields and generating extra DB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bab6814e_d0a1d8f9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"in_reply_to":"bab6814e_1e4ed83a","updated":"2016-05-20 14:27:56.000000000","message":"Yep, yep.  :-)","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"}],"cinder/objects/backup.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"68a9ef57e7812ba288cc92cbe78d80e7438cf2f8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    # Version 1.2: Add new field snapshot_id and data_timestamp."},{"line_number":40,"context_line":"    # Version 1.3: Changed \u0027status\u0027 field to use BackupStatusField"},{"line_number":41,"context_line":"    # Version 1.4: Add restore_volume_id"},{"line_number":42,"context_line":"    # Version 1.5: Sync version with BackupList"},{"line_number":43,"context_line":"    VERSION \u003d \u00271.5\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_5e9220f7","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":19},"updated":"2016-05-20 13:57:12.000000000","message":"Why we\u0027re adding a new version? Can\u0027t we just switch BackupList to 1.4?","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b95687953df779e5dbd84129960b0cf2dbca10d0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    # Version 1.2: Add new field snapshot_id and data_timestamp."},{"line_number":40,"context_line":"    # Version 1.3: Changed \u0027status\u0027 field to use BackupStatusField"},{"line_number":41,"context_line":"    # Version 1.4: Add restore_volume_id"},{"line_number":42,"context_line":"    # Version 1.5: Sync version with BackupList"},{"line_number":43,"context_line":"    VERSION \u003d \u00271.5\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    fields \u003d {"},{"line_number":46,"context_line":"        \u0027id\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_b049b462","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":19},"in_reply_to":"bab6814e_5e9220f7","updated":"2016-05-20 14:27:56.000000000","message":"Yes we can.  Originally I wanted to create new versions for all objects that were not synced to mark them that they were wrong, but I really don\u0027t care anymore.","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"68a9ef57e7812ba288cc92cbe78d80e7438cf2f8","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    child_versions \u003d {"},{"line_number":172,"context_line":"        \u00271.0\u0027: \u00271.1\u0027,"},{"line_number":173,"context_line":"        \u00271.4\u0027: \u00271.4\u0027,"},{"line_number":174,"context_line":"    }"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_1eb37899","line":173,"updated":"2016-05-20 13:57:12.000000000","message":"Is 1.5 missing here?","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"}],"cinder/objects/consistencygroup.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"68a9ef57e7812ba288cc92cbe78d80e7438cf2f8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # Version 1.0: Initial version"},{"line_number":30,"context_line":"    # Version 1.1: Added cgsnapshots and volumes relationships"},{"line_number":31,"context_line":"    # Version 1.2: Changed \u0027status\u0027 field to use ConsistencyGroupStatusField"},{"line_number":32,"context_line":"    # Version 1.3: Sync version with ConsistencyGroupList"},{"line_number":33,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_7e6a84ef","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":57},"updated":"2016-05-20 13:57:12.000000000","message":"Why do we need new version?","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b95687953df779e5dbd84129960b0cf2dbca10d0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    # Version 1.0: Initial version"},{"line_number":30,"context_line":"    # Version 1.1: Added cgsnapshots and volumes relationships"},{"line_number":31,"context_line":"    # Version 1.2: Changed \u0027status\u0027 field to use ConsistencyGroupStatusField"},{"line_number":32,"context_line":"    # Version 1.3: Sync version with ConsistencyGroupList"},{"line_number":33,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_f0d17c58","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":57},"in_reply_to":"bab6814e_7e6a84ef","updated":"2016-05-20 14:27:56.000000000","message":"Same reason as the other file, but I\u0027ll just change the patch to reduce the number of version bumps.","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"}],"cinder/objects/service.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"68a9ef57e7812ba288cc92cbe78d80e7438cf2f8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # Version 1.1: Add rpc_current_version and object_current_version fields"},{"line_number":35,"context_line":"    # Version 1.2: Add get_minimum_rpc_version() and get_minimum_obj_version()"},{"line_number":36,"context_line":"    # Version 1.3: Add replication fields"},{"line_number":37,"context_line":"    # Version 1.4: Sync version with ServiceList"},{"line_number":38,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_fe7674d5","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":48},"updated":"2016-05-20 13:57:12.000000000","message":"ditto","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b95687953df779e5dbd84129960b0cf2dbca10d0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # Version 1.1: Add rpc_current_version and object_current_version fields"},{"line_number":35,"context_line":"    # Version 1.2: Add get_minimum_rpc_version() and get_minimum_obj_version()"},{"line_number":36,"context_line":"    # Version 1.3: Add replication fields"},{"line_number":37,"context_line":"    # Version 1.4: Sync version with ServiceList"},{"line_number":38,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_70c62c9b","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":48},"in_reply_to":"bab6814e_fe7674d5","updated":"2016-05-20 14:27:56.000000000","message":"Will reduce version bumps.","commit_id":"1181bcbf73ce0852d6b849210c4d2e747f4d8542"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ea33aca3d10bb4e09f531c7f21d7149095d76bc2","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Service\u0027),"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"    child_versions \u003d {"},{"line_number":149,"context_line":"        \u00271.0\u0027: \u00271.0\u0027,"},{"line_number":150,"context_line":"        \u00271.1\u0027: \u00271.2\u0027,"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @base.remotable_classmethod"},{"line_number":154,"context_line":"    def get_all(cls, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_c28fd9ca","line":151,"range":{"start_line":148,"start_character":0,"end_line":151,"end_character":5},"updated":"2016-05-24 09:53:35.000000000","message":"I think you\u0027re missing a version bump here, but since we don\u0027t send this one over RPC, I\u0027m fine with that.","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"93cb5f8447359f5e7507661eeedf7efec3ae58be","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Service\u0027),"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"    child_versions \u003d {"},{"line_number":149,"context_line":"        \u00271.0\u0027: \u00271.0\u0027,"},{"line_number":150,"context_line":"        \u00271.1\u0027: \u00271.2\u0027,"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @base.remotable_classmethod"},{"line_number":154,"context_line":"    def get_all(cls, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_17b0c1dc","line":151,"range":{"start_line":148,"start_character":0,"end_line":151,"end_character":5},"in_reply_to":"bab6814e_a41a6515","updated":"2016-05-25 09:19:52.000000000","message":"LisaLi is correct, as explained in the commit message of the next patch of the series.","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"d8c4ee29e943f5d4170cb20c2ad4b1dd5e8cdd3b","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Service\u0027),"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"    child_versions \u003d {"},{"line_number":149,"context_line":"        \u00271.0\u0027: \u00271.0\u0027,"},{"line_number":150,"context_line":"        \u00271.1\u0027: \u00271.2\u0027,"},{"line_number":151,"context_line":"    }"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @base.remotable_classmethod"},{"line_number":154,"context_line":"    def get_all(cls, context, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_a41a6515","line":151,"range":{"start_line":148,"start_character":0,"end_line":151,"end_character":5},"in_reply_to":"bab6814e_c28fd9ca","updated":"2016-05-25 08:56:37.000000000","message":"My understanding is: If \u00271.3\u0027: \u00271.3\u0027 is not added into child_versions, in future when a ServiceList object with version 1.4 is backported to 1.3, its Service object will be backported to version 1.2. \n\n\nhttps://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L1126-L1136","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"}],"cinder/objects/snapshot.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ea33aca3d10bb4e09f531c7f21d7149095d76bc2","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    fields \u003d {"},{"line_number":230,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Snapshot\u0027),"},{"line_number":231,"context_line":"    }"},{"line_number":232,"context_line":"    child_versions \u003d {"},{"line_number":233,"context_line":"        \u00271.0\u0027: \u00271.0\u0027"},{"line_number":234,"context_line":"    }"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @base.remotable_classmethod"},{"line_number":237,"context_line":"    def get_all(cls, context, search_opts, marker\u003dNone, limit\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_1d7302b6","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":5},"updated":"2016-05-24 09:53:35.000000000","message":"Here bump is missing and in this case we\u0027re probably sending it inside Volume or CGSnapshot?","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"93cb5f8447359f5e7507661eeedf7efec3ae58be","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    fields \u003d {"},{"line_number":230,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Snapshot\u0027),"},{"line_number":231,"context_line":"    }"},{"line_number":232,"context_line":"    child_versions \u003d {"},{"line_number":233,"context_line":"        \u00271.0\u0027: \u00271.0\u0027"},{"line_number":234,"context_line":"    }"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @base.remotable_classmethod"},{"line_number":237,"context_line":"    def get_all(cls, context, search_opts, marker\u003dNone, limit\u003dNone,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_f7009d68","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":5},"in_reply_to":"bab6814e_1d7302b6","updated":"2016-05-25 09:19:52.000000000","message":"We don\u0027t really require a bump here as well, because v1.1 List will send v1.0 Snapshot objects, which are the same as v1.0 (there shouldn\u0027t have been a version bump there)","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"}],"cinder/objects/volume.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"4f0df28bb6287389921ad617c1553c1c19e9ccb1","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \u0027snapshots\u0027: fields.ObjectField(\u0027SnapshotList\u0027, nullable\u003dTrue),"},{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    obj_relationships \u003d {"},{"line_number":122,"context_line":"        \u0027volume_type\u0027: ((\u00271.3\u0027, \u00271.0\u0027),),"},{"line_number":123,"context_line":"        \u0027volume_attachment\u0027: ((\u00271.3\u0027, \u00271.0\u0027),),"},{"line_number":124,"context_line":"        \u0027consistencygroup\u0027: ((\u00271.3\u0027, \u00271.2\u0027),),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_504b3f87","line":121,"updated":"2016-04-19 09:22:38.000000000","message":"`obj_relationships` seems never be used elsewhere. It is deleted in your next patch https://review.openstack.org/#/c/307075/, somewhat. That looks strange.","commit_id":"2154f52121a00baf911cdc77b819c7a031a13ab5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8100f4158a34384e738e1cb3938955a12eba0a8b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \u0027snapshots\u0027: fields.ObjectField(\u0027SnapshotList\u0027, nullable\u003dTrue),"},{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    obj_relationships \u003d {"},{"line_number":122,"context_line":"        \u0027volume_type\u0027: ((\u00271.3\u0027, \u00271.0\u0027),),"},{"line_number":123,"context_line":"        \u0027volume_attachment\u0027: ((\u00271.3\u0027, \u00271.0\u0027),),"},{"line_number":124,"context_line":"        \u0027consistencygroup\u0027: ((\u00271.3\u0027, \u00271.2\u0027),),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_9b07a617","line":121,"in_reply_to":"1a122d0e_504b3f87","updated":"2016-04-19 14:50:01.000000000","message":"We don\u0027t use it, but Oslo Versioned Object uses it for backporting, and if this is not included here we will get an exception on the gate (bug #1571566 that is fixed in the next patch), you can read more about these 2 bugs here: \n\nhttp://gorka.eguileor.com/learning-something-new-about-oslo-versioned-objects/ \n\nAnd you can see the error at the gate in previous patch here:\n\nhttp://logs.openstack.org/74/307074/1/check/gate-grenade-dsvm/9ee75c9/logs/new/screen-c-api.txt.gz#_2016-04-18_13_45_48_722\n\nAnd it is removed in the next patch because we have automated its creation.","commit_id":"2154f52121a00baf911cdc77b819c7a031a13ab5"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"8bff452dac4776ffe768eff1790642e11b18c8aa","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        \u0027snapshots\u0027: fields.ObjectField(\u0027SnapshotList\u0027, nullable\u003dTrue),"},{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    obj_relationships \u003d {"},{"line_number":122,"context_line":"        \u0027volume_type\u0027: ((\u00271.3\u0027, \u00271.0\u0027),),"},{"line_number":123,"context_line":"        \u0027volume_attachment\u0027: ((\u00271.3\u0027, \u00271.0\u0027),),"},{"line_number":124,"context_line":"        \u0027consistencygroup\u0027: ((\u00271.3\u0027, \u00271.2\u0027),),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f40f9634","line":121,"in_reply_to":"1a122d0e_9b07a617","updated":"2016-04-20 12:38:10.000000000","message":"Cool. LGTM now!","commit_id":"2154f52121a00baf911cdc77b819c7a031a13ab5"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"d8c4ee29e943f5d4170cb20c2ad4b1dd5e8cdd3b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \u0027consistencygroup\u0027: ((\u00271.3\u0027, \u00271.2\u0027),),"},{"line_number":124,"context_line":"        \u0027snapshots\u0027: ((\u00271.3\u0027, \u00271.1\u0027),),"},{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # NOTE(thangp): obj_extra_fields is used to hold properties that are not"},{"line_number":128,"context_line":"    # usually part of the model"},{"line_number":129,"context_line":"    obj_extra_fields \u003d [\u0027name\u0027, \u0027name_id\u0027, \u0027volume_metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_af036375","line":126,"updated":"2016-05-25 08:56:37.000000000","message":"I think we also need to add obj_relationships for object like Snapshot etc. Unless such fields will not transfer during RPC call. \n\nSnapshot has two objects field:\nVolume  and CGSnapshot","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"93cb5f8447359f5e7507661eeedf7efec3ae58be","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \u0027consistencygroup\u0027: ((\u00271.3\u0027, \u00271.2\u0027),),"},{"line_number":124,"context_line":"        \u0027snapshots\u0027: ((\u00271.3\u0027, \u00271.1\u0027),),"},{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # NOTE(thangp): obj_extra_fields is used to hold properties that are not"},{"line_number":128,"context_line":"    # usually part of the model"},{"line_number":129,"context_line":"    obj_extra_fields \u003d [\u0027name\u0027, \u0027name_id\u0027, \u0027volume_metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_d778f9fa","line":126,"in_reply_to":"bab6814e_af036375","updated":"2016-05-25 09:19:52.000000000","message":"I\u0027m not adding those because I am creating a mechanism in the next patch in the series (this patch was in preparation for that one) and the only reason I require this here is to make it pass the gate CI (since neutron grenade job exposed one of our bugs), but as you can see I\u0027m removing this in the next patch [1] since it will be auto generated, so I will not be manually adding these for all other OVOs unless we decide we don\u0027t want it to be autobuilt and we want to do it manually.\n\n[1]: https://review.openstack.org/#/c/307075/9/cinder/objects/volume.py","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"af21f67d11d536e85fca04748c1551fc08fe8cf0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        \u0027consistencygroup\u0027: ((\u00271.3\u0027, \u00271.2\u0027),),"},{"line_number":124,"context_line":"        \u0027snapshots\u0027: ((\u00271.3\u0027, \u00271.1\u0027),),"},{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # NOTE(thangp): obj_extra_fields is used to hold properties that are not"},{"line_number":128,"context_line":"    # usually part of the model"},{"line_number":129,"context_line":"    obj_extra_fields \u003d [\u0027name\u0027, \u0027name_id\u0027, \u0027volume_metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_11b41b33","line":126,"in_reply_to":"bab6814e_d778f9fa","updated":"2016-05-26 03:16:16.000000000","message":"Got it. Thanks.","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ea33aca3d10bb4e09f531c7f21d7149095d76bc2","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Volume\u0027),"},{"line_number":453,"context_line":"    }"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    child_versions \u003d {"},{"line_number":456,"context_line":"        \u00271.1\u0027: \u00271.1\u0027,"},{"line_number":457,"context_line":"    }"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"    @classmethod"},{"line_number":460,"context_line":"    def _get_expected_attrs(cls, context):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_7d64cee4","line":457,"range":{"start_line":455,"start_character":0,"end_line":457,"end_character":5},"updated":"2016-05-24 09:53:35.000000000","message":"ditto","commit_id":"2015cc0ed5f14a160181e66394c2f4bea3c7fad4"}]}