)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d1704aa8dbcb970b30c2149d2b845056a16dc9bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IBM FlashSystem: Cleanup host resource leaking"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flashsystem iSCSI common code, _unmap_vdisk_from_host(),"},{"line_number":10,"context_line":"should return the host_name in the following cases:"},{"line_number":11,"context_line":"1) the volume doesn\u0027t exist"},{"line_number":12,"context_line":"2) the vdisk and host mapping doesn\u0027t exists"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_78a3abb2","line":9,"updated":"2016-04-19 16:03:15.000000000","message":"s/flashsystem/FlashSystem\ns/_unmap_vdisk_from_host(),/_unmap_vdisk_from_host","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IBM FlashSystem: Cleanup host resource leaking"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The flashsystem iSCSI common code, _unmap_vdisk_from_host(),"},{"line_number":10,"context_line":"should return the host_name in the following cases:"},{"line_number":11,"context_line":"1) the volume doesn\u0027t exist"},{"line_number":12,"context_line":"2) the vdisk and host mapping doesn\u0027t exists"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_0a7a0f77","line":9,"in_reply_to":"1a122d0e_78a3abb2","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b36b33480686c0bc6ce080b7c298a13fa6fd81b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The flashsystem iSCSI common code, _unmap_vdisk_from_host(),"},{"line_number":10,"context_line":"should return the host_name in the following cases:"},{"line_number":11,"context_line":"1) the volume doesn\u0027t exist"},{"line_number":12,"context_line":"2) the vdisk and host mapping doesn\u0027t exists"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The current current _unmap_vdisk_from_host() just return null"},{"line_number":15,"context_line":"and it will cause issues:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_ab7238ab","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":44},"updated":"2016-04-18 22:26:56.000000000","message":"s/exists/exist","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The flashsystem iSCSI common code, _unmap_vdisk_from_host(),"},{"line_number":10,"context_line":"should return the host_name in the following cases:"},{"line_number":11,"context_line":"1) the volume doesn\u0027t exist"},{"line_number":12,"context_line":"2) the vdisk and host mapping doesn\u0027t exists"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The current current _unmap_vdisk_from_host() just return null"},{"line_number":15,"context_line":"and it will cause issues:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_4ab1a746","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":44},"in_reply_to":"1a122d0e_ab7238ab","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b36b33480686c0bc6ce080b7c298a13fa6fd81b8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"1) the volume doesn\u0027t exist"},{"line_number":12,"context_line":"2) the vdisk and host mapping doesn\u0027t exists"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The current current _unmap_vdisk_from_host() just return null"},{"line_number":15,"context_line":"and it will cause issues:"},{"line_number":16,"context_line":"1) if the host_name has not been returned to the caller,"},{"line_number":17,"context_line":"   terminate_connection(), the caller will not check to see"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_2b5f480f","line":14,"range":{"start_line":14,"start_character":45,"end_line":14,"end_character":61},"updated":"2016-04-18 22:26:56.000000000","message":"should be \"just returns None\"","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"1) the volume doesn\u0027t exist"},{"line_number":12,"context_line":"2) the vdisk and host mapping doesn\u0027t exists"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The current current _unmap_vdisk_from_host() just return null"},{"line_number":15,"context_line":"and it will cause issues:"},{"line_number":16,"context_line":"1) if the host_name has not been returned to the caller,"},{"line_number":17,"context_line":"   terminate_connection(), the caller will not check to see"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_6ab46334","line":14,"range":{"start_line":14,"start_character":45,"end_line":14,"end_character":61},"in_reply_to":"1a122d0e_2b5f480f","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d1704aa8dbcb970b30c2149d2b845056a16dc9bb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"and it will cause issues:"},{"line_number":16,"context_line":"1) if the host_name has not been returned to the caller,"},{"line_number":17,"context_line":"   terminate_connection(), the caller will not check to see"},{"line_number":18,"context_line":"   if the host entry has any more volumes mapped to it."},{"line_number":19,"context_line":"2) if a host entry does not have anymore volumes attached to it"},{"line_number":20,"context_line":"   the host entry gets left behind."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_58e4efdf","line":18,"updated":"2016-04-19 16:03:15.000000000","message":"Can remove the \u0027.\u0027 from the end of these sentances","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"and it will cause issues:"},{"line_number":16,"context_line":"1) if the host_name has not been returned to the caller,"},{"line_number":17,"context_line":"   terminate_connection(), the caller will not check to see"},{"line_number":18,"context_line":"   if the host entry has any more volumes mapped to it."},{"line_number":19,"context_line":"2) if a host entry does not have anymore volumes attached to it"},{"line_number":20,"context_line":"   the host entry gets left behind."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_ea7eb368","line":18,"in_reply_to":"1a122d0e_58e4efdf","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"}],"cinder/tests/unit/test_ibm_flashsystem_iscsi.py":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d1704aa8dbcb970b30c2149d2b845056a16dc9bb","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_terminate_connection_with_resource_leak_check(self):"},{"line_number":266,"context_line":"        # Case 1: normal termination connection test"},{"line_number":267,"context_line":"        self.sim.set_protocol(\u0027iSCSI\u0027)"},{"line_number":268,"context_line":"        self._set_flag(\u0027flashsystem_connection_protocol\u0027, \u0027iSCSI\u0027)"},{"line_number":269,"context_line":"        self.driver.do_setup(None)"},{"line_number":270,"context_line":"        connector \u003d {\u0027host\u0027: \u0027flashsystem-host\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_184a77ac","line":267,"updated":"2016-04-19 16:03:15.000000000","message":"Do we actually need lines 267-269? Seems like we should be able to remove these since they\u0027re already getting set in setUp?","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_terminate_connection_with_resource_leak_check(self):"},{"line_number":266,"context_line":"        # Case 1: normal termination connection test"},{"line_number":267,"context_line":"        self.sim.set_protocol(\u0027iSCSI\u0027)"},{"line_number":268,"context_line":"        self._set_flag(\u0027flashsystem_connection_protocol\u0027, \u0027iSCSI\u0027)"},{"line_number":269,"context_line":"        self.driver.do_setup(None)"},{"line_number":270,"context_line":"        connector \u003d {\u0027host\u0027: \u0027flashsystem-host\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6ae2a330","line":267,"in_reply_to":"1a122d0e_184a77ac","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d1704aa8dbcb970b30c2149d2b845056a16dc9bb","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        self.sim.set_protocol(\u0027iSCSI\u0027)"},{"line_number":268,"context_line":"        self._set_flag(\u0027flashsystem_connection_protocol\u0027, \u0027iSCSI\u0027)"},{"line_number":269,"context_line":"        self.driver.do_setup(None)"},{"line_number":270,"context_line":"        connector \u003d {\u0027host\u0027: \u0027flashsystem-host\u0027,"},{"line_number":271,"context_line":"                     \u0027wwnns\u0027: [\u002710000090fa17311e\u0027, \u002710000090fa17311f\u0027],"},{"line_number":272,"context_line":"                     \u0027wwpns\u0027: [\u002720000090fa17311e\u0027, \u002720000090fa17311f\u0027],"},{"line_number":273,"context_line":"                     \u0027initiator\u0027: \u0027iqn.1993-08.org.debian:01:89ad29bbdc43\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f8ddfbe0","line":270,"updated":"2016-04-19 16:03:15.000000000","message":"Is there a reason that self.connector can\u0027t be used for this?","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        self.sim.set_protocol(\u0027iSCSI\u0027)"},{"line_number":268,"context_line":"        self._set_flag(\u0027flashsystem_connection_protocol\u0027, \u0027iSCSI\u0027)"},{"line_number":269,"context_line":"        self.driver.do_setup(None)"},{"line_number":270,"context_line":"        connector \u003d {\u0027host\u0027: \u0027flashsystem-host\u0027,"},{"line_number":271,"context_line":"                     \u0027wwnns\u0027: [\u002710000090fa17311e\u0027, \u002710000090fa17311f\u0027],"},{"line_number":272,"context_line":"                     \u0027wwpns\u0027: [\u002720000090fa17311e\u0027, \u002720000090fa17311f\u0027],"},{"line_number":273,"context_line":"                     \u0027initiator\u0027: \u0027iqn.1993-08.org.debian:01:89ad29bbdc43\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7e339314","line":270,"in_reply_to":"1a122d0e_f8ddfbe0","updated":"2016-04-19 22:08:37.000000000","message":"Ryan;\n\nI create my own connector with a real iqn value, \u0027iqn.1993-08.org.debian:01:89ad29bbdc43\u0027. The reason is that when I reviewing debug message, it confused me that the code messed up with iqn.","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d1704aa8dbcb970b30c2149d2b845056a16dc9bb","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"},{"line_number":284,"context_line":"        self.assertIsNone(host)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        # Case 2: volume mapping removed before terminate connection"},{"line_number":287,"context_line":"        self.driver.initialize_connection(volume_iscsi, connector)"},{"line_number":288,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"},{"line_number":289,"context_line":"        self.assertIsNotNone(host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b80a6377","line":286,"updated":"2016-04-19 16:03:15.000000000","message":"Could be nice to split this into it\u0027s own test case (so that we try to test one thing per test case)","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"},{"line_number":284,"context_line":"        self.assertIsNone(host)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        # Case 2: volume mapping removed before terminate connection"},{"line_number":287,"context_line":"        self.driver.initialize_connection(volume_iscsi, connector)"},{"line_number":288,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"},{"line_number":289,"context_line":"        self.assertIsNotNone(host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_aad67b4c","line":286,"in_reply_to":"1a122d0e_b80a6377","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d1704aa8dbcb970b30c2149d2b845056a16dc9bb","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.driver.initialize_connection(volume_iscsi, connector)"},{"line_number":288,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"},{"line_number":289,"context_line":"        self.assertIsNotNone(host)"},{"line_number":290,"context_line":"        rmmap_cmd \u003d {\u0027host\u0027: host, \u0027obj\u0027: volume_iscsi[\u0027name\u0027]}"},{"line_number":291,"context_line":"        self.sim._cmd_rmvdiskhostmap(**rmmap_cmd)"},{"line_number":292,"context_line":"        self.driver.terminate_connection(volume_iscsi, connector)"},{"line_number":293,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d8011f3a","line":290,"updated":"2016-04-19 16:03:15.000000000","message":"Could optionally pass in this directly to the function","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.driver.initialize_connection(volume_iscsi, connector)"},{"line_number":288,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"},{"line_number":289,"context_line":"        self.assertIsNotNone(host)"},{"line_number":290,"context_line":"        rmmap_cmd \u003d {\u0027host\u0027: host, \u0027obj\u0027: volume_iscsi[\u0027name\u0027]}"},{"line_number":291,"context_line":"        self.sim._cmd_rmvdiskhostmap(**rmmap_cmd)"},{"line_number":292,"context_line":"        self.driver.terminate_connection(volume_iscsi, connector)"},{"line_number":293,"context_line":"        host \u003d self.driver._get_host_from_connector(connector)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_a9cfb727","line":290,"in_reply_to":"1a122d0e_d8011f3a","updated":"2016-04-19 22:08:37.000000000","message":"Ryan, the reason I separate the definition and assignment of rmmap_cmd is easy to debug, I can set break point to check the values before pass it into the method.","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"d1704aa8dbcb970b30c2149d2b845056a16dc9bb","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # clean environment"},{"line_number":297,"context_line":"        self.driver.delete_volume(volume_iscsi)"},{"line_number":298,"context_line":"        self._reset_flags()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_983e87d8","line":298,"updated":"2016-04-19 16:03:15.000000000","message":"This gets called in setUp already","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        # clean environment"},{"line_number":297,"context_line":"        self.driver.delete_volume(volume_iscsi)"},{"line_number":298,"context_line":"        self._reset_flags()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_eaccf3bc","line":298,"in_reply_to":"1a122d0e_983e87d8","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"}],"cinder/volume/drivers/ibm/flashsystem_common.py":[{"author":{"_account_id":17382,"name":"Edwin Wang","email":"edwin@oohoo.org","username":"edwinwang"},"change_message_id":"7105b5122d3b08f472409a22b91ab0983c5de9a5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                terminate_connection"},{"line_number":81,"context_line":"        1.0.7 - Fix bug #1505477, add host name check in"},{"line_number":82,"context_line":"                _find_host_exhaustive for FC"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    VERSION \u003d \"1.0.7\""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_20cf382a","line":83,"updated":"2016-05-10 14:51:01.000000000","message":"Please also mark your modification in version history.","commit_id":"bae74b74c92640b53ffddf678f6ac107d0740697"},{"author":{"_account_id":17382,"name":"Edwin Wang","email":"edwin@oohoo.org","username":"edwinwang"},"change_message_id":"7105b5122d3b08f472409a22b91ab0983c5de9a5","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    \"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    VERSION \u003d \"1.0.7\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":89,"context_line":"        super(FlashSystemDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_40da3ce9","line":86,"updated":"2016-05-10 14:51:01.000000000","message":"Remember changing the VERSION.","commit_id":"bae74b74c92640b53ffddf678f6ac107d0740697"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"9e23274684792432803a2bed8aea8a0594737a4e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                _find_host_exhaustive for FC"},{"line_number":83,"context_line":"        1.0.8 - Fix bug #1572743, multi-attach attribute"},{"line_number":84,"context_line":"                should not be hardcoded"},{"line_number":85,"context_line":"        1.0.9 - Fix bug #1570574, Cleanup host resource"},{"line_number":86,"context_line":"                leaking"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    \"\"\""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_59633bb1","line":86,"range":{"start_line":85,"start_character":0,"end_line":86,"end_character":23},"updated":"2016-05-17 02:15:54.000000000","message":"Need to be same as FC driver.","commit_id":"b3c5f844069b18d685e3fa6a2cb0b77df531eb35"}],"cinder/volume/drivers/ibm/flashsystem_fc.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ce82c232fb35acc0f176caababd287d5dc23f975","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        1.0.8 - Fix bug #1572743, multi-attach attribute"},{"line_number":76,"context_line":"                should not be hardcoded"},{"line_number":77,"context_line":"        1.0.9 - Fix bug #1570574, Cleanup host resource"},{"line_number":78,"context_line":"                leaking"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    \"\"\""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_51f5e2ea","line":78,"updated":"2016-05-16 18:35:16.000000000","message":"You did not make any changes in this FC driver.  Why increment the version here? If you are trying to keep the version number the same in both drivers, please specify in the version history that these two changes are for iSCSI.","commit_id":"ffc7ffca8d8821b0125d450f60a2c80fa1d3dd39"}],"cinder/volume/drivers/ibm/flashsystem_iscsi.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b36b33480686c0bc6ce080b7c298a13fa6fd81b8","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        # checking if host_name none, if not then, check if the host has"},{"line_number":282,"context_line":"        # any mappings, if not the host gets deleted."},{"line_number":283,"context_line":"        if host_name:"},{"line_number":284,"context_line":"            mapping_data \u003d self._get_hostvdisk_mappings(host_name)"},{"line_number":285,"context_line":"            if not mapping_data:"},{"line_number":286,"context_line":"                self._delete_host(host_name)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        LOG.debug("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_eb3d50bc","line":285,"range":{"start_line":284,"start_character":12,"end_line":285,"end_character":32},"updated":"2016-04-18 22:26:56.000000000","message":"This can be simplified to:\n\n   if not self._get_hostvdisk_mappings(host_name):\n\nsince you don\u0027t use the content of mapping_data.","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":21144,"name":"Xinli Guan","email":"xinli@us.ibm.com","username":"xinli"},"change_message_id":"82a8d3c4cbd7664db6dd98ec2db30a607edd768f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        # checking if host_name none, if not then, check if the host has"},{"line_number":282,"context_line":"        # any mappings, if not the host gets deleted."},{"line_number":283,"context_line":"        if host_name:"},{"line_number":284,"context_line":"            mapping_data \u003d self._get_hostvdisk_mappings(host_name)"},{"line_number":285,"context_line":"            if not mapping_data:"},{"line_number":286,"context_line":"                self._delete_host(host_name)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        LOG.debug("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8a8e1f77","line":285,"range":{"start_line":284,"start_character":12,"end_line":285,"end_character":32},"in_reply_to":"1a122d0e_eb3d50bc","updated":"2016-04-19 22:08:37.000000000","message":"Done","commit_id":"949821550969f1a3e50ac01f846aaedab942981c"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"ed8d95522c465c5bcd68a3b1c80c6e886d048055","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        host_name \u003d self._unmap_vdisk_from_host(vdisk_name, connector)"},{"line_number":281,"context_line":"        # checking if host_name none, if not then, check if the host has"},{"line_number":282,"context_line":"        # any mappings, if not the host gets deleted."},{"line_number":283,"context_line":"        if host_name:"},{"line_number":284,"context_line":"            if not self._get_hostvdisk_mappings(host_name):"},{"line_number":285,"context_line":"                self._delete_host(host_name)"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_831ffc59","line":283,"updated":"2016-04-20 15:56:21.000000000","message":"could optionally combine this and next line into a single if statement","commit_id":"9eb5b380724c2ee326d07ab6ecd9e80865ab6e80"},{"author":{"_account_id":17382,"name":"Edwin Wang","email":"edwin@oohoo.org","username":"edwinwang"},"change_message_id":"7105b5122d3b08f472409a22b91ab0983c5de9a5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                terminate_connection"},{"line_number":71,"context_line":"        1.0.7 - Fix bug #1505477, add host name check in"},{"line_number":72,"context_line":"                _find_host_exhaustive for FC"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    VERSION \u003d \"1.0.7\""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_000f9488","line":73,"updated":"2016-05-10 14:51:01.000000000","message":"Please also mark your modification in version history.","commit_id":"bae74b74c92640b53ffddf678f6ac107d0740697"},{"author":{"_account_id":17382,"name":"Edwin Wang","email":"edwin@oohoo.org","username":"edwinwang"},"change_message_id":"7105b5122d3b08f472409a22b91ab0983c5de9a5","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    \"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    VERSION \u003d \"1.0.7\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":79,"context_line":"        super(FlashSystemISCSIDriver, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_406cfc34","line":76,"updated":"2016-05-10 14:51:01.000000000","message":"Remember changing the VERSION.","commit_id":"bae74b74c92640b53ffddf678f6ac107d0740697"},{"author":{"_account_id":12514,"name":"YanLin Ren","email":"renylin@cn.ibm.com","username":"renylin"},"change_message_id":"9e23274684792432803a2bed8aea8a0594737a4e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                _find_host_exhaustive for FC"},{"line_number":73,"context_line":"        1.0.8 - Fix bug #1572743, multi-attach attribute"},{"line_number":74,"context_line":"                should not be hardcoded"},{"line_number":75,"context_line":"        1.0.9 - Fix bug #1570574, Cleanup host resource"},{"line_number":76,"context_line":"                leaking"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    \"\"\""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_d948cb2f","line":76,"range":{"start_line":75,"start_character":0,"end_line":76,"end_character":23},"updated":"2016-05-17 02:15:54.000000000","message":"Need to be same as FC driver.","commit_id":"b3c5f844069b18d685e3fa6a2cb0b77df531eb35"}]}