)]}'
{"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"22c8e58b2cba5fa3ecc548b71eba8f759db6b3cd","unresolved":false,"context_lines":[{"line_number":6379,"context_line":"                                            status\u003d\u0027backing-up\u0027)"},{"line_number":6380,"context_line":"            cloned_vol \u003d self.volume.driver._create_temp_cloned_volume("},{"line_number":6381,"context_line":"                self.context, vol)"},{"line_number":6382,"context_line":"            self.assertEqual(cloned_vol[\u0027provider_location\u0027], \u0027dummy\u0027)"},{"line_number":6383,"context_line":"            self.assertEqual(cloned_vol[\u0027status\u0027], \u0027available\u0027)"},{"line_number":6384,"context_line":""},{"line_number":6385,"context_line":"            mock_create_cloned_volume.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_3e902495","line":6382,"updated":"2016-05-04 13:00:38.000000000","message":"Please switch these assertEqual calls to have the arguments in the order (expected, actual). A bit of a nitpick, but there\u0027s been some effort to correct this in the code base, so don\u0027t want to allow more in.","commit_id":"c37968fe7d5a280a961b2ca3519af3a637940c2a"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"2fe176a9bfa4e2ac536848fc97e21ab1dd609766","unresolved":false,"context_lines":[{"line_number":6379,"context_line":"                                            status\u003d\u0027backing-up\u0027)"},{"line_number":6380,"context_line":"            cloned_vol \u003d self.volume.driver._create_temp_cloned_volume("},{"line_number":6381,"context_line":"                self.context, vol)"},{"line_number":6382,"context_line":"            self.assertEqual(cloned_vol[\u0027provider_location\u0027], \u0027dummy\u0027)"},{"line_number":6383,"context_line":"            self.assertEqual(cloned_vol[\u0027status\u0027], \u0027available\u0027)"},{"line_number":6384,"context_line":""},{"line_number":6385,"context_line":"            mock_create_cloned_volume.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_f71fef6d","line":6382,"in_reply_to":"1a122d0e_3e902495","updated":"2016-05-04 14:00:19.000000000","message":"Done","commit_id":"c37968fe7d5a280a961b2ca3519af3a637940c2a"}],"cinder/volume/driver.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"5794076d17b216049ba68380a087a8426b5e5b34","unresolved":false,"context_lines":[{"line_number":1357,"context_line":"                self.db.volume_destroy(context.elevated(),"},{"line_number":1358,"context_line":"                                       temp_vol_ref[\u0027id\u0027])"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"        model_update[\u0027status\u0027] \u003d \u0027available\u0027"},{"line_number":1361,"context_line":"        self.db.volume_update(context, temp_vol_ref[\u0027id\u0027], model_update)"},{"line_number":1362,"context_line":"        return self.db.volume_get(context, temp_vol_ref[\u0027id\u0027])"},{"line_number":1363,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_0f0ee68b","line":1360,"updated":"2016-05-04 07:08:49.000000000","message":"I noticed that no return value in LVM driver create_cloned_volume().\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L468\n\nSuch value set will lead to NoneType error.","commit_id":"49df0db16bc1cdc0fb62d08f3d2c9a62a84f5dd6"}]}