)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b9806662931e81dcfe5487383af8cb5bae22238a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Mehta \u003cjay.mehta@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-03 10:45:47 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Feature NSP for FC."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating match set type FC VLUN for HPE 3PAR,"},{"line_number":10,"context_line":"instead of host sees type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_f058b433","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"updated":"2016-05-03 22:00:05.000000000","message":"This should have 3PAR in the title and a little more descriptive.","commit_id":"fa4b6312c7532d000ed8417f6e3c2777ddca7b8a"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"455c349df64a96135d195f7fcda74843eb361db3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Mehta \u003cjay.mehta@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-03 10:45:47 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Feature NSP for FC."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating match set type FC VLUN for HPE 3PAR,"},{"line_number":10,"context_line":"instead of host sees type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_4e2a80e8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"1a122d0e_114436b5","updated":"2016-05-04 17:54:26.000000000","message":"Thanks for pointing out that. Noted. Taken care.","commit_id":"fa4b6312c7532d000ed8417f6e3c2777ddca7b8a"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"f2341f923d27ffc5115406338b26c563f4c4b156","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Mehta \u003cjay.mehta@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-03 10:45:47 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Feature NSP for FC."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating match set type FC VLUN for HPE 3PAR,"},{"line_number":10,"context_line":"instead of host sees type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_114436b5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"1a122d0e_f058b433","updated":"2016-05-04 14:40:48.000000000","message":"Along with a more descriptive title, you should also remove the period here since there should not be a period at the end of the title.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"fa4b6312c7532d000ed8417f6e3c2777ddca7b8a"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"455c349df64a96135d195f7fcda74843eb361db3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jay Mehta \u003cjay.mehta@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-03 10:45:47 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Feature NSP for FC."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating match set type FC VLUN for HPE 3PAR,"},{"line_number":10,"context_line":"instead of host sees type."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_2e14649d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":19},"in_reply_to":"1a122d0e_f058b433","updated":"2016-05-04 17:54:26.000000000","message":"Updated title, made it more meaningful. Thanks Kurt.","commit_id":"fa4b6312c7532d000ed8417f6e3c2777ddca7b8a"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"b9806662931e81dcfe5487383af8cb5bae22238a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Creating match set type FC VLUN for HPE 3PAR,"},{"line_number":10,"context_line":"instead of host sees type."},{"line_number":11,"context_line":"Updated broken unit test cases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I927638584093130b0e94c9cdd8074b3617baa366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_705ca419","line":12,"updated":"2016-05-03 22:00:05.000000000","message":"Jay, Please create a Newton blueprint for this feature and add a release note as it\u0027s changing functionality.","commit_id":"fa4b6312c7532d000ed8417f6e3c2777ddca7b8a"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"455c349df64a96135d195f7fcda74843eb361db3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Creating match set type FC VLUN for HPE 3PAR,"},{"line_number":10,"context_line":"instead of host sees type."},{"line_number":11,"context_line":"Updated broken unit test cases."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I927638584093130b0e94c9cdd8074b3617baa366"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_aed514b8","line":12,"in_reply_to":"1a122d0e_705ca419","updated":"2016-05-04 17:54:26.000000000","message":"Created bug for this on launchpad and appended to commit message. I will add a release note for this functionality change. Thanks","commit_id":"fa4b6312c7532d000ed8417f6e3c2777ddca7b8a"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"71196ad87806ffc09467f77b80a95bead87ae61e","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    for port in active_fc_port_list:"},{"line_number":291,"context_line":"                        if port[\u0027type\u0027] \u003d\u003d common.client.PORT_TYPE_HOST:"},{"line_number":292,"context_line":"                            nsp \u003d port[\u0027nsp\u0027]"},{"line_number":293,"context_line":"                            target_wwns +\u003d [port[\u0027portWWN\u0027]]"},{"line_number":294,"context_line":"                            vlun \u003d common.create_vlun(volume,"},{"line_number":295,"context_line":"                                                      host,"},{"line_number":296,"context_line":"                                                      nsp,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b021f3fe","line":293,"range":{"start_line":293,"start_character":28,"end_line":293,"end_character":60},"updated":"2016-04-25 16:52:55.000000000","message":"target_wwns.append([prt[\u0027portWWN\u0027])","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"72e4e892be15fb14c8f50e812958d3040953b5f1","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                    for port in active_fc_port_list:"},{"line_number":291,"context_line":"                        if port[\u0027type\u0027] \u003d\u003d common.client.PORT_TYPE_HOST:"},{"line_number":292,"context_line":"                            nsp \u003d port[\u0027nsp\u0027]"},{"line_number":293,"context_line":"                            target_wwns +\u003d [port[\u0027portWWN\u0027]]"},{"line_number":294,"context_line":"                            vlun \u003d common.create_vlun(volume,"},{"line_number":295,"context_line":"                                                      host,"},{"line_number":296,"context_line":"                                                      nsp,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ed4fdb8f","line":293,"range":{"start_line":293,"start_character":28,"end_line":293,"end_character":60},"in_reply_to":"1a122d0e_b021f3fe","updated":"2016-04-28 17:22:05.000000000","message":"Done","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"71196ad87806ffc09467f77b80a95bead87ae61e","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                      nsp,"},{"line_number":297,"context_line":"                                                      lun_id\u003dlun_id)"},{"line_number":298,"context_line":"                            if vlun[\u0027remoteName\u0027] in init_targ_map:"},{"line_number":299,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] +\u003d \\"},{"line_number":300,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":301,"context_line":"                            else:"},{"line_number":302,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_1078a7f1","line":299,"range":{"start_line":299,"start_character":69,"end_line":299,"end_character":70},"updated":"2016-04-25 16:52:55.000000000","message":"try not to use backslashes for separate lines. Use parenthesis and indentations.","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"72e4e892be15fb14c8f50e812958d3040953b5f1","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                      nsp,"},{"line_number":297,"context_line":"                                                      lun_id\u003dlun_id)"},{"line_number":298,"context_line":"                            if vlun[\u0027remoteName\u0027] in init_targ_map:"},{"line_number":299,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] +\u003d \\"},{"line_number":300,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":301,"context_line":"                            else:"},{"line_number":302,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_2d46f37a","line":299,"range":{"start_line":299,"start_character":69,"end_line":299,"end_character":70},"in_reply_to":"1a122d0e_1078a7f1","updated":"2016-04-28 17:22:05.000000000","message":"Done","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"71196ad87806ffc09467f77b80a95bead87ae61e","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                      nsp,"},{"line_number":297,"context_line":"                                                      lun_id\u003dlun_id)"},{"line_number":298,"context_line":"                            if vlun[\u0027remoteName\u0027] in init_targ_map:"},{"line_number":299,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] +\u003d \\"},{"line_number":300,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":301,"context_line":"                            else:"},{"line_number":302,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] \u003d \\"},{"line_number":303,"context_line":"                                    [port[\u0027portWWN\u0027]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_70863bdc","line":300,"range":{"start_line":299,"start_character":32,"end_line":300,"end_character":53},"updated":"2016-04-25 16:52:55.000000000","message":"init_targ_map[vlun[\u0027remoteName\u0027]].append(port[\u0027portWWN\u0027])","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"72e4e892be15fb14c8f50e812958d3040953b5f1","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                      nsp,"},{"line_number":297,"context_line":"                                                      lun_id\u003dlun_id)"},{"line_number":298,"context_line":"                            if vlun[\u0027remoteName\u0027] in init_targ_map:"},{"line_number":299,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] +\u003d \\"},{"line_number":300,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":301,"context_line":"                            else:"},{"line_number":302,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] \u003d \\"},{"line_number":303,"context_line":"                                    [port[\u0027portWWN\u0027]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8d5f4740","line":300,"range":{"start_line":299,"start_character":32,"end_line":300,"end_character":53},"in_reply_to":"1a122d0e_70863bdc","updated":"2016-04-28 17:22:05.000000000","message":"Done","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"71196ad87806ffc09467f77b80a95bead87ae61e","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] +\u003d \\"},{"line_number":300,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":301,"context_line":"                            else:"},{"line_number":302,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] \u003d \\"},{"line_number":303,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":304,"context_line":"                            if lun_id is None:"},{"line_number":305,"context_line":"                                lun_id \u003d vlun[\u0027lun\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f049abb8","line":302,"range":{"start_line":302,"start_character":67,"end_line":302,"end_character":69},"updated":"2016-04-25 16:52:55.000000000","message":"try not to use backslashes for separate lines. Use parenthesis and indentations.","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"72e4e892be15fb14c8f50e812958d3040953b5f1","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] +\u003d \\"},{"line_number":300,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":301,"context_line":"                            else:"},{"line_number":302,"context_line":"                                init_targ_map[vlun[\u0027remoteName\u0027]] \u003d \\"},{"line_number":303,"context_line":"                                    [port[\u0027portWWN\u0027]]"},{"line_number":304,"context_line":"                            if lun_id is None:"},{"line_number":305,"context_line":"                                lun_id \u003d vlun[\u0027lun\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_cd55bf1e","line":302,"range":{"start_line":302,"start_character":67,"end_line":302,"end_character":69},"in_reply_to":"1a122d0e_f049abb8","updated":"2016-04-28 17:22:05.000000000","message":"Done","commit_id":"295af018128510ce2203d06903b8d6ca6b3426d1"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"ba31e3df4bce97dec358c974a7a8b7cb7b91cf72","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                                common.build_nsp(fcpath[\u0027portPos\u0027]))"},{"line_number":296,"context_line":"                    for port in active_fc_port_list:"},{"line_number":297,"context_line":"                        if ("},{"line_number":298,"context_line":"                            port[\u0027type\u0027] \u003d\u003d common.client.PORT_TYPE_HOST and"},{"line_number":299,"context_line":"                            port[\u0027nsp\u0027] in host_connected_nsp"},{"line_number":300,"context_line":"                        ):"},{"line_number":301,"context_line":"                            nsp \u003d port[\u0027nsp\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_2996f093","line":298,"updated":"2016-05-05 15:41:34.000000000","message":"Nit: You could move this line above #297 outside the if conditional and then do the conditional on one line:\n\nif (port[\u0027type\u0027] and port[\u0027nsp\u0027] in host_connected_nsp):","commit_id":"5049141cd8d68d91d19bb50c33aa6e882fdb6463"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"eb2ee1b61e7583787b330306eb65200fda035693","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                                common.build_nsp(fcpath[\u0027portPos\u0027]))"},{"line_number":296,"context_line":"                    for port in active_fc_port_list:"},{"line_number":297,"context_line":"                        if ("},{"line_number":298,"context_line":"                            port[\u0027type\u0027] \u003d\u003d common.client.PORT_TYPE_HOST and"},{"line_number":299,"context_line":"                            port[\u0027nsp\u0027] in host_connected_nsp"},{"line_number":300,"context_line":"                        ):"},{"line_number":301,"context_line":"                            nsp \u003d port[\u0027nsp\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_856cd29d","line":298,"in_reply_to":"1a122d0e_2996f093","updated":"2016-05-05 22:25:05.000000000","message":"This line is fine.\n\nIf you do that, then any port type will match, which is incorrect.  Take a look here.\nhttps://github.com/hpe-storage/python-3parclient/blob/master/hpe3parclient/client.py#L60-L68","commit_id":"5049141cd8d68d91d19bb50c33aa6e882fdb6463"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"d16c0c1f9a99634080082d93661c74698d41dc61","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        3.0.5 - Optimize array ID retrieval"},{"line_number":102,"context_line":"        3.0.6 - Update replication to version 2.1"},{"line_number":103,"context_line":"        3.0.7 - Remove metadata that tracks the instance ID. bug #1572665"},{"line_number":104,"context_line":"        3.0.8 - NSP feature, creating FC Vlun as match set instead of host sees"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_a16a0e7f","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":79},"updated":"2016-05-31 17:26:55.000000000","message":"this should have a bug #1577993 to be consistent with all the other revision history entries.","commit_id":"161fca8bad7e644ba63ecc20c832fa3eb3cb5b69"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"7c52a0aafe4baeb2f8e99a681dc7192bf2273c17","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        3.0.5 - Optimize array ID retrieval"},{"line_number":102,"context_line":"        3.0.6 - Update replication to version 2.1"},{"line_number":103,"context_line":"        3.0.7 - Remove metadata that tracks the instance ID. bug #1572665"},{"line_number":104,"context_line":"        3.0.8 - NSP feature, creating FC Vlun as match set instead of host sees"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    \"\"\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_73462f50","line":104,"range":{"start_line":104,"start_character":8,"end_line":104,"end_character":79},"in_reply_to":"9abb7d3a_a16a0e7f","updated":"2016-05-31 21:28:47.000000000","message":"Done","commit_id":"161fca8bad7e644ba63ecc20c832fa3eb3cb5b69"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e7f11d1e4dcaab74479b378a714b62625a8ae587","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                            nsp \u003d port[\u0027nsp\u0027]"},{"line_number":286,"context_line":"                            break"},{"line_number":287,"context_line":"                    vlun \u003d common.create_vlun(volume, host, nsp)"},{"line_number":288,"context_line":"                else:"},{"line_number":289,"context_line":"                    lun_id \u003d None"},{"line_number":290,"context_line":"                    init_targ_map.clear()"},{"line_number":291,"context_line":"                    del target_wwns[:]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_cd00e104","line":288,"updated":"2016-06-01 19:08:26.000000000","message":"I think there could be potential problems here when the lookup_service is not None and there area more than 1 paths active.  This code will basically ignore any of the active paths discovered by the lookup service and always force exports via every active port.","commit_id":"86dec36f99ac6fd88847669ae8b5eb4677c8a0ef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"23fa2772e33c59dce3d196264bede93000995e1e","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                            nsp \u003d port[\u0027nsp\u0027]"},{"line_number":286,"context_line":"                            break"},{"line_number":287,"context_line":"                    vlun \u003d common.create_vlun(volume, host, nsp)"},{"line_number":288,"context_line":"                else:"},{"line_number":289,"context_line":"                    lun_id \u003d None"},{"line_number":290,"context_line":"                    init_targ_map.clear()"},{"line_number":291,"context_line":"                    del target_wwns[:]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_23af9595","line":288,"in_reply_to":"9abb7d3a_cd00e104","updated":"2016-06-06 19:37:14.000000000","message":"Done","commit_id":"86dec36f99ac6fd88847669ae8b5eb4677c8a0ef"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"96ff00a77cd8e5b90adfa6547a5d099bcbe38209","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                        LOG.error(_LE(\"Setup is incomplete. Device Mapping \""},{"line_number":285,"context_line":"                                      \"not found from FC network. \""},{"line_number":286,"context_line":"                                      \"Cannot perform VLUN creation\"))"},{"line_number":287,"context_line":"                        return None"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"                    for target_wwn in target_wwns:"},{"line_number":290,"context_line":"                        for port in active_fc_port_list:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_1b1c39c0","line":287,"updated":"2016-06-07 20:43:55.000000000","message":"we can\u0027t return None here.  We need to raise an exception so the volume manager can properly back out and report back.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L1423-L1432","commit_id":"39320c2fdefc3aae5ac6fcc30151dd25542addf8"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"7179b91fa1c23e2179561f69c4e78a61d02b1641","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                        LOG.error(_LE(\"Setup is incomplete. Device Mapping \""},{"line_number":285,"context_line":"                                      \"not found from FC network. \""},{"line_number":286,"context_line":"                                      \"Cannot perform VLUN creation\"))"},{"line_number":287,"context_line":"                        return None"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"                    for target_wwn in target_wwns:"},{"line_number":290,"context_line":"                        for port in active_fc_port_list:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_4972744a","line":287,"in_reply_to":"7aa08908_1b1c39c0","updated":"2016-06-07 22:32:15.000000000","message":"Done","commit_id":"39320c2fdefc3aae5ac6fcc30151dd25542addf8"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0bdf5c075f1e5368ae294cb7ce7a5d7861315091","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"                if self.lookup_service:"},{"line_number":283,"context_line":"                    if not init_targ_map:"},{"line_number":284,"context_line":"                        msg \u003d _LE(\"Setup is incomplete. Device mapping \""},{"line_number":285,"context_line":"                                  \"not found from FC network. \""},{"line_number":286,"context_line":"                                  \"Cannot perform VLUN creation.\")"},{"line_number":287,"context_line":"                        LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_84dfe138","line":284,"range":{"start_line":284,"start_character":30,"end_line":284,"end_character":33},"updated":"2016-06-08 17:20:14.000000000","message":"This must be translated because it is used as an exception message. Please change _LE() to _().\n\nSee http://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"1063e3e4380373158aef283cabc7a1cd50ef1e4f"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"3e982e2d1dc49389d8ec53428dda4656d346bd1d","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":"                if self.lookup_service:"},{"line_number":283,"context_line":"                    if not init_targ_map:"},{"line_number":284,"context_line":"                        msg \u003d _LE(\"Setup is incomplete. Device mapping \""},{"line_number":285,"context_line":"                                  \"not found from FC network. \""},{"line_number":286,"context_line":"                                  \"Cannot perform VLUN creation.\")"},{"line_number":287,"context_line":"                        LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_d0fb6377","line":284,"range":{"start_line":284,"start_character":30,"end_line":284,"end_character":33},"in_reply_to":"7aa08908_84dfe138","updated":"2016-06-08 18:46:06.000000000","message":"Done. Updated.","commit_id":"1063e3e4380373158aef283cabc7a1cd50ef1e4f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"773df9b62a0768d29a00bef5edfebeca795baf8d","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                lun_id \u003d vlun[\u0027lun\u0027]"},{"line_number":328,"context_line":"                if lun_id is None:"},{"line_number":329,"context_line":"                    # New vlun creation failed"},{"line_number":330,"context_line":"                    return None"},{"line_number":331,"context_line":"            else:"},{"line_number":332,"context_line":"                vlun \u003d existing_vlun"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_3baf03e5","line":330,"updated":"2016-06-21 17:36:23.000000000","message":"you can\u0027t return None here.  The volume manager expects to get a valid structure back.  If we failed to create a VLUN, we need to raise an exception.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L1360-L1361","commit_id":"16f5e1379d50199fc13a67163d3f1f758b6cb084"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"c071f0dfbfded8b073ab24ed02aaa66595e2a8bf","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                lun_id \u003d vlun[\u0027lun\u0027]"},{"line_number":328,"context_line":"                if lun_id is None:"},{"line_number":329,"context_line":"                    # New vlun creation failed"},{"line_number":330,"context_line":"                    return None"},{"line_number":331,"context_line":"            else:"},{"line_number":332,"context_line":"                vlun \u003d existing_vlun"},{"line_number":333,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_2df33b0c","line":330,"in_reply_to":"3aaa91ec_3baf03e5","updated":"2016-06-21 22:35:20.000000000","message":"Done","commit_id":"16f5e1379d50199fc13a67163d3f1f758b6cb084"}],"releasenotes/notes/3par-create-fc-vlun-match-set-type-babcf2cbce1ce317.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0a912818949923b82d1209b494e713f5484d7e82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - 3PAR driver creates FC VLUN of match-set type instead of host sees."},{"line_number":4,"context_line":"    With match-set, the host will see the virtual volume on specified"},{"line_number":5,"context_line":"    NSP (Node-Slot-Port). This change in vlun type fixes bug 1577993."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1aa78d24_c3bed1d3","line":3,"updated":"2016-07-02 18:02:01.000000000","message":"This seems a little awkwardly worded, but I don\u0027t really know the problem well enough to suggest a better way to note in the release notes. We can fix up later if something better is thought of.","commit_id":"0912153358a686721539c48a0736a321544873a1"}]}