)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"de40148c414d2e3e21e2ebfbf984b634f0c76651","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                id_string \u003d self._create_provider_id_string("},{"line_number":333,"context_line":"                    sfsnap[\u0027snapshotID\u0027],"},{"line_number":334,"context_line":"                    sfsnap[\u0027volumeID\u0027])"},{"line_number":335,"context_line":"                if s.get(\u0027provider_id\u0027) !\u003d id_string:"},{"line_number":336,"context_line":"                    updates.append("},{"line_number":337,"context_line":"                        {\u0027id\u0027: s[\u0027id\u0027],"},{"line_number":338,"context_line":"                         \u0027provider_id\u0027: id_string})"},{"line_number":339,"context_line":"        return updates"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7faed12e","side":"PARENT","line":336,"range":{"start_line":335,"start_character":16,"end_line":336,"end_character":35},"updated":"2016-04-27 15:58:54.000000000","message":"The function below appears to be a mirror of this one. It looks like there is no assignment in a addition to appending it to the updates array here. So I would agree that line 352 is unnecessary. But this also makes me question the conditional on line 351. What it compares the current provider to is different from what it updates it to on line 355. Here, it compares and updates to the same variable. Is this another mistake?","commit_id":"2482a54f1576b9bbddea4c925f184ea039e5d3c3"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"da5e15bb3b474f9fcdee73dc8311cddbc3ae8c9b","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                (sv for sv in sf_vols if sv[\u0027name\u0027] \u003d\u003d seek_name), None)"},{"line_number":350,"context_line":"            if sfvol:"},{"line_number":351,"context_line":"                if v.get(\u0027provider_id\u0027, \u0027nil\u0027) !\u003d sfvol[\u0027volumeID\u0027]:"},{"line_number":352,"context_line":"                    v[\u0027provider_id\u0027] \u003d\u003d sfvol[\u0027volumeID\u0027]"},{"line_number":353,"context_line":"                    updates.append("},{"line_number":354,"context_line":"                        {\u0027id\u0027: v[\u0027id\u0027],"},{"line_number":355,"context_line":"                         \u0027provider_id\u0027: self._create_provider_id_string("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9c6e5b2d","side":"PARENT","line":352,"range":{"start_line":352,"start_character":20,"end_line":352,"end_character":57},"updated":"2016-04-27 15:31:13.000000000","message":"I think it was supposed to be an assignment instead of a comparison, and that means we don\u0027t simply remove it.","commit_id":"2482a54f1576b9bbddea4c925f184ea039e5d3c3"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"74c3e1f3cfbdcfc549d079d9a507c27736a678dd","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                (sv for sv in sf_vols if sv[\u0027name\u0027] \u003d\u003d seek_name), None)"},{"line_number":350,"context_line":"            if sfvol:"},{"line_number":351,"context_line":"                if v.get(\u0027provider_id\u0027, \u0027nil\u0027) !\u003d sfvol[\u0027volumeID\u0027]:"},{"line_number":352,"context_line":"                    v[\u0027provider_id\u0027] \u003d\u003d sfvol[\u0027volumeID\u0027]"},{"line_number":353,"context_line":"                    updates.append("},{"line_number":354,"context_line":"                        {\u0027id\u0027: v[\u0027id\u0027],"},{"line_number":355,"context_line":"                         \u0027provider_id\u0027: self._create_provider_id_string("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_bf7b49bd","side":"PARENT","line":352,"range":{"start_line":352,"start_character":20,"end_line":352,"end_character":57},"in_reply_to":"1a122d0e_9c6e5b2d","updated":"2016-04-27 15:55:08.000000000","message":"yep second opinion is always good... Lets john confirm on this.\nThank you!!","commit_id":"2482a54f1576b9bbddea4c925f184ea039e5d3c3"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"bc07ca46ca974278afa7cb5eab45869fc19cb21b","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                (sv for sv in sf_vols if sv[\u0027name\u0027] \u003d\u003d seek_name), None)"},{"line_number":350,"context_line":"            if sfvol:"},{"line_number":351,"context_line":"                if v.get(\u0027provider_id\u0027, \u0027nil\u0027) !\u003d sfvol[\u0027volumeID\u0027]:"},{"line_number":352,"context_line":"                    v[\u0027provider_id\u0027] \u003d\u003d sfvol[\u0027volumeID\u0027]"},{"line_number":353,"context_line":"                    updates.append("},{"line_number":354,"context_line":"                        {\u0027id\u0027: v[\u0027id\u0027],"},{"line_number":355,"context_line":"                         \u0027provider_id\u0027: self._create_provider_id_string("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_46fdb73a","side":"PARENT","line":352,"range":{"start_line":352,"start_character":20,"end_line":352,"end_character":57},"in_reply_to":"1a122d0e_bf7b49bd","updated":"2016-05-01 06:51:01.000000000","message":"I agree with comment from yosef Hoffman(comment above) for extra line of code, thanks Yosef for pointing it here as it supports removal of this extra line of code.\n\nAlso, I think a statement with \u003d\u003d does not have any impact.\nSo, removing it.","commit_id":"2482a54f1576b9bbddea4c925f184ea039e5d3c3"}]}