)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e49330653708da9e8fd86971c90061cee2bec7f5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Make use of doc8 to verify all rst files which are not"},{"line_number":10,"context_line":"autogenerated for errors and fail if there are any issues"},{"line_number":11,"context_line":"found."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fix all issues found by doc8."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1566765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a430d35_e8ae0184","line":12,"updated":"2017-02-06 21:34:39.000000000","message":"Since there are other changes to fix, could you also update the commit message with an example of how to run tox to do the doc verification.","commit_id":"5c446d7fd890abbbfd0c3433a07606c5836aa28c"},{"author":{"_account_id":9064,"name":"Danny Al-Gaaf","email":"danny.al-gaaf@bisect.de","username":"dalgaaf"},"change_message_id":"0dfd0f164f27c551729edc3fe3ed1cdeb02ac45e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Make use of doc8 to verify all rst files which are not"},{"line_number":10,"context_line":"autogenerated for errors and fail if there are any issues"},{"line_number":11,"context_line":"found."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fix all issues found by doc8."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1566765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa31d9ce_3954c2c8","line":12,"in_reply_to":"1a430d35_e8ae0184","updated":"2017-02-14 11:40:43.000000000","message":"Done","commit_id":"5c446d7fd890abbbfd0c3433a07606c5836aa28c"}],"tox.ini":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"94af3866a97c44dfe138b01cbbc9c183533508fb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"commands \u003d {posargs}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:docs]"},{"line_number":88,"context_line":"commands \u003d"},{"line_number":89,"context_line":"\t# verify rst files, ignore auto generated files"},{"line_number":90,"context_line":"\tdoc8 --ignore D001 --ignore-path doc/src/api -e txt -e rst doc/source/ doc/README.rst rally-jobs CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":91,"context_line":"\tpython setup.py build_sphinx"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"[testenv:gendriverlist]"},{"line_number":94,"context_line":"sitepackages \u003d False"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1a122d0e_5942c8ab","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":29},"updated":"2016-04-29 20:32:09.000000000","message":"Can we use a single space here instead of tab character? See pep8 env as example.\n\nAre CONTRIBUTING.rst, HACKING.rst and README.rst auto generated? What\u0027s the point of excluding them?\n\nShouldn\u0027t we actually build it first and then run doc8?","commit_id":"f768c426e06e6835bb4a6900d430cdb07f13605e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f54a9783e18ed193856edb4b8eb1851e1266b44a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"commands \u003d {posargs}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:docs]"},{"line_number":88,"context_line":"commands \u003d"},{"line_number":89,"context_line":"\t# verify rst files, ignore auto generated files"},{"line_number":90,"context_line":"\tdoc8 --ignore D001 --ignore-path doc/src/api -e txt -e rst doc/source/ doc/README.rst rally-jobs CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":91,"context_line":"\tpython setup.py build_sphinx"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"[testenv:gendriverlist]"},{"line_number":94,"context_line":"sitepackages \u003d False"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1a122d0e_fe61b512","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":29},"in_reply_to":"1a122d0e_5942c8ab","updated":"2016-05-03 15:18:34.000000000","message":"Agreed. I think those files shouldn\u0027t be excluded, and probably swap the order of the build_sphinx and doc8 operations.","commit_id":"f768c426e06e6835bb4a6900d430cdb07f13605e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"550dd74172957cc7a7c24c481712afcf7fd58b99","unresolved":false,"context_lines":[{"line_number":85,"context_line":"commands \u003d {posargs}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:docs]"},{"line_number":88,"context_line":"commands \u003d"},{"line_number":89,"context_line":"\t# verify rst files, ignore auto generated files"},{"line_number":90,"context_line":"\tdoc8 --ignore D001 --ignore-path doc/src/api -e txt -e rst doc/source/ doc/README.rst rally-jobs CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":91,"context_line":"\tpython setup.py build_sphinx"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"[testenv:gendriverlist]"},{"line_number":94,"context_line":"sitepackages \u003d False"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bab6814e_a8c5615c","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":29},"in_reply_to":"1a122d0e_5942c8ab","updated":"2016-05-18 10:02:54.000000000","message":"I agree with the tabs, but I don\u0027t see how we are excluding mentioned files... We are actually including them (unless I\u0027m seeing it wrong).\n\nWe only exclude D001 file and doc/src/api path, then we specify extensions we care about (txt and rst) and finally we specify the paths/files we want to check.\n\nAlso, regarding the order, if we are skipping auto generated files, why would we want to run the generation first? r:-??\n\nIt makes more sense to do the RST style check first before we actually fire the build, because we don\u0027t want to build with bad RST files anyway.","commit_id":"f768c426e06e6835bb4a6900d430cdb07f13605e"},{"author":{"_account_id":9064,"name":"Danny Al-Gaaf","email":"danny.al-gaaf@bisect.de","username":"dalgaaf"},"change_message_id":"20de41a36ddb42de1ae46d1d1f8dfcd8d0e7d78c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"commands \u003d {posargs}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:docs]"},{"line_number":88,"context_line":"commands \u003d"},{"line_number":89,"context_line":"\t# verify rst files, ignore auto generated files"},{"line_number":90,"context_line":"\tdoc8 --ignore D001 --ignore-path doc/src/api -e txt -e rst doc/source/ doc/README.rst rally-jobs CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":91,"context_line":"\tpython setup.py build_sphinx"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"[testenv:gendriverlist]"},{"line_number":94,"context_line":"sitepackages \u003d False"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1a122d0e_8e008137","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":29},"in_reply_to":"1a122d0e_5942c8ab","updated":"2017-02-01 15:52:49.000000000","message":"These files are not excluded, they are explicitly included. I will replace the tab with spaces.","commit_id":"f768c426e06e6835bb4a6900d430cdb07f13605e"},{"author":{"_account_id":9064,"name":"Danny Al-Gaaf","email":"danny.al-gaaf@bisect.de","username":"dalgaaf"},"change_message_id":"20de41a36ddb42de1ae46d1d1f8dfcd8d0e7d78c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"commands \u003d {posargs}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:docs]"},{"line_number":88,"context_line":"commands \u003d"},{"line_number":89,"context_line":"\t# verify rst files, ignore auto generated files"},{"line_number":90,"context_line":"\tdoc8 --ignore D001 --ignore-path doc/src/api -e txt -e rst doc/source/ doc/README.rst rally-jobs CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":91,"context_line":"\tpython setup.py build_sphinx"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"[testenv:gendriverlist]"},{"line_number":94,"context_line":"sitepackages \u003d False"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3a461143_b35e9777","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":29},"in_reply_to":"1a122d0e_fe61b512","updated":"2017-02-01 15:52:49.000000000","message":"see other comment, they are included.","commit_id":"f768c426e06e6835bb4a6900d430cdb07f13605e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d7976fe9acc26f60a4db58c23a4441ead1618da8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"commands \u003d {posargs}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:docs]"},{"line_number":88,"context_line":"commands \u003d"},{"line_number":89,"context_line":"\t# verify rst files, ignore auto generated files"},{"line_number":90,"context_line":"\tdoc8 --ignore D001 --ignore-path doc/src/api -e txt -e rst doc/source/ doc/README.rst rally-jobs CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":91,"context_line":"\tpython setup.py build_sphinx"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"[testenv:gendriverlist]"},{"line_number":94,"context_line":"sitepackages \u003d False"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bab6814e_9927d411","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":29},"in_reply_to":"bab6814e_6f46d124","updated":"2016-05-19 08:36:10.000000000","message":"Indeed, a very valid point and a great reason to alter the order.","commit_id":"f768c426e06e6835bb4a6900d430cdb07f13605e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"fca3d359bde04311d039cd8aba6d4bbb17f7dc81","unresolved":false,"context_lines":[{"line_number":85,"context_line":"commands \u003d {posargs}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"[testenv:docs]"},{"line_number":88,"context_line":"commands \u003d"},{"line_number":89,"context_line":"\t# verify rst files, ignore auto generated files"},{"line_number":90,"context_line":"\tdoc8 --ignore D001 --ignore-path doc/src/api -e txt -e rst doc/source/ doc/README.rst rally-jobs CONTRIBUTING.rst HACKING.rst README.rst"},{"line_number":91,"context_line":"\tpython setup.py build_sphinx"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"[testenv:gendriverlist]"},{"line_number":94,"context_line":"sitepackages \u003d False"}],"source_content_type":"text/x-properties","patch_set":1,"id":"bab6814e_6f46d124","line":91,"range":{"start_line":88,"start_character":0,"end_line":91,"end_character":29},"in_reply_to":"bab6814e_a8c5615c","updated":"2016-05-18 13:47:20.000000000","message":"Ouch, Gorka is right about excluding - sorry about that.\n\nOn the order - actually I\u0027ve looked through other repos [1] and noticed that in most cases projects are doing compilation first. I can imagine a case when it makes sense - when someone adds new autogenerated docs but forgets to add them as ignored here. If that docs will have errors, it will pass okay on Jenkins, but will cause problems for local dev environments.\n\n[1] http://codesearch.openstack.org/?q\u003ddoc8\u0026i\u003dnope\u0026files\u003dtox.in","commit_id":"f768c426e06e6835bb4a6900d430cdb07f13605e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"49d9511a4ee29b66b81f449380b296c1b77e6414","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  python setup.py build_sphinx"},{"line_number":99,"context_line":"  rm -rf api-ref/build"},{"line_number":100,"context_line":"  sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html/"},{"line_number":101,"context_line":"  doc8 --ignore D001 --ignore-path .tox --ignore-path cinder.egg-info --ignore-path doc/src/api --ignore-path doc/source/drivers.rst --ignore-path doc/build -e txt -e rst "},{"line_number":102,"context_line":"whitelist_externals \u003d rm"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[testenv:gendriverlist]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a461143_253eb6b8","line":101,"range":{"start_line":101,"start_character":170,"end_line":101,"end_character":171},"updated":"2017-02-02 14:21:08.000000000","message":"Extra space on the end.","commit_id":"5c446d7fd890abbbfd0c3433a07606c5836aa28c"},{"author":{"_account_id":9064,"name":"Danny Al-Gaaf","email":"danny.al-gaaf@bisect.de","username":"dalgaaf"},"change_message_id":"0dfd0f164f27c551729edc3fe3ed1cdeb02ac45e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"  python setup.py build_sphinx"},{"line_number":99,"context_line":"  rm -rf api-ref/build"},{"line_number":100,"context_line":"  sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html/"},{"line_number":101,"context_line":"  doc8 --ignore D001 --ignore-path .tox --ignore-path cinder.egg-info --ignore-path doc/src/api --ignore-path doc/source/drivers.rst --ignore-path doc/build -e txt -e rst "},{"line_number":102,"context_line":"whitelist_externals \u003d rm"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"[testenv:gendriverlist]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"fa31d9ce_993e8e8a","line":101,"range":{"start_line":101,"start_character":170,"end_line":101,"end_character":171},"in_reply_to":"3a461143_253eb6b8","updated":"2017-02-14 11:40:43.000000000","message":"Done","commit_id":"5c446d7fd890abbbfd0c3433a07606c5836aa28c"}]}