)]}'
{"cinder/tests/tempest/api/volume/test_volume_unicode.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a3f7916fdfb029c6e68c8abb69b4e8342b87455f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        result \u003d self.volumes_client.show_volume(self.volumes[0][\u0027id\u0027])"},{"line_number":57,"context_line":"        fetched_volume \u003d result[\u0027volume\u0027]"},{"line_number":58,"context_line":"        self.assertEqual(fetched_volume[self.special_fields[\u0027name_field\u0027]],"},{"line_number":59,"context_line":"                         self.volume_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"faac7902_72fc183f","line":58,"updated":"2016-05-05 19:40:49.000000000","message":"Reverse the argument order?","commit_id":"b154046643691d5b4b248b6a4d353991db14a798"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c783a94657cfbe577c432c3321fdb0f23394c759","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_cd44734b","line":1,"updated":"2016-05-11 11:54:15.000000000","message":"-1: Please remove VIM specific headers","commit_id":"1fc5cf146f9d0c4fd74150b1507ecb36a5ea4273"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5722bb09b81cb99eb66e054e88b7fa176cd46f22","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_3cf1ef6b","line":1,"in_reply_to":"dab17558_961efc09","updated":"2016-05-11 13:19:39.000000000","message":"rofl\n\nYou are totally right, as usual, I just saw something there at the beginning and assumed it was VIM specific without really reading it, sorry.  :-(","commit_id":"1fc5cf146f9d0c4fd74150b1507ecb36a5ea4273"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"eed0ed15f4017ec2356ba88c40448ec39bdd2e1d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":2,"context_line":"# Copyright 2016 Red Hat, Inc."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_961efc09","line":1,"in_reply_to":"dab17558_cd44734b","updated":"2016-05-11 12:44:23.000000000","message":"This isn\u0027t a vim header, it\u0027s a python header.  (The thought is that it\u0027s needed since I\u0027m using UTF8 literals?)","commit_id":"1fc5cf146f9d0c4fd74150b1507ecb36a5ea4273"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c783a94657cfbe577c432c3321fdb0f23394c759","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        # chars require utf8mb4 database support which may not"},{"line_number":33,"context_line":"        # be configured."},{"line_number":34,"context_line":"        cls.volume_name \u003d u\"CinderUnicodeTest塵㼗‽\""},{"line_number":35,"context_line":"        cls.volume \u003d cls.create_volume_with_args(name\u003dcls.volume_name)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def create_volume_with_args(cls, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_0d55dbc4","line":35,"updated":"2016-05-11 11:54:15.000000000","message":"-1: I believe volume creation should be part of the test itself, since we should be testing creation and deletion, and resource_setup is usually intended for resources that are required for the tests but not part of what we are trying to actually test.","commit_id":"1fc5cf146f9d0c4fd74150b1507ecb36a5ea4273"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c783a94657cfbe577c432c3321fdb0f23394c759","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cls.volume \u003d cls.create_volume_with_args(name\u003dcls.volume_name)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def create_volume_with_args(cls, **kwargs):"},{"line_number":39,"context_line":"        name \u003d kwargs[\u0027name\u0027] or data_utils.rand_name(\u0027Volume\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        name_field \u003d cls.special_fields[\u0027name_field\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4dbd23d7","line":38,"updated":"2016-05-11 11:54:15.000000000","message":"nit: I am of the opinion that create_volume method in tempest base class should be changed, but this makes sense in the meantime.","commit_id":"1fc5cf146f9d0c4fd74150b1507ecb36a5ea4273"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c783a94657cfbe577c432c3321fdb0f23394c759","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @classmethod"},{"line_number":38,"context_line":"    def create_volume_with_args(cls, **kwargs):"},{"line_number":39,"context_line":"        name \u003d kwargs[\u0027name\u0027] or data_utils.rand_name(\u0027Volume\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":42,"context_line":"        kwargs[name_field] \u003d name"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_ed99777a","line":39,"updated":"2016-05-11 11:54:15.000000000","message":"-1: If this is a specific method for this class name should be a positional argument, and if it\u0027s a generic method then it should be accessing name field as kwargs.get(\u0027name\u0027)","commit_id":"1fc5cf146f9d0c4fd74150b1507ecb36a5ea4273"}]}