)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"1adc34c963c96e30af09bc0557fbe10e593624a9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rajinir \u003crajini_ram@dell.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-03 11:35:11 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell Eqlx: Creat volume from snapshot does not honor new size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the volume being created from snapshot was larger than the"},{"line_number":10,"context_line":"snapshot the new volume was not being resized."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_bdd57ae6","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":61},"updated":"2016-05-03 19:23:40.000000000","message":"Creat -\u003e Create\n\nFirst line of commit message should be limited to 50 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"6513e4ade69e93e38c5eae9e3cdd169212453251"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"1adc34c963c96e30af09bc0557fbe10e593624a9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell Eqlx: Creat volume from snapshot does not honor new size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the volume being created from snapshot was larger than the"},{"line_number":10,"context_line":"snapshot the new volume was not being resized."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iefb7186c462b195b018619f426c36dede36ad180"},{"line_number":13,"context_line":"Closes-Bug: 1560637"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_5d59c68d","line":10,"range":{"start_line":9,"start_character":53,"end_line":10,"end_character":12},"updated":"2016-05-03 19:23:40.000000000","message":"Suggestion: than the snapshot, the new ...\n\nAlso it would be helpful to add how you are fixing this problem.","commit_id":"6513e4ade69e93e38c5eae9e3cdd169212453251"}],"cinder/tests/unit/test_eqlx.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"7892caeb04da350aa7015aecf1a67f49d1a5c15c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                model_update \u003d self.driver.create_volume_from_snapshot("},{"line_number":185,"context_line":"                    volume, snapshot)"},{"line_number":186,"context_line":"                self.assertEqual(self._model_update, model_update)"},{"line_number":187,"context_line":"                self.assertTrue(self.driver.extend_volume.called)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_create_cloned_volume(self):"},{"line_number":190,"context_line":"        src_vref \u003d {\u0027name\u0027: \u0027fake_uuid\u0027, \u0027size\u0027: \u00271\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_42c7e711","line":187,"updated":"2016-05-05 00:08:48.000000000","message":"It\u0027s better to assert the actual call made:\n\nself.driver.extend_volume.assert_called_once_with(volume, volume[\u0027size\u0027])","commit_id":"c873a4d7ef21ac074d7fe8a51b4ea79a1a3ace4b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1387df8d7012ecdf858a3e6f6327a9b028bc8f92","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                model_update \u003d self.driver.create_volume_from_snapshot("},{"line_number":185,"context_line":"                    volume, snapshot)"},{"line_number":186,"context_line":"                self.assertEqual(self._model_update, model_update)"},{"line_number":187,"context_line":"                self.assertTrue(self.driver.extend_volume.called)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_create_cloned_volume(self):"},{"line_number":190,"context_line":"        src_vref \u003d {\u0027name\u0027: \u0027fake_uuid\u0027, \u0027size\u0027: \u00271\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_5ab2084a","line":187,"in_reply_to":"1a122d0e_42c7e711","updated":"2016-05-05 16:24:16.000000000","message":"Sure, will fix it","commit_id":"c873a4d7ef21ac074d7fe8a51b4ea79a1a3ace4b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"152224be61773beb75e5bb34bfc13a5296a97236","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        with mock.patch.object(self.driver,"},{"line_number":158,"context_line":"                               \u0027_eql_execute\u0027) as mock_eql_execute:"},{"line_number":159,"context_line":"            with mock.patch.object(self.driver,"},{"line_number":160,"context_line":"                                   \u0027extend_volume\u0027) as mock_extend_volume:"},{"line_number":161,"context_line":"                mock_eql_execute.configure_mock(**mock_attrs)"},{"line_number":162,"context_line":"                mock_eql_execute.return_value \u003d self.fake_iqn_return"},{"line_number":163,"context_line":"                mock_extend_volume.return_value \u003d self.fake_iqn_return"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_ad91e154","line":160,"updated":"2016-05-12 16:09:14.000000000","message":"nit: These 2 mocks would look a lot better as method decorators.","commit_id":"79abfda613189a10af60202009d25858f47e2c28"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"152224be61773beb75e5bb34bfc13a5296a97236","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        with mock.patch.object(self.driver,"},{"line_number":178,"context_line":"                               \u0027_eql_execute\u0027) as mock_eql_execute:"},{"line_number":179,"context_line":"            with mock.patch.object(self.driver,"},{"line_number":180,"context_line":"                                   \u0027extend_volume\u0027) as mock_extend_volume:"},{"line_number":181,"context_line":"                mock_eql_execute.configure_mock(**mock_attrs)"},{"line_number":182,"context_line":"                mock_eql_execute.return_value \u003d volume"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_2d933151","line":179,"updated":"2016-05-12 16:09:14.000000000","message":"ditto","commit_id":"79abfda613189a10af60202009d25858f47e2c28"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"152224be61773beb75e5bb34bfc13a5296a97236","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                model_update \u003d self.driver.create_volume_from_snapshot("},{"line_number":185,"context_line":"                    volume, snapshot)"},{"line_number":186,"context_line":"                self.assertEqual(self._model_update, model_update)"},{"line_number":187,"context_line":"                self.assertTrue(self.driver.extend_volume.called)"},{"line_number":188,"context_line":"                self.driver.extend_volume.assert_called_once_with("},{"line_number":189,"context_line":"                    volume, volume[\u0027size\u0027])"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_2d085191","line":187,"updated":"2016-05-12 16:09:14.000000000","message":"nit: unnecessary since you are using assert_called_once with below, which already checks that it\u0027s called.","commit_id":"79abfda613189a10af60202009d25858f47e2c28"}],"cinder/volume/drivers/eqlx.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ab7d4ad4b8e3f63930465cafe6f3371eb87e50a1","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                    snapshot[\u0027volume_name\u0027], \u0027snapshot\u0027,"},{"line_number":490,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":491,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":492,"context_line":"            # Extend Volume if needed"},{"line_number":493,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027size\u0027]:"},{"line_number":494,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d6ec9094","line":492,"range":{"start_line":492,"start_character":12,"end_line":492,"end_character":37},"updated":"2016-05-03 23:42:27.000000000","message":"This is kind of a nit, but I think it would be good to add a log message here to indicate that it is doing this.  That way there are breadcrumbs in the case that someone is wondering how their volume ended up a different size than the snapshot.","commit_id":"6513e4ade69e93e38c5eae9e3cdd169212453251"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"7892caeb04da350aa7015aecf1a67f49d1a5c15c","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            # Extend Volume if needed"},{"line_number":492,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027size\u0027]:"},{"line_number":493,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"},{"line_number":494,"context_line":"                LOG.info(_LI(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":495,"context_line":"                         \u0027%(current_size)sGB to %(new_size)sGB.\u0027),"},{"line_number":496,"context_line":"                         {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":497,"context_line":"                          \u0027current_size\u0027: volume[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_e219d3d2","line":494,"updated":"2016-05-05 00:08:48.000000000","message":"There is already an info-level log in extend_volume. You can either remove it here or change to debug level.","commit_id":"c873a4d7ef21ac074d7fe8a51b4ea79a1a3ace4b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1387df8d7012ecdf858a3e6f6327a9b028bc8f92","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            # Extend Volume if needed"},{"line_number":492,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027size\u0027]:"},{"line_number":493,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"},{"line_number":494,"context_line":"                LOG.info(_LI(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":495,"context_line":"                         \u0027%(current_size)sGB to %(new_size)sGB.\u0027),"},{"line_number":496,"context_line":"                         {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":497,"context_line":"                          \u0027current_size\u0027: volume[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_7ae38434","line":494,"in_reply_to":"1a122d0e_e219d3d2","updated":"2016-05-05 16:24:16.000000000","message":"Good catch. Will change this is debug","commit_id":"c873a4d7ef21ac074d7fe8a51b4ea79a1a3ace4b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"7892caeb04da350aa7015aecf1a67f49d1a5c15c","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                LOG.info(_LI(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":495,"context_line":"                         \u0027%(current_size)sGB to %(new_size)sGB.\u0027),"},{"line_number":496,"context_line":"                         {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":497,"context_line":"                          \u0027current_size\u0027: volume[\u0027size\u0027],"},{"line_number":498,"context_line":"                          \u0027new_size\u0027: snapshot[\u0027size\u0027]})"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            self.add_multihost_access(volume)"},{"line_number":501,"context_line":"            return self._get_volume_data(out)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_42608735","line":498,"range":{"start_line":497,"start_character":26,"end_line":498,"end_character":54},"updated":"2016-05-05 00:08:48.000000000","message":"The current size is actually the snapshot size and the new size is volume size.","commit_id":"c873a4d7ef21ac074d7fe8a51b4ea79a1a3ace4b"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"1387df8d7012ecdf858a3e6f6327a9b028bc8f92","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                LOG.info(_LI(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":495,"context_line":"                         \u0027%(current_size)sGB to %(new_size)sGB.\u0027),"},{"line_number":496,"context_line":"                         {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":497,"context_line":"                          \u0027current_size\u0027: volume[\u0027size\u0027],"},{"line_number":498,"context_line":"                          \u0027new_size\u0027: snapshot[\u0027size\u0027]})"},{"line_number":499,"context_line":""},{"line_number":500,"context_line":"            self.add_multihost_access(volume)"},{"line_number":501,"context_line":"            return self._get_volume_data(out)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_7aba640c","line":498,"range":{"start_line":497,"start_character":26,"end_line":498,"end_character":54},"in_reply_to":"1a122d0e_42608735","updated":"2016-05-05 16:24:16.000000000","message":"Fixing it","commit_id":"c873a4d7ef21ac074d7fe8a51b4ea79a1a3ace4b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e0224e891c7dbb083b1d63010bccbbcdaf4d3837","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            # Extend Volume if needed"},{"line_number":492,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027size\u0027]:"},{"line_number":493,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"},{"line_number":494,"context_line":"                LOG.debug(_LI(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":495,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027),"},{"line_number":496,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":497,"context_line":"                           \u0027current_size\u0027: snapshot[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_0d31770b","line":494,"updated":"2016-05-05 18:58:10.000000000","message":"No need to translate debug level messages, please remove _LI().","commit_id":"8b7bb8bb7f48a1d591abf09d0a92924e5622ecb9"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"8606de1398dd547773bb99212023f205bf86d970","unresolved":false,"context_lines":[{"line_number":491,"context_line":"            # Extend Volume if needed"},{"line_number":492,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027size\u0027]:"},{"line_number":493,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"},{"line_number":494,"context_line":"                LOG.debug(_LI(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":495,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027),"},{"line_number":496,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":497,"context_line":"                           \u0027current_size\u0027: snapshot[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_32d1f0fc","line":494,"in_reply_to":"1a122d0e_0d31770b","updated":"2016-05-05 19:30:49.000000000","message":"Removed","commit_id":"8b7bb8bb7f48a1d591abf09d0a92924e5622ecb9"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"93dd5465ef16823d04b8eb46409ee19b47c68395","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self._stats \u003d data"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_size(self, volume):"},{"line_number":372,"context_line":"        \"\"\"Get the volume size on the array\"\"\""},{"line_number":373,"context_line":"        command \u003d [\u0027volume\u0027, \u0027select\u0027, volume[\u0027name\u0027], \u0027show\u0027]"},{"line_number":374,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_1f4e98c0","line":371,"range":{"start_line":371,"start_character":4,"end_line":371,"end_character":39},"updated":"2016-05-11 14:45:26.000000000","message":"I\u0027m going to leave the get_volume_size function as is , will be using it for implementing manage/unamage.","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ee9abe3ba233459dba91ff42744d6b92335ec5f8","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self._stats \u003d data"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_size(self, volume):"},{"line_number":372,"context_line":"        \"\"\"Get the volume size on the array\"\"\""},{"line_number":373,"context_line":"        command \u003d [\u0027volume\u0027, \u0027select\u0027, volume[\u0027name\u0027], \u0027show\u0027]"},{"line_number":374,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_d4098996","line":371,"range":{"start_line":371,"start_character":4,"end_line":371,"end_character":39},"in_reply_to":"dab17558_1f4e98c0","updated":"2016-05-11 18:19:40.000000000","message":"Then it should be added in that patch and not here, otherwise backports and things like that get crazy.","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fcc2688b15627b14b3fae4ba97b8b9fdc441a70d","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            out \u003d self._eql_execute(\u0027volume\u0027, \u0027select\u0027,"},{"line_number":504,"context_line":"                                    snapshot[\u0027volume_name\u0027], \u0027snapshot\u0027,"},{"line_number":505,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":506,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":507,"context_line":"            current_size \u003d self._get_volume_size(volume)"},{"line_number":508,"context_line":"            # Extend Volume if needed"},{"line_number":509,"context_line":"            if out and volume[\u0027size\u0027] \u003e current_size:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_87a40c08","line":506,"updated":"2016-05-11 11:11:55.000000000","message":"?: Is the backend really using volume name as ID?  Because that\u0027s a terrible bug!!!   Names could be repeated in cinder, we don\u0027t enforce uniqueness.","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"93dd5465ef16823d04b8eb46409ee19b47c68395","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            out \u003d self._eql_execute(\u0027volume\u0027, \u0027select\u0027,"},{"line_number":504,"context_line":"                                    snapshot[\u0027volume_name\u0027], \u0027snapshot\u0027,"},{"line_number":505,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":506,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":507,"context_line":"            current_size \u003d self._get_volume_size(volume)"},{"line_number":508,"context_line":"            # Extend Volume if needed"},{"line_number":509,"context_line":"            if out and volume[\u0027size\u0027] \u003e current_size:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_e97fa212","line":506,"in_reply_to":"dab17558_87a40c08","updated":"2016-05-11 14:45:26.000000000","message":"What you are referring to is display-name parameter which is not unique. This is volume-name and it is of format volume-\u003cid\u003e which is used by the backend and it is unique\neg: volume-91b78aa4-470f-4107-8023-b5d791240495","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ee9abe3ba233459dba91ff42744d6b92335ec5f8","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            out \u003d self._eql_execute(\u0027volume\u0027, \u0027select\u0027,"},{"line_number":504,"context_line":"                                    snapshot[\u0027volume_name\u0027], \u0027snapshot\u0027,"},{"line_number":505,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":506,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":507,"context_line":"            current_size \u003d self._get_volume_size(volume)"},{"line_number":508,"context_line":"            # Extend Volume if needed"},{"line_number":509,"context_line":"            if out and volume[\u0027size\u0027] \u003e current_size:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_140e718b","line":506,"in_reply_to":"dab17558_e97fa212","updated":"2016-05-11 18:19:40.000000000","message":"You are right, in other parts of the code we used to have volume[\u0027name\u0027] assigned to display_name, but is is an OVO, so this is an extra field.","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fcc2688b15627b14b3fae4ba97b8b9fdc441a70d","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                                    snapshot[\u0027volume_name\u0027], \u0027snapshot\u0027,"},{"line_number":505,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":506,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":507,"context_line":"            current_size \u003d self._get_volume_size(volume)"},{"line_number":508,"context_line":"            # Extend Volume if needed"},{"line_number":509,"context_line":"            if out and volume[\u0027size\u0027] \u003e current_size:"},{"line_number":510,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_07249dc2","line":507,"updated":"2016-05-11 11:11:55.000000000","message":"?: Why aren\u0027t you using snapshot.volume_size?  Does the backend have some kind of restrictions that will make allocated volume size not match the snapshot size?","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"93dd5465ef16823d04b8eb46409ee19b47c68395","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                                    snapshot[\u0027volume_name\u0027], \u0027snapshot\u0027,"},{"line_number":505,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":506,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":507,"context_line":"            current_size \u003d self._get_volume_size(volume)"},{"line_number":508,"context_line":"            # Extend Volume if needed"},{"line_number":509,"context_line":"            if out and volume[\u0027size\u0027] \u003e current_size:"},{"line_number":510,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_a9347a49","line":507,"in_reply_to":"dab17558_07249dc2","updated":"2016-05-11 14:45:26.000000000","message":"I was trying to use snapshot.size by mistake. Will upload a new patch with snapshot.volume_size.","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fcc2688b15627b14b3fae4ba97b8b9fdc441a70d","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"},{"line_number":513,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":514,"context_line":"                           \u0027current_size\u0027: current_size,"},{"line_number":515,"context_line":"                           \u0027new_size\u0027: volume[\u0027size\u0027]})"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"            self.add_multihost_access(volume)"},{"line_number":518,"context_line":"            return self._get_volume_data(out)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_8756cc03","line":515,"range":{"start_line":515,"start_character":39,"end_line":515,"end_character":53},"updated":"2016-05-11 11:11:55.000000000","message":"nit: We should stop using dictionary notation:\n\n volume.size","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ee9abe3ba233459dba91ff42744d6b92335ec5f8","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"},{"line_number":513,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":514,"context_line":"                           \u0027current_size\u0027: current_size,"},{"line_number":515,"context_line":"                           \u0027new_size\u0027: volume[\u0027size\u0027]})"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"            self.add_multihost_access(volume)"},{"line_number":518,"context_line":"            return self._get_volume_data(out)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_f4c92d27","line":515,"range":{"start_line":515,"start_character":39,"end_line":515,"end_character":53},"in_reply_to":"dab17558_692e12fc","updated":"2016-05-11 18:19:40.000000000","message":"I agree that we shouldn\u0027t change all the code, but if you are touching a part of the code, it would be a good opportunity to start changing them instead of a huge patch.  ;-)","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"93dd5465ef16823d04b8eb46409ee19b47c68395","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"},{"line_number":513,"context_line":"                          {\u0027name\u0027: volume[\u0027name\u0027],"},{"line_number":514,"context_line":"                           \u0027current_size\u0027: current_size,"},{"line_number":515,"context_line":"                           \u0027new_size\u0027: volume[\u0027size\u0027]})"},{"line_number":516,"context_line":""},{"line_number":517,"context_line":"            self.add_multihost_access(volume)"},{"line_number":518,"context_line":"            return self._get_volume_data(out)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_692e12fc","line":515,"range":{"start_line":515,"start_character":39,"end_line":515,"end_character":53},"in_reply_to":"dab17558_8756cc03","updated":"2016-05-11 14:45:26.000000000","message":"Agree, but this format is all over this driver code. I would prefer to submit a separate patch","commit_id":"f31868f2f380d5933438b09067b13c05d7f09754"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4b969478622756cbd97258a830d9a34cc0616505","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self._stats \u003d data"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_size(self, volume):"},{"line_number":372,"context_line":"        \"\"\"Get the volume size on the array\"\"\""},{"line_number":373,"context_line":"        command \u003d [\u0027volume\u0027, \u0027select\u0027, volume[\u0027name\u0027], \u0027show\u0027]"},{"line_number":374,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_14b83174","line":371,"updated":"2016-05-11 18:22:15.000000000","message":"-1: Since this is not needed for this patch it should not be added here.  You should add it in the manage/unmanage patch.","commit_id":"8cfc1c03699361b8ec89bf253431503bd4aa4d4a"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"684122dab3d3003277eb254f930a7edd9da87f61","unresolved":false,"context_lines":[{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        self._stats \u003d data"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def _get_volume_size(self, volume):"},{"line_number":372,"context_line":"        \"\"\"Get the volume size on the array\"\"\""},{"line_number":373,"context_line":"        command \u003d [\u0027volume\u0027, \u0027select\u0027, volume[\u0027name\u0027], \u0027show\u0027]"},{"line_number":374,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_ac6bd183","line":371,"in_reply_to":"dab17558_14b83174","updated":"2016-05-11 22:03:26.000000000","message":"Good Point about the backport. Will remove and upload a new patch. Thanks","commit_id":"8cfc1c03699361b8ec89bf253431503bd4aa4d4a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4b969478622756cbd97258a830d9a34cc0616505","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":506,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":507,"context_line":"            # Extend Volume if needed"},{"line_number":508,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":509,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"},{"line_number":510,"context_line":"                LOG.debug(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":511,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_346c5507","line":508,"updated":"2016-05-11 18:22:15.000000000","message":"nit: Dictionary notation should be avoided in new code.","commit_id":"8cfc1c03699361b8ec89bf253431503bd4aa4d4a"},{"author":{"_account_id":10379,"name":"Rajini Karthik","email":"rrajini@gmail.com","username":"rajinir"},"change_message_id":"684122dab3d3003277eb254f930a7edd9da87f61","unresolved":false,"context_lines":[{"line_number":505,"context_line":"                                    \u0027select\u0027, snapshot[\u0027name\u0027],"},{"line_number":506,"context_line":"                                    \u0027clone\u0027, volume[\u0027name\u0027])"},{"line_number":507,"context_line":"            # Extend Volume if needed"},{"line_number":508,"context_line":"            if out and volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":509,"context_line":"                out \u003d self.extend_volume(out, volume[\u0027size\u0027])"},{"line_number":510,"context_line":"                LOG.debug(\u0027Volume from snapshot %(name)s resized from \u0027"},{"line_number":511,"context_line":"                          \u0027%(current_size)sGB to %(new_size)sGB.\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_4c1ea50c","line":508,"in_reply_to":"dab17558_346c5507","updated":"2016-05-11 22:03:26.000000000","message":"agree, prefer to submit a separate patch only related to that in the whole driver code to keep it clean","commit_id":"8cfc1c03699361b8ec89bf253431503bd4aa4d4a"}]}