)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8cb1ce562b7765db6e5b6582d36052ae8c8061a5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- Every time we change a remote method\u0027s signature or add a new remote"},{"line_number":20,"context_line":"  method to an object the hash of that object changes and we need to"},{"line_number":21,"context_line":"  update our test_versions test, which is not necessary."},{"line_number":22,"context_line":"- This makes the linking of VOs with their list counterparts"},{"line_number":23,"context_line":"  problematic, because everyone will need to know that there is no need"},{"line_number":24,"context_line":"  to bump the version of a list object whenever they add or modify a"},{"line_number":25,"context_line":"  remotable method."},{"line_number":26,"context_line":"- We are executing unnecessary code with decorators, even if it\u0027s not"},{"line_number":27,"context_line":"  much, it\u0027s still wasted CPU time ."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9abb7d3a_435b8b2e","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":19},"updated":"2016-05-31 09:04:44.000000000","message":"I think this isn\u0027t really related now.","commit_id":"6d3eb3cee6f2300849e4bdc72492cb5fd6c28545"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ddf4456f5550d35ec2c81111f70bb5c95a633acf","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- Every time we change a remote method\u0027s signature or add a new remote"},{"line_number":20,"context_line":"  method to an object the hash of that object changes and we need to"},{"line_number":21,"context_line":"  update our test_versions test, which is not necessary."},{"line_number":22,"context_line":"- This makes the linking of VOs with their list counterparts"},{"line_number":23,"context_line":"  problematic, because everyone will need to know that there is no need"},{"line_number":24,"context_line":"  to bump the version of a list object whenever they add or modify a"},{"line_number":25,"context_line":"  remotable method."},{"line_number":26,"context_line":"- We are executing unnecessary code with decorators, even if it\u0027s not"},{"line_number":27,"context_line":"  much, it\u0027s still wasted CPU time ."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9abb7d3a_a894cf42","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":19},"in_reply_to":"9abb7d3a_1f3ef38b","updated":"2016-05-31 10:08:02.000000000","message":"My concern was on first \"linking\" part - we\u0027re not linking versions now and it seems that modifications of child doesn\u0027t change a hash. But well, it\u0027s not really very important - it\u0027s clear there\u0027s value in removing remotable decorators.","commit_id":"6d3eb3cee6f2300849e4bdc72492cb5fd6c28545"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7edfccfbb7304e58af7bf83f2439485ad004ddee","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- Every time we change a remote method\u0027s signature or add a new remote"},{"line_number":20,"context_line":"  method to an object the hash of that object changes and we need to"},{"line_number":21,"context_line":"  update our test_versions test, which is not necessary."},{"line_number":22,"context_line":"- This makes the linking of VOs with their list counterparts"},{"line_number":23,"context_line":"  problematic, because everyone will need to know that there is no need"},{"line_number":24,"context_line":"  to bump the version of a list object whenever they add or modify a"},{"line_number":25,"context_line":"  remotable method."},{"line_number":26,"context_line":"- We are executing unnecessary code with decorators, even if it\u0027s not"},{"line_number":27,"context_line":"  much, it\u0027s still wasted CPU time ."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9abb7d3a_1f3ef38b","line":25,"range":{"start_line":22,"start_character":0,"end_line":25,"end_character":19},"in_reply_to":"9abb7d3a_435b8b2e","updated":"2016-05-31 09:21:42.000000000","message":"I think it is, because it\u0027s still true.  If methods are remotable the hash of the object changes whenever you add or modify a method, and all objects that are related (lists, and related objects) will also report a hash change, and with the manifest backporting mechanism we are using we don\u0027t really require a version bump anyway but people will think they do.","commit_id":"6d3eb3cee6f2300849e4bdc72492cb5fd6c28545"}],"cinder/tests/unit/objects/test_objects.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"384f21d45a6cc0b469bacfc6788ba038e36cc53d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027Volume\u0027: \u00271.3-15ff1f42d4e8eb321aa8217dd46aa1e1\u0027,"},{"line_number":37,"context_line":"    \u0027VolumeAttachment\u0027: \u00271.0-b30dacf62b2030dd83d8a1603f1064ff\u0027,"},{"line_number":38,"context_line":"    \u0027VolumeAttachmentList\u0027: \u00271.0-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":39,"context_line":"    \u0027VolumeList\u0027: \u00271.3-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":40,"context_line":"    \u0027VolumeType\u0027: \u00271.1-6673dd9ce7c27e9c85279afb20833877\u0027,"},{"line_number":41,"context_line":"    \u0027VolumeTypeList\u0027: \u00271.1-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027"},{"line_number":42,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_f82f2c3c","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":57},"updated":"2016-05-24 10:27:39.000000000","message":"You\u0027re overwriting a change made in your earlier patch in this chain - you\u0027ve moved that line just after Volume entry.","commit_id":"0d447d0a3ab961701a747f523c3ab7122f22115e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"83a4fffee914bdef59ea861fa52ab1b27a139e97","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027Volume\u0027: \u00271.3-15ff1f42d4e8eb321aa8217dd46aa1e1\u0027,"},{"line_number":37,"context_line":"    \u0027VolumeAttachment\u0027: \u00271.0-b30dacf62b2030dd83d8a1603f1064ff\u0027,"},{"line_number":38,"context_line":"    \u0027VolumeAttachmentList\u0027: \u00271.0-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":39,"context_line":"    \u0027VolumeList\u0027: \u00271.3-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":40,"context_line":"    \u0027VolumeType\u0027: \u00271.1-6673dd9ce7c27e9c85279afb20833877\u0027,"},{"line_number":41,"context_line":"    \u0027VolumeTypeList\u0027: \u00271.1-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027"},{"line_number":42,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_15e8b97b","line":39,"range":{"start_line":39,"start_character":4,"end_line":39,"end_character":57},"in_reply_to":"bab6814e_f82f2c3c","updated":"2016-05-25 09:54:33.000000000","message":"Yup, with so many changes here I missed that, thanks.","commit_id":"0d447d0a3ab961701a747f523c3ab7122f22115e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f96005f7815d05d4788ecab169480d9091e07bd3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027VolumeAttachmentList\u0027: \u00271.0-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":41,"context_line":"    \u0027VolumeType\u0027: \u00271.0-6673dd9ce7c27e9c85279afb20833877\u0027,"},{"line_number":42,"context_line":"    \u0027VolumeTypeList\u0027: \u00271.1-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestObjectVersions(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9abb7d3a_9f806848","line":43,"updated":"2016-06-03 02:19:52.000000000","message":"the comment block above this suggests that these should only be changed when there is a version bump.  why the change?","commit_id":"efb855b1f6ccc1225e8ff6b9cc7ef4b05c4a9694"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"945292166bb21ff78ef94c3c4ea749071f9b4677","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027VolumeAttachmentList\u0027: \u00271.0-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":41,"context_line":"    \u0027VolumeType\u0027: \u00271.0-6673dd9ce7c27e9c85279afb20833877\u0027,"},{"line_number":42,"context_line":"    \u0027VolumeTypeList\u0027: \u00271.1-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestObjectVersions(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9abb7d3a_4de2c330","line":43,"in_reply_to":"9abb7d3a_6984e4b0","updated":"2016-06-03 12:10:20.000000000","message":"Walter, the hash changes regardless of the version bump, it depends on the fields and remotable methods so we can detect when we have to bump a version to avoid problems.  Since we are changing which methods are remotable the input data to the hashing function has changed and that\u0027s why the resulting hash changes as well.  In future patches if we change the signature of a method we will no longer have to change the hash because they are not remotable.","commit_id":"efb855b1f6ccc1225e8ff6b9cc7ef4b05c4a9694"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"6525688c64af192a348b68dd8110b05934e0f15b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027VolumeAttachmentList\u0027: \u00271.0-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":41,"context_line":"    \u0027VolumeType\u0027: \u00271.0-6673dd9ce7c27e9c85279afb20833877\u0027,"},{"line_number":42,"context_line":"    \u0027VolumeTypeList\u0027: \u00271.1-15ecf022a68ddbb8c2a6739cfc9f8f5e\u0027,"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class TestObjectVersions(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9abb7d3a_6984e4b0","line":43,"in_reply_to":"9abb7d3a_9f806848","updated":"2016-06-03 09:32:13.000000000","message":"As we\u0027re not using indirection API the @remotable decorators were actually noops. So it doesn\u0027t matter for the receiving service if service sending it supports these calls as remotable or not.\n\nTLDR: It\u0027s some o.vo magic we weren\u0027t using at all, so versions doesn\u0027t matter.","commit_id":"efb855b1f6ccc1225e8ff6b9cc7ef4b05c4a9694"}]}