)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"eaacbc8153f7d75b6d091edf7d035801d781ad57","unresolved":false,"context_lines":[{"line_number":17,"context_line":"As part of this we will also remove support for the older version of"},{"line_number":18,"context_line":"the python module. The newer versions are released and easily upgraded"},{"line_number":19,"context_line":"to."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Icf8595843e38381c6704fd6a9c66b752f91337a5"},{"line_number":22,"context_line":"Closes-Bug: #1579194"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_24733a82","line":20,"updated":"2016-05-06 21:03:51.000000000","message":"Does this need a DocImpact flag? Seems the docs should be update for the new version, not sure if you updated the Newton version already? Just looking at the Mitaka one... http://docs.openstack.org/mitaka/config-reference/block-storage/drivers/pure-storage-driver.html","commit_id":"2be7746ac19350a629364e6c68f07d86194222ca"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5e2f5f31fd66c1321ec7360f29941f69d94f4da9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"As part of this we will also remove support for the older version of"},{"line_number":18,"context_line":"the python module. The newer versions are released and easily upgraded"},{"line_number":19,"context_line":"to."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Icf8595843e38381c6704fd6a9c66b752f91337a5"},{"line_number":22,"context_line":"Closes-Bug: #1579194"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_c6a66952","line":20,"updated":"2016-05-10 04:26:09.000000000","message":"Please add a DocImpact flag if you need to do another patch set.","commit_id":"925ee611d54fc6780618e8f0a881359a79cfe776"}],"cinder/tests/unit/test_pure.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e6e16a9da58ebf7478bc9a9ea102217292925bcf","unresolved":false,"context_lines":[{"line_number":1904,"context_line":"            rest_version\u003dNone,"},{"line_number":1905,"context_line":"            verify_https\u003dTrue,"},{"line_number":1906,"context_line":"            ssl_cert\u003dcert_path,"},{"line_number":1907,"context_line":"            user_agent\u003dself.driver._user_agent,"},{"line_number":1908,"context_line":"        )"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_a2eb63af","line":1907,"updated":"2016-05-09 17:55:59.000000000","message":"nit: Should you check that _user_agent actually has what you want it to have? Maybe a good idea to mock platform and check against a value.","commit_id":"44137090ec829dff3aeaa7a5ea42d20ad332f561"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"7e37f6cb1b712ce20b12adbf65edd3cb580944f3","unresolved":false,"context_lines":[{"line_number":1904,"context_line":"            rest_version\u003dNone,"},{"line_number":1905,"context_line":"            verify_https\u003dTrue,"},{"line_number":1906,"context_line":"            ssl_cert\u003dcert_path,"},{"line_number":1907,"context_line":"            user_agent\u003dself.driver._user_agent,"},{"line_number":1908,"context_line":"        )"},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_98ce90b2","line":1907,"in_reply_to":"dab17558_a2eb63af","updated":"2016-05-09 18:59:04.000000000","message":"yea thats a good idea, I\u0027ll add a test","commit_id":"44137090ec829dff3aeaa7a5ea42d20ad332f561"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e6e16a9da58ebf7478bc9a9ea102217292925bcf","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027base\u0027: USER_AGENT_BASE,"},{"line_number":163,"context_line":"            \u0027class\u0027: self.__class__.__name__,"},{"line_number":164,"context_line":"            \u0027version\u0027: self.VERSION,"},{"line_number":165,"context_line":"            \u0027platform\u0027: platform.platform()"},{"line_number":166,"context_line":"        }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def parse_replication_configs(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_22aad370","line":165,"updated":"2016-05-09 17:55:59.000000000","message":"?: Is it really a good idea to pass the platform as part of the user agent?  On one hand you get more information, but on another, you have to use regex to match all request from the same user_agent as this includes the system release version...","commit_id":"44137090ec829dff3aeaa7a5ea42d20ad332f561"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"7e37f6cb1b712ce20b12adbf65edd3cb580944f3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027base\u0027: USER_AGENT_BASE,"},{"line_number":163,"context_line":"            \u0027class\u0027: self.__class__.__name__,"},{"line_number":164,"context_line":"            \u0027version\u0027: self.VERSION,"},{"line_number":165,"context_line":"            \u0027platform\u0027: platform.platform()"},{"line_number":166,"context_line":"        }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def parse_replication_configs(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_b86ef4fe","line":165,"in_reply_to":"dab17558_22aad370","updated":"2016-05-09 18:59:04.000000000","message":"Maybe :D\n\nFor the most part we only care about the first bits where it identifies itself as being the cinder driver and what version of the driver (which gives us a good indicator of what openstack release too). The platform stuff is basically just extra info we *might* want to do some kind of inspection on. We don\u0027t really need to track requests for the same user this way, the api token being used is already being traced and audited on the FlashArray. We mainly just need to know *what* is using the api token.","commit_id":"44137090ec829dff3aeaa7a5ea42d20ad332f561"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e95d60272faf0c7e4805ef7b3860753948da54b5","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027base\u0027: USER_AGENT_BASE,"},{"line_number":163,"context_line":"            \u0027class\u0027: self.__class__.__name__,"},{"line_number":164,"context_line":"            \u0027version\u0027: self.VERSION,"},{"line_number":165,"context_line":"            \u0027platform\u0027: platform.platform()"},{"line_number":166,"context_line":"        }"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def parse_replication_configs(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_5e518b35","line":165,"in_reply_to":"dab17558_b86ef4fe","updated":"2016-05-10 11:31:11.000000000","message":"Thanks for the detailed explanation.  I just wanted to point it out in case this could be an issue for you later on, but I see it won\u0027t.   :-)","commit_id":"44137090ec829dff3aeaa7a5ea42d20ad332f561"}]}