)]}'
{"cinder/scheduler/scheduler_options.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b1f425c433554aa18a68e56738d9d5e1de5d549e","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        last_modified \u003d self._get_file_timestamp(filename)"},{"line_number":98,"context_line":"        if (not last_modified or not self.last_modified or"},{"line_number":99,"context_line":"                last_modified \u003e self.last_modified):"},{"line_number":100,"context_line":"            self.data \u003d self._load_file(self._get_file_handle(filename))"},{"line_number":101,"context_line":"            self.last_modified \u003d last_modified"},{"line_number":102,"context_line":"        if not self.data:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FexI%3D","line":99,"updated":"2013-06-02 01:09:15.000000000","message":"I have to say I\u0027m not really a fan of this indentation on the if blocks...","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b77813f8061a8b4b3fbcc9fd46354245e7058cbb","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        last_modified \u003d self._get_file_timestamp(filename)"},{"line_number":98,"context_line":"        if (not last_modified or not self.last_modified or"},{"line_number":99,"context_line":"                last_modified \u003e self.last_modified):"},{"line_number":100,"context_line":"            self.data \u003d self._load_file(self._get_file_handle(filename))"},{"line_number":101,"context_line":"            self.last_modified \u003d last_modified"},{"line_number":102,"context_line":"        if not self.data:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F48%3D","line":99,"in_reply_to":"AAAAPH%2F%2FexI%3D","updated":"2013-06-04 05:35:58.000000000","message":"That\u0027s pep8 for ya, your indent on a multi line if should differentiate itself from the body of the if statement :)","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8e8a9bc8774f6ae0c6026c0240c2adf9766b93b3","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        last_modified \u003d self._get_file_timestamp(filename)"},{"line_number":98,"context_line":"        if (not last_modified or not self.last_modified or"},{"line_number":99,"context_line":"                last_modified \u003e self.last_modified):"},{"line_number":100,"context_line":"            self.data \u003d self._load_file(self._get_file_handle(filename))"},{"line_number":101,"context_line":"            self.last_modified \u003d last_modified"},{"line_number":102,"context_line":"        if not self.data:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F4Y%3D","line":99,"in_reply_to":"AAAAPX%2F%2F%2F48%3D","updated":"2013-06-04 05:45:14.000000000","message":"I agree this is a valid pep8 check, improves readability","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"}],"cinder/tests/api/contrib/test_scheduler_hints.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b1f425c433554aa18a68e56738d9d5e1de5d549e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":56,"context_line":"        body \u003d {\u0027id\u0027: id,"},{"line_number":57,"context_line":"                \u0027volume_type_id\u0027: \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027,"},{"line_number":58,"context_line":"                \u0027volume_id\u0027: \u00271\u0027, }"},{"line_number":59,"context_line":"        req.body \u003d jsonutils.dumps(body)"},{"line_number":60,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":61,"context_line":"        self.assertEqual(202, res.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FexE%3D","line":58,"updated":"2013-06-02 01:09:15.000000000","message":"Why not trim the trailing ,     since we are editing this formatting?","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b77813f8061a8b4b3fbcc9fd46354245e7058cbb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":56,"context_line":"        body \u003d {\u0027id\u0027: id,"},{"line_number":57,"context_line":"                \u0027volume_type_id\u0027: \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027,"},{"line_number":58,"context_line":"                \u0027volume_id\u0027: \u00271\u0027, }"},{"line_number":59,"context_line":"        req.body \u003d jsonutils.dumps(body)"},{"line_number":60,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":61,"context_line":"        self.assertEqual(202, res.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F40%3D","line":58,"in_reply_to":"AAAAPH%2F%2FexE%3D","updated":"2013-06-04 05:35:58.000000000","message":"Could\u0027ve sworn I answered this before \"dejas-vous\".  It\u0027s a pep8 error to not have a space between the , and the }","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8e8a9bc8774f6ae0c6026c0240c2adf9766b93b3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":56,"context_line":"        body \u003d {\u0027id\u0027: id,"},{"line_number":57,"context_line":"                \u0027volume_type_id\u0027: \u0027cedef40a-ed67-4d10-800e-17455edce175\u0027,"},{"line_number":58,"context_line":"                \u0027volume_id\u0027: \u00271\u0027, }"},{"line_number":59,"context_line":"        req.body \u003d jsonutils.dumps(body)"},{"line_number":60,"context_line":"        res \u003d req.get_response(self.app)"},{"line_number":61,"context_line":"        self.assertEqual(202, res.status_int)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F4U%3D","line":58,"in_reply_to":"AAAAPX%2F%2F%2F40%3D","updated":"2013-06-04 05:45:14.000000000","message":"The trailing \u0027,\u0027 is basically to improve commit diffs (for example, if one adds another key-value pair in this dict, the diff file will have only one line instead of two -- the other line being a comma added to the previously last key-value pair), and is only useful if we keep the ending brace on a new line..","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"}],"cinder/tests/test_rbd.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b1f425c433554aa18a68e56738d9d5e1de5d549e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                \u0027auth_enabled\u0027: False,"},{"line_number":241,"context_line":"                \u0027auth_username\u0027: None,"},{"line_number":242,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":243,"context_line":"                \u0027secret_uuid\u0027: None, }"},{"line_number":244,"context_line":"        }"},{"line_number":245,"context_line":"        actual \u003d self.driver.initialize_connection(dict(name\u003dname), None)"},{"line_number":246,"context_line":"        self.assertDictMatch(expected, actual)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Few0%3D","line":243,"updated":"2013-06-02 01:09:15.000000000","message":"remove trailing , ??","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b77813f8061a8b4b3fbcc9fd46354245e7058cbb","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                \u0027auth_enabled\u0027: False,"},{"line_number":241,"context_line":"                \u0027auth_username\u0027: None,"},{"line_number":242,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":243,"context_line":"                \u0027secret_uuid\u0027: None, }"},{"line_number":244,"context_line":"        }"},{"line_number":245,"context_line":"        actual \u003d self.driver.initialize_connection(dict(name\u003dname), None)"},{"line_number":246,"context_line":"        self.assertDictMatch(expected, actual)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F4w%3D","line":243,"in_reply_to":"AAAAPH%2F%2Fek4%3D","updated":"2013-06-04 05:35:58.000000000","message":"Ha!!  There it is :)  I knew I answered that one","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a9a1e08be991267a63b09b640f1057ff0da35cfd","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                \u0027auth_enabled\u0027: False,"},{"line_number":241,"context_line":"                \u0027auth_username\u0027: None,"},{"line_number":242,"context_line":"                \u0027secret_type\u0027: \u0027ceph\u0027,"},{"line_number":243,"context_line":"                \u0027secret_uuid\u0027: None, }"},{"line_number":244,"context_line":"        }"},{"line_number":245,"context_line":"        actual \u003d self.driver.initialize_connection(dict(name\u003dname), None)"},{"line_number":246,"context_line":"        self.assertDictMatch(expected, actual)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fek4%3D","line":243,"in_reply_to":"AAAAPH%2F%2Few0%3D","updated":"2013-06-02 15:10:12.000000000","message":"that would actually introduce another pep8 error :)","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"}],"cinder/volume/__init__.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"5fe457fa943c7351c320c2e702a1d98b8465cc75","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Importing full names to not pollute the namespace and cause possible"},{"line_number":20,"context_line":"# collisions with use of \u0027from cinder.volume import \u003cfoo\u003e\u0027 elsewhere."},{"line_number":21,"context_line":"import cinder.flags as flags"},{"line_number":22,"context_line":"import cinder.openstack.common.importutils as import_utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"API \u003d import_utils.import_class(flags.FLAGS.volume_api_class)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F8A%3D","line":21,"updated":"2013-06-04 04:21:21.000000000","message":"Is there a reason for this alias?","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9158c7676bbe3104269de3f8edcf380e0fc8e960","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Importing full names to not pollute the namespace and cause possible"},{"line_number":20,"context_line":"# collisions with use of \u0027from cinder.volume import \u003cfoo\u003e\u0027 elsewhere."},{"line_number":21,"context_line":"import cinder.flags as flags"},{"line_number":22,"context_line":"import cinder.openstack.common.importutils as import_utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"API \u003d import_utils.import_class(flags.FLAGS.volume_api_class)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F3w%3D","line":21,"in_reply_to":"AAAAPX%2F%2F%2F4M%3D","updated":"2013-06-04 05:52:56.000000000","message":"TBH I don\u0027t really care, this goes away in the config update patch anyway :)\n\nIf you guys want to -1 that\u0027s fine, or I can just abandon.  The only reason I went through these was because it was supposed to be a quick fix, I\u0027ve spent more time answering questions on the review than I did making the changes","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8e8a9bc8774f6ae0c6026c0240c2adf9766b93b3","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Importing full names to not pollute the namespace and cause possible"},{"line_number":20,"context_line":"# collisions with use of \u0027from cinder.volume import \u003cfoo\u003e\u0027 elsewhere."},{"line_number":21,"context_line":"import cinder.flags as flags"},{"line_number":22,"context_line":"import cinder.openstack.common.importutils as import_utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"API \u003d import_utils.import_class(flags.FLAGS.volume_api_class)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F4M%3D","line":21,"in_reply_to":"AAAAPX%2F%2F%2F4k%3D","updated":"2013-06-04 05:45:14.000000000","message":"How about this? :\n\n from cinder import flags","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b77813f8061a8b4b3fbcc9fd46354245e7058cbb","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Importing full names to not pollute the namespace and cause possible"},{"line_number":20,"context_line":"# collisions with use of \u0027from cinder.volume import \u003cfoo\u003e\u0027 elsewhere."},{"line_number":21,"context_line":"import cinder.flags as flags"},{"line_number":22,"context_line":"import cinder.openstack.common.importutils as import_utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"API \u003d import_utils.import_class(flags.FLAGS.volume_api_class)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2F4k%3D","line":21,"in_reply_to":"AAAAPX%2F%2F%2F8A%3D","updated":"2013-06-04 05:35:58.000000000","message":"On both of them I did that to \"shorten\" the length of the line.  Honestly I personally prefer \"import xxx as yy\" rather than having xxx.yyy.zzz all over the place.\n\ns/cinder.flags/flags/  \u003d 7 fewer chars\ns/cinder.openstack/common.importutils/import_utils/ \u003d 24 fewer chars\n\nand programmatically there\u0027s no difference","commit_id":"3c06ab98250d02302cfb9b1804951f839d413f4f"}],"cinder/volume/drivers/emc/emc_smis_common.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"8179ba399fdc445557e7d2eb35269ce9a99f845c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                     \u0027pool\u0027: str(pool),"},{"line_number":101,"context_line":"                     \u0027storage_system\u0027: storage_system})"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        configservice \u003d self._find_storage_configuration_service("},{"line_number":104,"context_line":"                            storage_system)"},{"line_number":105,"context_line":"        if configservice is None:"},{"line_number":106,"context_line":"            exception_message \u003d (_(\"Error Create Volume: %(volumename)s. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fe0c%3D","side":"PARENT","line":103,"updated":"2013-06-01 20:43:02.000000000","message":"I personally like this type of formatting more..","commit_id":"50667f178ee5ae5d1638b88a4af1902a57fc5152"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c519e9ad065372c71adc9b6e0588f9bff0d48553","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                     \u0027pool\u0027: str(pool),"},{"line_number":101,"context_line":"                     \u0027storage_system\u0027: storage_system})"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        configservice \u003d self._find_storage_configuration_service("},{"line_number":104,"context_line":"                            storage_system)"},{"line_number":105,"context_line":"        if configservice is None:"},{"line_number":106,"context_line":"            exception_message \u003d (_(\"Error Create Volume: %(volumename)s. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fez0%3D","side":"PARENT","line":103,"in_reply_to":"AAAAPH%2F%2Fe0c%3D","updated":"2013-06-01 21:55:53.000000000","message":"I would have to agree with you, however pep8 does not like it :(\n\nThe options other than the change I made is it to do something like:\nconfigservice \u003d\\\n    self._find_stroage_configuration_service(storage_system)\n\nOr just go back to ignoring these types of errors altogether.","commit_id":"50667f178ee5ae5d1638b88a4af1902a57fc5152"}]}