)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0968bea828e29893c2a692ad4186452b3b2a0977","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kushal Wathore \u003ckushal.wathore@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-06 03:08:58 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This commit has unit test cases for get_pool function and"},{"line_number":8,"context_line":"exception part of  _login function of FC and ISCSI of 3par driver."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: If0dad1913f1646075c412fc6e08f33ef0baec7c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dab17558_af07da7f","line":7,"updated":"2016-05-09 12:43:50.000000000","message":"Please amend this commit message to follow the commit message guidelines:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"8af50cd14bbc3f11089a273008a853014859e449"}],"cinder/tests/unit/fake_hpe_client_exceptions.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"fe789a83033d6d48075535256930df2a3d6cb7cc","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    message \u003d \"Bad request\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class HTTPUnauthorized(ClientException):"},{"line_number":104,"context_line":"    http_status \u003d 401"},{"line_number":105,"context_line":"    message \u003d \"Unauthorized\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class HTTPServerError(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_1e442cb5","line":105,"range":{"start_line":103,"start_character":0,"end_line":105,"end_character":28},"updated":"2016-05-16 08:11:01.000000000","message":"I\u0027m confused as to why we have these exceptions defined in the fake at all - they make the unit tests essentially meaningless. Both the fake and the test should reference the real exceptions that are used in the code","commit_id":"9a3ecb2f374fd570ee9ddbc864d3be07a840e987"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ced5cbf257623206d3bd8c8d704cf31c150f3295","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    message \u003d \"Bad request\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class HTTPUnauthorized(ClientException):"},{"line_number":104,"context_line":"    http_status \u003d 401"},{"line_number":105,"context_line":"    message \u003d \"Unauthorized\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class HTTPServerError(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_7b14cff4","line":105,"range":{"start_line":103,"start_character":0,"end_line":105,"end_character":28},"in_reply_to":"9abb7d3a_267ce21f","updated":"2016-06-06 08:55:19.000000000","message":"Thanks for the clarification.","commit_id":"9a3ecb2f374fd570ee9ddbc864d3be07a840e987"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"645433a39b7d1914330dfd66af942967d927b836","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    message \u003d \"Bad request\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class HTTPUnauthorized(ClientException):"},{"line_number":104,"context_line":"    http_status \u003d 401"},{"line_number":105,"context_line":"    message \u003d \"Unauthorized\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class HTTPServerError(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_082957e6","line":105,"range":{"start_line":103,"start_character":0,"end_line":105,"end_character":28},"in_reply_to":"dab17558_1e442cb5","updated":"2016-05-18 03:45:43.000000000","message":"As per my understanding, test_hpe3par.py uses fake_hpe_3par_client.py file as 3par client and this fake client uses fake_hpe_client_exceptions.py file for hpeexceptions.\nHTTPUnauthorized exceptions was not present in   fake_hpe_client_exceptions.py file hence need to add this exception so that test_hpe3par.py can use HTTPUnauthorized\nException.","commit_id":"9a3ecb2f374fd570ee9ddbc864d3be07a840e987"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"437d31f33d541b47c5abd0693b36684911c0fba9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    message \u003d \"Bad request\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"class HTTPUnauthorized(ClientException):"},{"line_number":104,"context_line":"    http_status \u003d 401"},{"line_number":105,"context_line":"    message \u003d \"Unauthorized\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class HTTPServerError(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_267ce21f","line":105,"range":{"start_line":103,"start_character":0,"end_line":105,"end_character":28},"in_reply_to":"dab17558_1e442cb5","updated":"2016-06-02 22:22:19.000000000","message":"The problem is that we can\u0027t require that the real library is installed (python-3parclient) when running the tests against the check/gate upstream.  So, if we want to tests for these specific exceptions, we have to copy any of the existing client lib exceptions that are defined here:\nhttps://github.com/hpe-storage/python-3parclient/blob/master/hpe3parclient/exceptions.py#L189","commit_id":"9a3ecb2f374fd570ee9ddbc864d3be07a840e987"}],"cinder/tests/unit/test_hpe3par.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"eac316b21c6452a4d50406b2cb0e6f022873d839","unresolved":false,"context_lines":[{"line_number":4365,"context_line":"            expected \u003d ["},{"line_number":4366,"context_line":"                mock.call.login(HPE3PAR_USER_NAME, HPE3PAR_USER_PASS)"},{"line_number":4367,"context_line":"            ]"},{"line_number":4368,"context_line":"            try:"},{"line_number":4369,"context_line":"                self.assertRaises("},{"line_number":4370,"context_line":"                    hpeexceptions.HTTPUnauthorized,"},{"line_number":4371,"context_line":"                    self.driver._login)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_259b0a74","line":4368,"updated":"2016-05-13 17:54:41.000000000","message":"It shouldn\u0027t be necessary to do a try/except like this.  The test should either look for HTTPUnauthorized, or InvalidInput, not both.","commit_id":"731705e08adf0989963464e7c35fbbf8fa41ec07"}]}